2019-08-12 09:37:29

by Arnd Bergmann

[permalink] [raw]
Subject: [PATCH] dma: ti: unexport filter functions

The two filter functions are now marked stable, but still exported,
which triggers a coming build-time check:

WARNING: "omap_dma_filter_fn" [vmlinux] is a static EXPORT_SYMBOL_GPL
WARNING: "edma_filter_fn" [vmlinux] is a static EXPORT_SYMBOL

Remove the unneeded exports as well, as originally intended.

Fixes: 9c71b9eb3cb2 ("dmaengine: omap-dma: make omap_dma_filter_fn private")
Fixes: d2bfe7b5d182 ("dmaengine: edma: make edma_filter_fn private")
Reported-by: Stephen Rothwell <[email protected]>
Signed-off-by: Arnd Bergmann <[email protected]>
---
drivers/dma/ti/edma.c | 1 -
drivers/dma/ti/omap-dma.c | 1 -
2 files changed, 2 deletions(-)

diff --git a/drivers/dma/ti/edma.c b/drivers/dma/ti/edma.c
index f2549ee3fb49..ea028388451a 100644
--- a/drivers/dma/ti/edma.c
+++ b/drivers/dma/ti/edma.c
@@ -2540,7 +2540,6 @@ static bool edma_filter_fn(struct dma_chan *chan, void *param)
}
return match;
}
-EXPORT_SYMBOL(edma_filter_fn);

static int edma_init(void)
{
diff --git a/drivers/dma/ti/omap-dma.c b/drivers/dma/ti/omap-dma.c
index 49da402a1927..98b39bcb7b37 100644
--- a/drivers/dma/ti/omap-dma.c
+++ b/drivers/dma/ti/omap-dma.c
@@ -1652,7 +1652,6 @@ static bool omap_dma_filter_fn(struct dma_chan *chan, void *param)
}
return false;
}
-EXPORT_SYMBOL_GPL(omap_dma_filter_fn);

static int omap_dma_init(void)
{
--
2.20.0


2019-08-12 10:07:43

by Stephen Rothwell

[permalink] [raw]
Subject: Re: [PATCH] dma: ti: unexport filter functions

Hi Arnd,

Just a nit.

On Mon, 12 Aug 2019 11:36:03 +0200 Arnd Bergmann <[email protected]> wrote:
>
> The two filter functions are now marked stable, but still exported,
^^^^^^
static ...

--
Cheers,
Stephen Rothwell

Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2019-08-12 10:12:05

by Peter Ujfalusi

[permalink] [raw]
Subject: Re: [PATCH] dma: ti: unexport filter functions



On 12/08/2019 12.36, Arnd Bergmann wrote:
> The two filter functions are now marked stable, but still exported,
> which triggers a coming build-time check:
>
> WARNING: "omap_dma_filter_fn" [vmlinux] is a static EXPORT_SYMBOL_GPL
> WARNING: "edma_filter_fn" [vmlinux] is a static EXPORT_SYMBOL
>
> Remove the unneeded exports as well, as originally intended.
>
> Fixes: 9c71b9eb3cb2 ("dmaengine: omap-dma: make omap_dma_filter_fn private")
> Fixes: d2bfe7b5d182 ("dmaengine: edma: make edma_filter_fn private")
> Reported-by: Stephen Rothwell <[email protected]>
> Signed-off-by: Arnd Bergmann <[email protected]>

Acked-by: Peter Ujfalusi <[email protected]>

> ---
> drivers/dma/ti/edma.c | 1 -
> drivers/dma/ti/omap-dma.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/drivers/dma/ti/edma.c b/drivers/dma/ti/edma.c
> index f2549ee3fb49..ea028388451a 100644
> --- a/drivers/dma/ti/edma.c
> +++ b/drivers/dma/ti/edma.c
> @@ -2540,7 +2540,6 @@ static bool edma_filter_fn(struct dma_chan *chan, void *param)
> }
> return match;
> }
> -EXPORT_SYMBOL(edma_filter_fn);
>
> static int edma_init(void)
> {
> diff --git a/drivers/dma/ti/omap-dma.c b/drivers/dma/ti/omap-dma.c
> index 49da402a1927..98b39bcb7b37 100644
> --- a/drivers/dma/ti/omap-dma.c
> +++ b/drivers/dma/ti/omap-dma.c
> @@ -1652,7 +1652,6 @@ static bool omap_dma_filter_fn(struct dma_chan *chan, void *param)
> }
> return false;
> }
> -EXPORT_SYMBOL_GPL(omap_dma_filter_fn);
>
> static int omap_dma_init(void)
> {
>

- Péter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki