2019-08-15 11:48:37

by Miles Chen

[permalink] [raw]
Subject: [PATCH] lib/stackdepot: fix obsolete comments

This change replaces "depot_save_stack" with "stack_depot_save"
in code comments because that depot_save_stack() is replaced by
stack_depot_save() in commit c0cfc337264c ("lib/stackdepot: Provide
functions which operate on plain storage arrays") and depot_save_stack()
is removed in commit 56d8f079c51a ("lib/stackdepot: Remove
obsolete functions")

Cc: Thomas Gleixner <[email protected]>
Cc: Alexander Potapenko <[email protected]>
Cc: Josh Poimboeuf <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
Cc: Kate Stewart <[email protected]>
Signed-off-by: Miles Chen <[email protected]>
---
lib/stackdepot.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/stackdepot.c b/lib/stackdepot.c
index 66cab785bea0..ed717dd08ff3 100644
--- a/lib/stackdepot.c
+++ b/lib/stackdepot.c
@@ -87,7 +87,7 @@ static bool init_stack_slab(void **prealloc)
stack_slabs[depot_index + 1] = *prealloc;
/*
* This smp_store_release pairs with smp_load_acquire() from
- * |next_slab_inited| above and in depot_save_stack().
+ * |next_slab_inited| above and in stack_depot_save().
*/
smp_store_release(&next_slab_inited, 1);
}
@@ -114,7 +114,7 @@ static struct stack_record *depot_alloc_stack(unsigned long *entries, int size,
depot_offset = 0;
/*
* smp_store_release() here pairs with smp_load_acquire() from
- * |next_slab_inited| in depot_save_stack() and
+ * |next_slab_inited| in stack_depot_save() and
* init_stack_slab().
*/
if (depot_index + 1 < STACK_ALLOC_MAX_SLABS)
--
2.18.0


Subject: [tip:core/stacktrace] lib/stackdepot: Fix outdated comments

Commit-ID: ee050dc83bc326ad5ef8ee93bca344819371e7a5
Gitweb: https://git.kernel.org/tip/ee050dc83bc326ad5ef8ee93bca344819371e7a5
Author: Miles Chen <[email protected]>
AuthorDate: Thu, 15 Aug 2019 19:32:46 +0800
Committer: Thomas Gleixner <[email protected]>
CommitDate: Mon, 19 Aug 2019 12:57:28 +0200

lib/stackdepot: Fix outdated comments

Replace "depot_save_stack" with "stack_depot_save" in code comments because
depot_save_stack() was replaced in commit c0cfc337264c ("lib/stackdepot:
Provide functions which operate on plain storage arrays") and removed in
commit 56d8f079c51a ("lib/stackdepot: Remove obsolete functions")

Signed-off-by: Miles Chen <[email protected]>
Signed-off-by: Thomas Gleixner <[email protected]>
Link: https://lkml.kernel.org/r/[email protected]

---
lib/stackdepot.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/stackdepot.c b/lib/stackdepot.c
index 66cab785bea0..ed717dd08ff3 100644
--- a/lib/stackdepot.c
+++ b/lib/stackdepot.c
@@ -87,7 +87,7 @@ static bool init_stack_slab(void **prealloc)
stack_slabs[depot_index + 1] = *prealloc;
/*
* This smp_store_release pairs with smp_load_acquire() from
- * |next_slab_inited| above and in depot_save_stack().
+ * |next_slab_inited| above and in stack_depot_save().
*/
smp_store_release(&next_slab_inited, 1);
}
@@ -114,7 +114,7 @@ static struct stack_record *depot_alloc_stack(unsigned long *entries, int size,
depot_offset = 0;
/*
* smp_store_release() here pairs with smp_load_acquire() from
- * |next_slab_inited| in depot_save_stack() and
+ * |next_slab_inited| in stack_depot_save() and
* init_stack_slab().
*/
if (depot_index + 1 < STACK_ALLOC_MAX_SLABS)