2019-08-19 06:06:51

by Krzysztof Wilczyński

Subject: [PATCH] x86/PCI: Replace deprecated EXTRA_CFLAGS with ccflags-y.

Update arch/x86/pci/Makefile replacing the deprecated EXTRA_CFLAGS
with the ccflags-y matching recommendation as per the section 3.7
"Compilation flags" of the "Linux Kernel Makefiles" (see:
Documentation/kbuild/makefiles.txt).

Signed-off-by: Krzysztof Wilczynski <[email protected]>
---
arch/x86/pci/Makefile | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/arch/x86/pci/Makefile b/arch/x86/pci/Makefile
index c806b57d3f22..48bcada5cabe 100644
--- a/arch/x86/pci/Makefile
+++ b/arch/x86/pci/Makefile
@@ -24,6 +24,4 @@ obj-y += bus_numa.o
obj-$(CONFIG_AMD_NB) += amd_bus.o
obj-$(CONFIG_PCI_CNB20LE_QUIRK) += broadcom_bus.o

-ifeq ($(CONFIG_PCI_DEBUG),y)
-EXTRA_CFLAGS += -DDEBUG
-endif
+ccflags-$(CONFIG_PCI_DEBUG) += -DDEBUG
--
2.22.0

2019-09-30 23:04:52

by Bjorn Helgaas

Subject: Re: [PATCH] x86/PCI: Replace deprecated EXTRA_CFLAGS with ccflags-y.

On Mon, Aug 19, 2019 at 08:05:32AM +0200, Krzysztof Wilczynski wrote:
> Update arch/x86/pci/Makefile replacing the deprecated EXTRA_CFLAGS
> with the ccflags-y matching recommendation as per the section 3.7
> "Compilation flags" of the "Linux Kernel Makefiles" (see:
> Documentation/kbuild/makefiles.txt).
>
> Signed-off-by: Krzysztof Wilczynski <[email protected]>

Applied to pci/misc for v5.5, thanks!

> ---
> arch/x86/pci/Makefile | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/arch/x86/pci/Makefile b/arch/x86/pci/Makefile
> index c806b57d3f22..48bcada5cabe 100644
> --- a/arch/x86/pci/Makefile
> +++ b/arch/x86/pci/Makefile
> @@ -24,6 +24,4 @@ obj-y += bus_numa.o
> obj-$(CONFIG_AMD_NB) += amd_bus.o
> obj-$(CONFIG_PCI_CNB20LE_QUIRK) += broadcom_bus.o
>
> -ifeq ($(CONFIG_PCI_DEBUG),y)
> -EXTRA_CFLAGS += -DDEBUG
> -endif
> +ccflags-$(CONFIG_PCI_DEBUG) += -DDEBUG
> --
> 2.22.0
>