2019-08-21 10:06:07

by Jisheng Zhang

Subject: [PATCH] kprobes/parisc: remove arch_kprobe_on_func_entry()

The common kprobes provides a weak implementation of
arch_kprobe_on_func_entry(). The parisc version is the same as the
common version, so remove it.

Signed-off-by: Jisheng Zhang <[email protected]>
---
arch/parisc/kernel/kprobes.c | 4 ----
1 file changed, 4 deletions(-)

diff --git a/arch/parisc/kernel/kprobes.c b/arch/parisc/kernel/kprobes.c
index 5d7f2692ac5a..77ec51818916 100644
--- a/arch/parisc/kernel/kprobes.c
+++ b/arch/parisc/kernel/kprobes.c
@@ -281,10 +281,6 @@ int __kprobes arch_trampoline_kprobe(struct kprobe *p)
{
return p->addr == trampoline_p.addr;
}
-bool arch_kprobe_on_func_entry(unsigned long offset)
-{
- return !offset;
-}

int __init arch_init_kprobes(void)
{
--
2.23.0.rc1

2019-08-21 11:55:06

by Sven Schnelle

Subject: Re: [PATCH] kprobes/parisc: remove arch_kprobe_on_func_entry()

On Wed, Aug 21, 2019 at 09:56:40AM +0000, Jisheng Zhang wrote:
> The common kprobes provides a weak implementation of
> arch_kprobe_on_func_entry(). The parisc version is the same as the
> common version, so remove it.
>
> Signed-off-by: Jisheng Zhang <[email protected]>

Acked-by: Sven Schnelle <[email protected]>

> ---
> arch/parisc/kernel/kprobes.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/arch/parisc/kernel/kprobes.c b/arch/parisc/kernel/kprobes.c
> index 5d7f2692ac5a..77ec51818916 100644
> --- a/arch/parisc/kernel/kprobes.c
> +++ b/arch/parisc/kernel/kprobes.c
> @@ -281,10 +281,6 @@ int __kprobes arch_trampoline_kprobe(struct kprobe *p)
> {
> return p->addr == trampoline_p.addr;
> }
> -bool arch_kprobe_on_func_entry(unsigned long offset)
> -{
> - return !offset;
> -}
>
> int __init arch_init_kprobes(void)
> {
> --
> 2.23.0.rc1
>