2019-08-19 08:04:39

by James Qian Wang

Subject: [PATCH] drm/komeda: Fix error: not allocating enough data 1592 vs 1584

The patch 5d51f6c0da1b: "drm/komeda: Add writeback support" from May
23, 2019, leads to the following static checker warning:

drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c:151 komeda_wb_connector_add()
error: not allocating enough data 1592 vs 1584

This is a typo which misuse "wb_conn" but which should be "kwb_conn" to
allocate the memory.

Reported-by: Dan Carpenter <[email protected]>
Signed-off-by: james qian wang (Arm Technology China) <[email protected]>
---
drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c b/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c
index 617e1f7b8472..2851cac94d86 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c
@@ -148,7 +148,7 @@ static int komeda_wb_connector_add(struct komeda_kms_dev *kms,
if (!kcrtc->master->wb_layer)
return 0;

- kwb_conn = kzalloc(sizeof(*wb_conn), GFP_KERNEL);
+ kwb_conn = kzalloc(sizeof(*kwb_conn), GFP_KERNEL);
if (!kwb_conn)
return -ENOMEM;

--
2.20.1

2019-08-22 12:33:35

by Ayan Halder

Subject: Re: [PATCH] drm/komeda: Fix error: not allocating enough data 1592 vs 1584

On Mon, Aug 19, 2019 at 08:01:57AM +0000, james qian wang (Arm Technology China) wrote:
> The patch 5d51f6c0da1b: "drm/komeda: Add writeback support" from May
> 23, 2019, leads to the following static checker warning:
>
> drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c:151 komeda_wb_connector_add()
> error: not allocating enough data 1592 vs 1584
>
> This is a typo which misuse "wb_conn" but which should be "kwb_conn" to
> allocate the memory.
>
> Reported-by: Dan Carpenter <[email protected]>
> Signed-off-by: james qian wang (Arm Technology China) <[email protected]>
> ---
> drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c b/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c
> index 617e1f7b8472..2851cac94d86 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c
> @@ -148,7 +148,7 @@ static int komeda_wb_connector_add(struct komeda_kms_dev *kms,
> if (!kcrtc->master->wb_layer)
> return 0;
>
> - kwb_conn = kzalloc(sizeof(*wb_conn), GFP_KERNEL);
> + kwb_conn = kzalloc(sizeof(*kwb_conn), GFP_KERNEL);
> if (!kwb_conn)
> return -ENOMEM;
>
> --
Reviewed-by: Ayan Kumar Halder <[email protected]>
> 2.20.1