The spi-nor controller defaults to BSPI mode, hence switch back
to its default mode after MSPI operations (write or erase)
are completed.
Changes from V1:
- Address code review comment from Mark Brown.
Signed-off-by: Rayagonda Kokatanur <[email protected]>
Reviewed-by: Mark Brown <[email protected]>
Reviewed-by: Kamal Dasu <[email protected]>
---
drivers/spi/spi-bcm-qspi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/spi/spi-bcm-qspi.c b/drivers/spi/spi-bcm-qspi.c
index 902bdbf..46a811a 100644
--- a/drivers/spi/spi-bcm-qspi.c
+++ b/drivers/spi/spi-bcm-qspi.c
@@ -897,6 +897,7 @@ static int bcm_qspi_transfer_one(struct spi_master *master,
read_from_hw(qspi, slots);
}
+ bcm_qspi_enable_bspi(qspi);
return 0;
}
--
1.9.1
On Thu, Aug 29, 2019 at 09:46:13AM +0530, Rayagonda Kokatanur wrote:
> The spi-nor controller defaults to BSPI mode, hence switch back
> to its default mode after MSPI operations (write or erase)
> are completed.
>
> Changes from V1:
> - Address code review comment from Mark Brown.
As covered in submitting-patches.rst inter-version changelogs should go
after the --- so they don't end up in git.
On Thu, Aug 29, 2019 at 3:29 PM Mark Brown <[email protected]> wrote:
>
> On Thu, Aug 29, 2019 at 09:46:13AM +0530, Rayagonda Kokatanur wrote:
> > The spi-nor controller defaults to BSPI mode, hence switch back
> > to its default mode after MSPI operations (write or erase)
> > are completed.
> >
> > Changes from V1:
> > - Address code review comment from Mark Brown.
>
> As covered in submitting-patches.rst inter-version changelogs should go
> after the --- so they don't end up in git.
Thank you, I fixed it and sent patch v3 for review.