2019-08-30 13:12:16

by Tejun Heo

Subject: [PATCH block/for-next] blkcg: add missing NULL check in ioc_cpd_alloc()

ioc_cpd_alloc() forgot to check NULL return from kzalloc(). Add it.

Signed-off-by: Tejun Heo <[email protected]>
Reported-by: kbuild test robot <[email protected]>
---
block/blk-iocost.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/block/blk-iocost.c b/block/blk-iocost.c
index 9c8046ac5925..2aae8ec391ef 100644
--- a/block/blk-iocost.c
+++ b/block/blk-iocost.c
@@ -1888,8 +1888,10 @@ static struct blkcg_policy_data *ioc_cpd_alloc(gfp_t gfp)
struct ioc_cgrp *iocc;

iocc = kzalloc(sizeof(struct ioc_cgrp), gfp);
- iocc->dfl_weight = CGROUP_WEIGHT_DFL;
+ if (!iocc)
+ return NULL;

+ iocc->dfl_weight = CGROUP_WEIGHT_DFL;
return &iocc->cpd;
}

2019-08-30 13:18:34

by Jens Axboe

Subject: Re: [PATCH block/for-next] blkcg: add missing NULL check in ioc_cpd_alloc()

On 8/30/19 7:10 AM, Tejun Heo wrote:
> ioc_cpd_alloc() forgot to check NULL return from kzalloc(). Add it.

Applied, thanks.

--
Jens Axboe