2019-08-31 07:31:01

by Colin King

Subject: [PATCH][next] net: hns3: remove redundant assignment to pointer reg_info

From: Colin Ian King <[email protected]>

Pointer reg_info is being initialized with a value that is never read and
is being re-assigned a little later on. The assignment is redundant
and hence can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.c
index 1debe37fe735..1c6b501fb7ca 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.c
@@ -279,7 +279,7 @@ static void hclge_dbg_dump_dcb(struct hclge_dev *hdev, const char *cmd_buf)

static void hclge_dbg_dump_reg_cmd(struct hclge_dev *hdev, const char *cmd_buf)
{
- struct hclge_dbg_reg_type_info *reg_info = &hclge_dbg_reg_info[0];
+ struct hclge_dbg_reg_type_info *reg_info;
bool has_dump = false;
int i;

--
2.20.1

2019-09-01 19:14:29

by David Miller

Subject: Re: [PATCH][next] net: hns3: remove redundant assignment to pointer reg_info

From: Colin King <[email protected]>
Date: Sat, 31 Aug 2019 08:29:49 +0100

> From: Colin Ian King <[email protected]>
>
> Pointer reg_info is being initialized with a value that is never read and
> is being re-assigned a little later on. The assignment is redundant
> and hence can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <[email protected]>

Applied.