2019-08-27 03:46:00

by Jisheng Zhang

[permalink] [raw]
Subject: [PATCH v2 0/2] hwmon: a new driver for Synaptics AS370 PVT sensor

Add a new driver for Synaptics AS370 PVT sensor. Currently only
temperature is supported.

Jisheng Zhang (2):
hwmon: Add Synaptics AS370 PVT sensor driver
hwmon: (as370-hwmon) Add DT bindings for Synaptics AS370 PVT

Changes since v1
- remove useless <linux/delay.h>
- use GENMASK
- remove useless bit operation
- remove read_pvt()
- use DIV_ROUND_CLOSEST()

.../devicetree/bindings/hwmon/as370.txt | 11 ++
drivers/hwmon/Kconfig | 10 ++
drivers/hwmon/Makefile | 1 +
drivers/hwmon/as370-hwmon.c | 147 ++++++++++++++++++
4 files changed, 169 insertions(+)
create mode 100644 Documentation/devicetree/bindings/hwmon/as370.txt
create mode 100644 drivers/hwmon/as370-hwmon.c

--
2.23.0.rc1


2019-08-27 03:48:03

by Jisheng Zhang

[permalink] [raw]
Subject: [PATCH v2 2/2] hwmon: (as370-hwmon) Add DT bindings for Synaptics AS370 PVT

Add device tree bindings for Synaptics AS370 PVT sensors.

Signed-off-by: Jisheng Zhang <[email protected]>
---
Documentation/devicetree/bindings/hwmon/as370.txt | 11 +++++++++++
1 file changed, 11 insertions(+)
create mode 100644 Documentation/devicetree/bindings/hwmon/as370.txt

diff --git a/Documentation/devicetree/bindings/hwmon/as370.txt b/Documentation/devicetree/bindings/hwmon/as370.txt
new file mode 100644
index 000000000000..d102fe765124
--- /dev/null
+++ b/Documentation/devicetree/bindings/hwmon/as370.txt
@@ -0,0 +1,11 @@
+Bindings for Synaptics AS370 PVT sensors
+
+Required properties:
+- compatible : "syna,as370-hwmon"
+- reg : address and length of the register set.
+
+Example:
+ hwmon@ea0810 {
+ compatible = "syna,as370-hwmon";
+ reg = <0xea0810 0xc>;
+ };
--
2.23.0.rc1

2019-08-31 15:10:00

by Guenter Roeck

[permalink] [raw]
Subject: Re: [PATCH v2 2/2] hwmon: (as370-hwmon) Add DT bindings for Synaptics AS370 PVT

On Tue, Aug 27, 2019 at 03:44:57AM +0000, Jisheng Zhang wrote:
> Add device tree bindings for Synaptics AS370 PVT sensors.
>
> Signed-off-by: Jisheng Zhang <[email protected]>

For my reference:

Reviewed-by: Guenter Roeck <[email protected]>

... but we'll have to wait for DT maintainer review.

> ---
> Documentation/devicetree/bindings/hwmon/as370.txt | 11 +++++++++++
> 1 file changed, 11 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwmon/as370.txt
>
> diff --git a/Documentation/devicetree/bindings/hwmon/as370.txt b/Documentation/devicetree/bindings/hwmon/as370.txt
> new file mode 100644
> index 000000000000..d102fe765124
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/as370.txt
> @@ -0,0 +1,11 @@
> +Bindings for Synaptics AS370 PVT sensors
> +
> +Required properties:
> +- compatible : "syna,as370-hwmon"
> +- reg : address and length of the register set.
> +
> +Example:
> + hwmon@ea0810 {
> + compatible = "syna,as370-hwmon";
> + reg = <0xea0810 0xc>;
> + };

2019-09-02 14:31:39

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH v2 2/2] hwmon: (as370-hwmon) Add DT bindings for Synaptics AS370 PVT

On Tue, 27 Aug 2019 03:44:57 +0000, Jisheng Zhang wrote:
> Add device tree bindings for Synaptics AS370 PVT sensors.
>
> Signed-off-by: Jisheng Zhang <[email protected]>
> ---
> Documentation/devicetree/bindings/hwmon/as370.txt | 11 +++++++++++
> 1 file changed, 11 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwmon/as370.txt
>

Reviewed-by: Rob Herring <[email protected]>

2019-09-02 16:07:54

by Guenter Roeck

[permalink] [raw]
Subject: Re: [PATCH v2 2/2] hwmon: (as370-hwmon) Add DT bindings for Synaptics AS370 PVT

On Tue, Aug 27, 2019 at 03:44:57AM +0000, Jisheng Zhang wrote:
> Add device tree bindings for Synaptics AS370 PVT sensors.
>
> Signed-off-by: Jisheng Zhang <[email protected]>
> Reviewed-by: Guenter Roeck <[email protected]>
> Reviewed-by: Rob Herring <[email protected]>

Applied to hwmon-next.

Thanks,
Guenter

> ---
> Documentation/devicetree/bindings/hwmon/as370.txt | 11 +++++++++++
> 1 file changed, 11 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwmon/as370.txt
>
> diff --git a/Documentation/devicetree/bindings/hwmon/as370.txt b/Documentation/devicetree/bindings/hwmon/as370.txt
> new file mode 100644
> index 000000000000..d102fe765124
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/as370.txt
> @@ -0,0 +1,11 @@
> +Bindings for Synaptics AS370 PVT sensors
> +
> +Required properties:
> +- compatible : "syna,as370-hwmon"
> +- reg : address and length of the register set.
> +
> +Example:
> + hwmon@ea0810 {
> + compatible = "syna,as370-hwmon";
> + reg = <0xea0810 0xc>;
> + };