2019-08-05 19:46:59

by Gustavo A. R. Silva

[permalink] [raw]

Subject: [PATCH] power: supply: ab8500_charger: Mark expected switch fall-through

---

Mark switch cases where we are expecting to fall through.

This patch fixes the following warning (Building: allmodconfig arm):

drivers/power/supply/ab8500_charger.c:738:6: warning: this statement may fall through [-Wimplicit-fallthrough=]

Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
drivers/power/supply/ab8500_charger.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/power/supply/ab8500_charger.c b/drivers/power/supply/ab8500_charger.c
index 30de448de802..1be75a2fed9b 100644
--- a/drivers/power/supply/ab8500_charger.c
+++ b/drivers/power/supply/ab8500_charger.c
@@ -742,6 +742,7 @@ static int ab8500_charger_max_usb_curr(struct ab8500_charger *di,
USB_CH_IP_CUR_LVL_1P5;
break;
}
+ /* else, fall through */
case USB_STAT_HM_IDGND:
dev_err(di->dev, "USB Type - Charging not allowed\n");
di->max_usb_in_curr.usb_type_max = USB_CH_IP_CUR_LVL_0P05;
--
2.22.0

2019-09-02 08:01:47

by Sebastian Reichel

[permalink] [raw]

Subject: Re: [PATCH] power: supply: ab8500_charger: Mark expected switch fall-through

---

Hi,

On Mon, Aug 05, 2019 at 02:44:18PM -0500, Gustavo A. R. Silva wrote:
> Mark switch cases where we are expecting to fall through.
>
> This patch fixes the following warning (Building: allmodconfig arm):
>
> drivers/power/supply/ab8500_charger.c:738:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
>
> Signed-off-by: Gustavo A. R. Silva <[email protected]>
> ---

Thanks, queued.

-- Sebastian

> drivers/power/supply/ab8500_charger.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/power/supply/ab8500_charger.c b/drivers/power/supply/ab8500_charger.c
> index 30de448de802..1be75a2fed9b 100644
> --- a/drivers/power/supply/ab8500_charger.c
> +++ b/drivers/power/supply/ab8500_charger.c
> @@ -742,6 +742,7 @@ static int ab8500_charger_max_usb_curr(struct ab8500_charger *di,
> USB_CH_IP_CUR_LVL_1P5;
> break;
> }
> + /* else, fall through */
> case USB_STAT_HM_IDGND:
> dev_err(di->dev, "USB Type - Charging not allowed\n");
> di->max_usb_in_curr.usb_type_max = USB_CH_IP_CUR_LVL_0P05;
> --
> 2.22.0
>

---

Attachments:

(No filename) (1.09 kB)
signature.asc (849.00 B)
Download all attachments