2019-09-01 23:32:40

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: Fixes tag needs some work in the battery tree

Hi all,

In commit

b19aca4eb2d2 ("power: supply: sbs-battery: only return health when battery present")

Fixes tag

Fixes: 76b16f4cdfb8 ("power: supply: sbs-battery: don't assume

has these problem(s):

- Subject has leading but no trailing parentheses
- Subject has leading but no trailing quotes

In commit

38fa8b9f75ea ("power: supply: sbs-battery: use correct flags field")

Fixes tag

Fixes: 76b16f4cdfb8 ("power: supply: sbs-battery: don't assume

has these problem(s):

- Subject has leading but no trailing parentheses
- Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.

--
Cheers,
Stephen Rothwell

Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2019-09-02 07:13:04

by Sebastian Reichel

[permalink] [raw]
Subject: Re: linux-next: Fixes tag needs some work in the battery tree

Hi Stephen,

On Mon, Sep 02, 2019 at 09:31:31AM +1000, Stephen Rothwell wrote:
> In commit
>
> b19aca4eb2d2 ("power: supply: sbs-battery: only return health when battery present")
>
> [...]
>
> Please do not split Fixes tags over more than one line.

I have fixed this and rebased the branch, so the issue should be
gone tomororw. Thanks for the notice,

-- Sebastian

Attachments:
(No filename) (386.00 B)
 signature.asc (849.00 B)
 Download all attachments

2019-09-02 07:45:03

by Michael Nosthoff

[permalink] [raw]
Subject: Re: linux-next: Fixes tag needs some work in the battery tree

Hi Sebastian,

I think you missed that the second commit

38fa8b9f75ea ("power: supply: sbs-battery: use correct flags field")

also needs this fix.


Regards,
Michael

On Monday, September 02, 2019 09:10 CEST, Sebastian Reichel <[email protected]> wrote:

> Hi Stephen,
>
> On Mon, Sep 02, 2019 at 09:31:31AM +1000, Stephen Rothwell wrote:
> > In commit
> >
> > b19aca4eb2d2 ("power: supply: sbs-battery: only return health when battery present")
> >
> > [...]
> >
> > Please do not split Fixes tags over more than one line.
>
> I have fixed this and rebased the branch, so the issue should be
> gone tomororw. Thanks for the notice,
>
> -- Sebastian

2019-09-02 08:38:31

by Sebastian Reichel

[permalink] [raw]
Subject: Re: linux-next: Fixes tag needs some work in the battery tree

Hi,

On Mon, Sep 02, 2019 at 09:32:47AM +0200, Michael Nosthoff wrote:
> On Monday, September 02, 2019 09:10 CEST, Sebastian Reichel <[email protected]> wrote:
> > On Mon, Sep 02, 2019 at 09:31:31AM +1000, Stephen Rothwell wrote:
> > > In commit
> > >
> > > b19aca4eb2d2 ("power: supply: sbs-battery: only return health when battery present")
> > >
> > > [...]
> > >
> > > Please do not split Fixes tags over more than one line.
> >
> > I have fixed this and rebased the branch, so the issue should be
> > gone tomororw. Thanks for the notice,
>
> I think you missed that the second commit
>
> 38fa8b9f75ea ("power: supply: sbs-battery: use correct flags field")
>
> also needs this fix.

Right, now also fixed.

-- Sebastian

Attachments:
(No filename) (750.00 B)
 signature.asc (849.00 B)
 Download all attachments