2019-09-02 15:32:50

by Yue Haibing

Subject: [PATCH -next] virtio-fs: Add missing include file

fs/fuse/virtio_fs.c: In function virtio_fs_requests_done_work:
fs/fuse/virtio_fs.c:348:6: error: implicit declaration of function zero_user_segment;
did you mean get_user_pages? [-Werror=implicit-function-declaration]
zero_user_segment(page, len, thislen);
^~~~~~~~~~~~~~~~~
get_user_pages

Add missing include file <linux/highmem.h>

Reported-by: Hulk Robot <[email protected]>
Fixes: 08f3aab37d99 ("virtio-fs: add virtiofs filesystem")
Signed-off-by: YueHaibing <[email protected]>
---
fs/fuse/virtio_fs.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/fs/fuse/virtio_fs.c b/fs/fuse/virtio_fs.c
index b92dfb1..e731c4f 100644
--- a/fs/fuse/virtio_fs.c
+++ b/fs/fuse/virtio_fs.c
@@ -10,6 +10,7 @@
#include <linux/virtio_fs.h>
#include <linux/delay.h>
#include <linux/fs_context.h>
+#include <linux/highmem.h>
#include "fuse_i.h"

/* List of virtio-fs device instances and a lock for the list */
--
2.7.4

2019-09-02 18:06:58

by Miklos Szeredi

Subject: Re: [PATCH -next] virtio-fs: Add missing include file

On Mon, Sep 2, 2019 at 4:43 PM YueHaibing <[email protected]> wrote:
>
> fs/fuse/virtio_fs.c: In function virtio_fs_requests_done_work:
> fs/fuse/virtio_fs.c:348:6: error: implicit declaration of function zero_user_segment;
> did you mean get_user_pages? [-Werror=implicit-function-declaration]
> zero_user_segment(page, len, thislen);
> ^~~~~~~~~~~~~~~~~
> get_user_pages
>
> Add missing include file <linux/highmem.h>

Thanks, folded.

Miklos