2019-07-30 11:46:57

by Richard Tresidder

[permalink] [raw]

Subject: [RESEND v2 1/2] dt-binding docs: sbs_sbs-battery: Addition of force_load binding

---

Add device tree binding documentation for addition of force_load boolean value
to allow loading a battery during boot even if notpresent at that time.

Signed-off-by: Richard Tresidder <[email protected]>
---
Documentation/devicetree/bindings/power/supply/sbs_sbs-battery.txt | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/power/supply/sbs_sbs-battery.txt b/Documentation/devicetree/bindings/power/supply/sbs_sbs-battery.txt
index 4e78e51..187d7bb 100644
--- a/Documentation/devicetree/bindings/power/supply/sbs_sbs-battery.txt
+++ b/Documentation/devicetree/bindings/power/supply/sbs_sbs-battery.txt
@@ -15,7 +15,8 @@ Optional properties :
after an external change notification.
- sbs,battery-detect-gpios : The gpio which signals battery detection and
a flag specifying its polarity.
-
+ - sbs,force-load : Allow loading of a hot-pluggable battery when there is no
+ GPIO detect available and the module is statically built.
Example:

battery@b {
@@ -24,4 +25,5 @@ Example:
sbs,i2c-retry-count = <2>;
sbs,poll-retry-count = <10>;
sbs,battery-detect-gpios = <&gpio-controller 122 1>;
+ sbs,force-load;
}
--
1.8.3.1

2019-09-02 18:25:05

by Sebastian Reichel

[permalink] [raw]

Subject: Re: [RESEND v2 1/2] dt-binding docs: sbs_sbs-battery: Addition of force_load binding

---

Hi,

On Tue, Jul 30, 2019 at 06:10:03PM +0800, Richard Tresidder wrote:
> Add device tree binding documentation for addition of force_load boolean value
> to allow loading a battery during boot even if notpresent at that time.
>
> Signed-off-by: Richard Tresidder <[email protected]>
> ---
> Documentation/devicetree/bindings/power/supply/sbs_sbs-battery.txt | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/power/supply/sbs_sbs-battery.txt b/Documentation/devicetree/bindings/power/supply/sbs_sbs-battery.txt
> index 4e78e51..187d7bb 100644
> --- a/Documentation/devicetree/bindings/power/supply/sbs_sbs-battery.txt
> +++ b/Documentation/devicetree/bindings/power/supply/sbs_sbs-battery.txt
> @@ -15,7 +15,8 @@ Optional properties :
> after an external change notification.
> - sbs,battery-detect-gpios : The gpio which signals battery detection and
> a flag specifying its polarity.
> -
> + - sbs,force-load : Allow loading of a hot-pluggable battery when there is no
> + GPIO detect available and the module is statically built.

This does not describe hardware configuration and is not an
acceptable DT property.

-- Sebastian

> Example:
>
> battery@b {
> @@ -24,4 +25,5 @@ Example:
> sbs,i2c-retry-count = <2>;
> sbs,poll-retry-count = <10>;
> sbs,battery-detect-gpios = <&gpio-controller 122 1>;
> + sbs,force-load;
> }
> --
> 1.8.3.1
>

---

Attachments:

(No filename) (1.45 kB)
signature.asc (849.00 B)
Download all attachments