2019-07-13 15:45:29

by Matwey V. Kornilov

[permalink] [raw]

Subject: [PATCH] power: reset: reboot-mode: Fix author email format

---

Closing angle bracket was missing.

Signed-off-by: Matwey V. Kornilov <[email protected]>
---
drivers/power/reset/reboot-mode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/power/reset/reboot-mode.c b/drivers/power/reset/reboot-mode.c
index 06ff035b57f5..b4076b10b893 100644
--- a/drivers/power/reset/reboot-mode.c
+++ b/drivers/power/reset/reboot-mode.c
@@ -190,6 +190,6 @@ void devm_reboot_mode_unregister(struct device *dev,
}
EXPORT_SYMBOL_GPL(devm_reboot_mode_unregister);

-MODULE_AUTHOR("Andy Yan <[email protected]");
+MODULE_AUTHOR("Andy Yan <[email protected]>");
MODULE_DESCRIPTION("System reboot mode core library");
MODULE_LICENSE("GPL v2");
--
2.16.4

2019-09-02 19:07:39

by Sebastian Reichel

[permalink] [raw]

Subject: Re: [PATCH] power: reset: reboot-mode: Fix author email format

---

Hi,

On Sat, Jul 13, 2019 at 06:42:48PM +0300, Matwey V. Kornilov wrote:
> Closing angle bracket was missing.
>
> Signed-off-by: Matwey V. Kornilov <[email protected]>
> ---

Thanks, queued.

-- Sebastian

> drivers/power/reset/reboot-mode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/reset/reboot-mode.c b/drivers/power/reset/reboot-mode.c
> index 06ff035b57f5..b4076b10b893 100644
> --- a/drivers/power/reset/reboot-mode.c
> +++ b/drivers/power/reset/reboot-mode.c
> @@ -190,6 +190,6 @@ void devm_reboot_mode_unregister(struct device *dev,
> }
> EXPORT_SYMBOL_GPL(devm_reboot_mode_unregister);
>
> -MODULE_AUTHOR("Andy Yan <[email protected]");
> +MODULE_AUTHOR("Andy Yan <[email protected]>");
> MODULE_DESCRIPTION("System reboot mode core library");
> MODULE_LICENSE("GPL v2");
> --
> 2.16.4
>

---

Attachments:

(No filename) (895.00 B)
signature.asc (849.00 B)
Download all attachments

2019-09-02 19:25:24

by Joe Perches

[permalink] [raw]

Subject: Re: [PATCH] power: reset: reboot-mode: Fix author email format

---

On Mon, 2019-09-02 at 21:06 +0200, Sebastian Reichel wrote:
> Hi,
>
> On Sat, Jul 13, 2019 at 06:42:48PM +0300, Matwey V. Kornilov wrote:
> > Closing angle bracket was missing.
> >
> > Signed-off-by: Matwey V. Kornilov <[email protected]>
> > ---
>
> Thanks, queued.

This is relatively widespread.

There are 80 more of these in the kernel tree.

$ git grep -P 'MODULE_AUTHOR.*<[^>]+$' | wc -l
81

Here's a trivial little script to fix them all:

$ git grep -P -n 'MODULE_AUTHOR.*<[^>]+$' | \
while read entry ; do \
file=$(echo $entry|cut -f1 -d:); \
line=$(echo $entry|cut -f2 -d:); \
sed -i "${line}s/\");/>\");/" $file; \
done