2019-09-03 06:44:01

by zhong jiang

Subject: [PATCH] fs: omfs: Use kmemdup rather than duplicating its implementation in omfs_get_imap

kmemdup contains the kmalloc + memcpy. hence it is better to use kmemdup
directly. Just replace it.

Signed-off-by: zhong jiang <[email protected]>
---
fs/omfs/inode.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/omfs/inode.c b/fs/omfs/inode.c
index b76ec6b..8867cef 100644
--- a/fs/omfs/inode.c
+++ b/fs/omfs/inode.c
@@ -363,12 +363,11 @@ static int omfs_get_imap(struct super_block *sb)
bh = sb_bread(sb, block++);
if (!bh)
goto nomem_free;
- *ptr = kmalloc(sb->s_blocksize, GFP_KERNEL);
+ *ptr = kmemdup(bh->b_data, sb->s_blocksize, GFP_KERNEL);
if (!*ptr) {
brelse(bh);
goto nomem_free;
}
- memcpy(*ptr, bh->b_data, sb->s_blocksize);
if (count < sb->s_blocksize)
memset((void *)*ptr + count, 0xff,
sb->s_blocksize - count);
--
1.7.12.4

2019-09-03 13:28:40

by Bob Copeland

Subject: Re: [PATCH] fs: omfs: Use kmemdup rather than duplicating its implementation in omfs_get_imap

On Tue, Sep 03, 2019 at 02:39:44PM +0800, zhong jiang wrote:
> kmemdup contains the kmalloc + memcpy. hence it is better to use kmemdup
> directly. Just replace it.
>
> Signed-off-by: zhong jiang <[email protected]>

This same patch was already sent to me by someone else and I acked it:

https://lore.kernel.org/lkml/[email protected]/

--
Bob Copeland %% https://bobcopeland.com/

2019-09-03 14:00:28

by zhong jiang

Subject: Re: [PATCH] fs: omfs: Use kmemdup rather than duplicating its implementation in omfs_get_imap

On 2019/9/3 21:25, Bob Copeland wrote:
> On Tue, Sep 03, 2019 at 02:39:44PM +0800, zhong jiang wrote:
>> kmemdup contains the kmalloc + memcpy. hence it is better to use kmemdup
>> directly. Just replace it.
>>
>> Signed-off-by: zhong jiang <[email protected]>
> This same patch was already sent to me by someone else and I acked it:
>
> https://lore.kernel.org/lkml/[email protected]/
>
I miss the patch. Thanks,

Sincerely,
zhong jiang