2019-09-05 22:24:07

by Krzysztof Wilczyński

Subject: [PATCH] drm/amd/display: Move static keyword to the front of declaration

Move the static keyword to the front of declaration of DC_BUILD_ID,
and resolve the following compiler warning that can be seen when
building with warnings enabled (W=1):

drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:75:1: warning:
‘static’ is not at beginning of declaration [-Wold-style-declaration]

Signed-off-by: Krzysztof Wilczynski <[email protected]>
---
Related: https://lore.kernel.org/r/[email protected]

drivers/gpu/drm/amd/display/dc/core/dc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
index 87ca5a290d12..a5a89bc0e1d1 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
@@ -72,7 +72,7 @@
#define DC_LOGGER \
dc->ctx->logger

-const static char DC_BUILD_ID[] = "production-build";
+static const char DC_BUILD_ID[] = "production-build";

/**
* DOC: Overview
--
2.22.1

2019-09-06 02:50:56

by Harry Wentland

Subject: Re: [PATCH] drm/amd/display: Move static keyword to the front of declaration

On 2019-09-05 2:33 p.m., Krzysztof Wilczynski wrote:
> Move the static keyword to the front of declaration of DC_BUILD_ID,
> and resolve the following compiler warning that can be seen when
> building with warnings enabled (W=1):
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:75:1: warning:
> ‘static’ is not at beginning of declaration [-Wold-style-declaration]
>
> Signed-off-by: Krzysztof Wilczynski <[email protected]>

Reviewed-by: Harry Wentland <[email protected]>

Harry

> ---
> Related: https://lore.kernel.org/r/[email protected]
>
> drivers/gpu/drm/amd/display/dc/core/dc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
> index 87ca5a290d12..a5a89bc0e1d1 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
> @@ -72,7 +72,7 @@
> #define DC_LOGGER \
> dc->ctx->logger
>
> -const static char DC_BUILD_ID[] = "production-build";
> +static const char DC_BUILD_ID[] = "production-build";
>
> /**
> * DOC: Overview
>