These patches support upcoming UV systems that do not have a UV HUB.
* Save OEM_ID from ACPI MADT probe
* Return UV Hubless System Type
* Add return code to UV BIOS Init function
* Setup UV functions for Hubless UV Systems
* Add UV Hubbed/Hubless Proc FS Files
* Decode UVsystab Info
* Account for UV Hubless in is_uvX_hub Ops
--
Mike,
On Thu, 5 Sep 2019, Mike Travis wrote:
> These patches support upcoming UV systems that do not have a UV HUB.
>
> * Save OEM_ID from ACPI MADT probe
> * Return UV Hubless System Type
> * Add return code to UV BIOS Init function
> * Setup UV functions for Hubless UV Systems
> * Add UV Hubbed/Hubless Proc FS Files
> * Decode UVsystab Info
> * Account for UV Hubless in is_uvX_hub Ops
Can you please in future mark the next version of a patch or patch series
with [PATCH V2 n/M] so its clear that this is something different and also
add a quick summary what changed vs. V1? Adding to each patch which changed
a short change info _after_ the '---' discard line is also good practice
and helps reviewers to figure out which part needs to be looked at.
Thanks
tglx
On Thu, 5 Sep 2019, Mike Travis wrote:
> On 9/5/2019 12:02 PM, Thomas Gleixner wrote:
> > Mike,
> >
> > On Thu, 5 Sep 2019, Mike Travis wrote:
> >
> > > These patches support upcoming UV systems that do not have a UV HUB.
> > >
> > > * Save OEM_ID from ACPI MADT probe
> > > * Return UV Hubless System Type
> > > * Add return code to UV BIOS Init function
> > > * Setup UV functions for Hubless UV Systems
> > > * Add UV Hubbed/Hubless Proc FS Files
> > > * Decode UVsystab Info
> > > * Account for UV Hubless in is_uvX_hub Ops
> >
> > Can you please in future mark the next version of a patch or patch series
> > with [PATCH V2 n/M] so its clear that this is something different and also
> > add a quick summary what changed vs. V1? Adding to each patch which changed
> > a short change info _after_ the '---' discard line is also good practice
> > and helps reviewers to figure out which part needs to be looked at.
> >
> > Thanks
> >
> > tglx
> >
>
> Yeah, I noticed that the V2: tag for the removal that Greg requested was
> missing in the copy sent to me. Sorry I didn't catch that earlier.
>
> The "[PATCH V2 n/M]" is something I hadn't been aware but I am now.
>
> Should I resend the patches again with those updates?
No, please provide a summary of changes as a reply to the cover letter and
point out which patches were actually changed vs. v1.
Thanks,
tglx
On 9/5/2019 12:02 PM, Thomas Gleixner wrote:
> Mike,
>
> On Thu, 5 Sep 2019, Mike Travis wrote:
>
>> These patches support upcoming UV systems that do not have a UV HUB.
>>
>> * Save OEM_ID from ACPI MADT probe
>> * Return UV Hubless System Type
>> * Add return code to UV BIOS Init function
>> * Setup UV functions for Hubless UV Systems
>> * Add UV Hubbed/Hubless Proc FS Files
>> * Decode UVsystab Info
>> * Account for UV Hubless in is_uvX_hub Ops
>
> Can you please in future mark the next version of a patch or patch series
> with [PATCH V2 n/M] so its clear that this is something different and also
> add a quick summary what changed vs. V1? Adding to each patch which changed
> a short change info _after_ the '---' discard line is also good practice
> and helps reviewers to figure out which part needs to be looked at.
>
> Thanks
>
> tglx
>
Yeah, I noticed that the V2: tag for the removal that Greg requested was
missing in the copy sent to me. Sorry I didn't catch that earlier.
The "[PATCH V2 n/M]" is something I hadn't been aware but I am now.
Should I resend the patches again with those updates?
Thanks.
On 9/5/2019 11:47 AM, Mike Travis wrote:
>
> These patches support upcoming UV systems that do not have a UV HUB.
>
> [1/8] Save OEM_ID from ACPI MADT probe
>
> [2/8] Return UV Hubless System Type
V2: Remove is_uv_hubless define
Remove leading '_' from _is_uv_hubless
> [3/8] Add return code to UV BIOS Init function
>
> [4/8] Setup UV functions for Hubless UV Systems
>
> [5/8] Add UV Hubbed/Hubless Proc FS Files
V2: Remove is_uv_hubbed define
Remove leading '_' from _is_uv_hubbed
> [6/8] Decode UVsystab Info
V2: Removed redundant error message after call to uv_bios_init.
Removed redundant error message after call to decode_uv_systab.
Clarify selection of UV4 and higher when checking for extended UVsystab
in decode_uv_systab().
> [7/8] Check EFI Boot to set reboot type
>
> [8/8] Account for UV Hubless in is_uvX_hub Ops
V2: Add WARNING that the is UVx supported defines will be removed.
--
On 9/5/2019 11:47 AM, Mike Travis wrote:
>
> These patches support upcoming UV systems that do not have a UV HUB.
>
> [1/8] Save OEM_ID from ACPI MADT probe
>
> [2/8] Return UV Hubless System Type
V2: Remove is_uv_hubless define
Remove leading '_' from _is_uv_hubless
> [3/8] Add return code to UV BIOS Init function
>
> [4/8] Setup UV functions for Hubless UV Systems
>
> [5/8] Add UV Hubbed/Hubless Proc FS Files
V2: Remove is_uv_hubbed define
Remove leading '_' from _is_uv_hubbed
> [6/8] Decode UVsystab Info
V2: Removed redundant error message after call to uv_bios_init.
Removed redundant error message after call to decode_uv_systab.
Clarify selection of UV4 and higher when checking for extended UVsystab
in decode_uv_systab().
> [7/8] Check EFI Boot to set reboot type
>
> [8/8] Account for UV Hubless in is_uvX_hub Ops
V2: Add WARNING that the is UVx supported defines will be removed.
--
On 9/5/2019 11:47 AM, Mike Travis wrote:
>
> These patches support upcoming UV systems that do not have a UV HUB.
>
> [1/8] Save OEM_ID from ACPI MADT probe
>
> [2/8] Return UV Hubless System Type
V2: Remove is_uv_hubless define
Remove leading '_' from _is_uv_hubless
> [3/8] Add return code to UV BIOS Init function
>
> [4/8] Setup UV functions for Hubless UV Systems
>
> [5/8] Add UV Hubbed/Hubless Proc FS Files
V2: Remove is_uv_hubbed define
Remove leading '_' from _is_uv_hubbed
> [6/8] Decode UVsystab Info
V2: Removed redundant error message after call to uv_bios_init.
Removed redundant error message after call to decode_uv_systab.
Clarify selection of UV4 and higher when checking for extended UVsystab
in decode_uv_systab().
> [7/8] Check EFI Boot to set reboot type
>
> [8/8] Account for UV Hubless in is_uvX_hub Ops
V2: Add WARNING that the is UVx supported defines will be removed.
--
On 9/5/2019 11:47 AM, Mike Travis wrote:
>
> These patches support upcoming UV systems that do not have a UV HUB.
>
> [1/8] Save OEM_ID from ACPI MADT probe
>
> [2/8] Return UV Hubless System Type
V2: Remove is_uv_hubless define
Remove leading '_' from _is_uv_hubless
> [3/8] Add return code to UV BIOS Init function
>
> [4/8] Setup UV functions for Hubless UV Systems
>
> [5/8] Add UV Hubbed/Hubless Proc FS Files
V2: Remove is_uv_hubbed define
Remove leading '_' from _is_uv_hubbed
> [6/8] Decode UVsystab Info
V2: Removed redundant error message after call to uv_bios_init.
Removed redundant error message after call to decode_uv_systab.
Clarify selection of UV4 and higher when checking for extended UVsystab
in decode_uv_systab().
> [7/8] Check EFI Boot to set reboot type
>
> [8/8] Account for UV Hubless in is_uvX_hub Ops
V2: Add WARNING that the is UVx supported defines will be removed.
--
On 9/5/2019 11:47 AM, Mike Travis wrote:
>
> These patches support upcoming UV systems that do not have a UV HUB.
>
> [1/8] Save OEM_ID from ACPI MADT probe
>
> [2/8] Return UV Hubless System Type
V2: Remove is_uv_hubless define
Remove leading '_' from _is_uv_hubless
> [3/8] Add return code to UV BIOS Init function
>
> [4/8] Setup UV functions for Hubless UV Systems
>
> [5/8] Add UV Hubbed/Hubless Proc FS Files
V2: Remove is_uv_hubbed define
Remove leading '_' from _is_uv_hubbed
> [6/8] Decode UVsystab Info
V2: Removed redundant error message after call to uv_bios_init.
Removed redundant error message after call to decode_uv_systab.
Clarify selection of UV4 and higher when checking for extended UVsystab
in decode_uv_systab().
> [7/8] Check EFI Boot to set reboot type
>
> [8/8] Account for UV Hubless in is_uvX_hub Ops
V2: Add WARNING that the is UVx supported defines will be removed.
--