2019-09-11 23:41:08

by Will Deacon

Subject: [PATCH] module: Remove leftover '#undef' from export header

Commit 7290d5809571 ("module: use relative references for __ksymtab
entries") converted the '__put' #define into an assembly macro in
asm-generic/export.h but forgot to remove the corresponding '#undef'.

Remove the leftover '#undef'.

Cc: Ard Biesheuvel <[email protected]>
Cc: Jessica Yu <[email protected]>
Signed-off-by: Will Deacon <[email protected]>
---

I spotted this trivial issue when debugging the namespace issue earlier
today, so here's the patch.

include/asm-generic/export.h | 1 -
1 file changed, 1 deletion(-)

diff --git a/include/asm-generic/export.h b/include/asm-generic/export.h
index 294d6ae785d4..153d9c2ee580 100644
--- a/include/asm-generic/export.h
+++ b/include/asm-generic/export.h
@@ -57,7 +57,6 @@ __kcrctab_\name:
#endif
#endif
.endm
-#undef __put

#if defined(CONFIG_TRIM_UNUSED_KSYMS)

--
2.23.0.237.gc6a4ce50a0-goog

2019-09-12 13:34:35

by Jessica Yu

Subject: Re: [PATCH] module: Remove leftover '#undef' from export header

+++ Will Deacon [12/09/19 00:00 +0100]:
>Commit 7290d5809571 ("module: use relative references for __ksymtab
>entries") converted the '__put' #define into an assembly macro in
>asm-generic/export.h but forgot to remove the corresponding '#undef'.
>
>Remove the leftover '#undef'.
>
>Cc: Ard Biesheuvel <[email protected]>
>Cc: Jessica Yu <[email protected]>
>Signed-off-by: Will Deacon <[email protected]>
>---
>
>I spotted this trivial issue when debugging the namespace issue earlier
>today, so here's the patch.

Applied, thanks for the cleanup!

Jessica