2019-09-12 10:40:25

by Kieran Bingham

[permalink] [raw]
Subject: [PATCH] arm: dts: renesas: r8a77980: Remove r8a77970 DU compatible

The r8a77970 was added with an compatible string for a differnet device
rather than adding the correct compatible to the driver.

Remove the unnecessary compatible which is for a different platform.

Signed-off-by: Kieran Bingham <[email protected]>
---
Please note, this patch should not be integrated until the renesas,du-r8a77980
compatible string makes it into the DU [0].

[0] https://lore.kernel.org/linux-renesas-soc/[email protected]/T/#t

arch/arm64/boot/dts/renesas/r8a77980.dtsi | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/renesas/r8a77980.dtsi b/arch/arm64/boot/dts/renesas/r8a77980.dtsi
index 042f4089e546..c6195377d181 100644
--- a/arch/arm64/boot/dts/renesas/r8a77980.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77980.dtsi
@@ -1487,8 +1487,7 @@
};

du: display@feb00000 {
- compatible = "renesas,du-r8a77980",
- "renesas,du-r8a77970";
+ compatible = "renesas,du-r8a77980";
reg = <0 0xfeb00000 0 0x80000>;
interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&cpg CPG_MOD 724>;
--
2.20.1


2019-09-12 11:58:53

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [PATCH] arm: dts: renesas: r8a77980: Remove r8a77970 DU compatible

On Thu, Sep 12, 2019 at 12:38 PM Kieran Bingham
<[email protected]> wrote:
> The r8a77970 was added with an compatible string for a differnet device

different

> rather than adding the correct compatible to the driver.
>
> Remove the unnecessary compatible which is for a different platform.
>
> Signed-off-by: Kieran Bingham <[email protected]>

Reviewed-by: Geert Uytterhoeven <[email protected]>

> Please note, this patch should not be integrated until the renesas,du-r8a77980
> compatible string makes it into the DU [0].

Hence postponed.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2019-09-12 12:06:46

by Kieran Bingham

[permalink] [raw]
Subject: Re: [PATCH] arm: dts: renesas: r8a77980: Remove r8a77970 DU compatible

Hi Geert,

On 12/09/2019 12:56, Geert Uytterhoeven wrote:
> On Thu, Sep 12, 2019 at 12:38 PM Kieran Bingham
> <[email protected]> wrote:
>> The r8a77970 was added with an compatible string for a differnet device
>
> different

Also s/an/a/ ... Perhaps I should just step away from the keyboard
today, I can't seem to type ! hehe


>> rather than adding the correct compatible to the driver.
>>
>> Remove the unnecessary compatible which is for a different platform.
>>
>> Signed-off-by: Kieran Bingham <[email protected]>
>
> Reviewed-by: Geert Uytterhoeven <[email protected]>
>
>> Please note, this patch should not be integrated until the renesas,du-r8a77980
>> compatible string makes it into the DU [0].
>
> Hence postponed.


Thanks.
--
KB


> Gr{oetje,eeting}s,
>
> Geert
>

2019-09-12 12:08:05

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [PATCH] arm: dts: renesas: r8a77980: Remove r8a77970 DU compatible

Hi Kieran,

On Thu, Sep 12, 2019 at 2:03 PM Kieran Bingham
<[email protected]> wrote:
> On 12/09/2019 12:56, Geert Uytterhoeven wrote:
> > On Thu, Sep 12, 2019 at 12:38 PM Kieran Bingham
> > <[email protected]> wrote:
> >> The r8a77970 was added with an compatible string for a differnet device
> >
> > different
>
> Also s/an/a/ ... Perhaps I should just step away from the keyboard
> today, I can't seem to type ! hehe

Doh, finding a first typo increased my adrenaline level, masking the ability
to see a second ;-)

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2019-09-13 08:26:14

by Simon Horman

[permalink] [raw]
Subject: Re: [PATCH] arm: dts: renesas: r8a77980: Remove r8a77970 DU compatible

On Thu, Sep 12, 2019 at 11:37:34AM +0100, Kieran Bingham wrote:
> The r8a77970 was added with an compatible string for a differnet device
> rather than adding the correct compatible to the driver.
>
> Remove the unnecessary compatible which is for a different platform.
>
> Signed-off-by: Kieran Bingham <[email protected]>

Reviewed-by: Simon Horman <[email protected]>

> ---
> Please note, this patch should not be integrated until the renesas,du-r8a77980
> compatible string makes it into the DU [0].
>
> [0] https://lore.kernel.org/linux-renesas-soc/[email protected]/T/#t
>
> arch/arm64/boot/dts/renesas/r8a77980.dtsi | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a77980.dtsi b/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> index 042f4089e546..c6195377d181 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> @@ -1487,8 +1487,7 @@
> };
>
> du: display@feb00000 {
> - compatible = "renesas,du-r8a77980",
> - "renesas,du-r8a77970";
> + compatible = "renesas,du-r8a77980";
> reg = <0 0xfeb00000 0 0x80000>;
> interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&cpg CPG_MOD 724>;
> --
> 2.20.1
>