2019-09-12 10:34:30

by Kieran Bingham

Subject: [PATCH] arm64: dts: renesas: r8a77970: Fix PWM3

The pwm3 was incorrectly added with a compatible reference to the
renesas,pwm-r8a7790 (H2) due to a single characther ommision.

Fix the compatible string.

Fixes: de625477c632 ("arm64: dts: renesas: r8a779{7|8}0: add PWM support")
Signed-off-by: Kieran Bingham <[email protected]>
---
arch/arm64/boot/dts/renesas/r8a77970.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/renesas/r8a77970.dtsi b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
index 2c4ab70e2a39..74c2c0024e45 100644
--- a/arch/arm64/boot/dts/renesas/r8a77970.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
@@ -652,7 +652,7 @@
};

pwm3: pwm@e6e33000 {
- compatible = "renesas,pwm-r8a7790", "renesas,pwm-rcar";
+ compatible = "renesas,pwm-r8a77970", "renesas,pwm-rcar";
reg = <0 0xe6e33000 0 8>;
#pwm-cells = <2>;
clocks = <&cpg CPG_MOD 523>;
--
2.20.1

2019-09-12 10:49:26

by Kieran Bingham

Subject: Re: [PATCH] arm64: dts: renesas: r8a77970: Fix PWM3

On 12/09/2019 11:31, Kieran Bingham wrote:
> The pwm3 was incorrectly added with a compatible reference to the
> renesas,pwm-r8a7790 (H2) due to a single characther ommision.

Ugh, my apologies :

s/characther/character/
s/ommision/omission/

Please fix up when applying if there's no need to send a v2.

--
Kieran


>
> Fix the compatible string.
>
> Fixes: de625477c632 ("arm64: dts: renesas: r8a779{7|8}0: add PWM support")
> Signed-off-by: Kieran Bingham <[email protected]>
> ---
> arch/arm64/boot/dts/renesas/r8a77970.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a77970.dtsi b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> index 2c4ab70e2a39..74c2c0024e45 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> @@ -652,7 +652,7 @@
> };
>
> pwm3: pwm@e6e33000 {
> - compatible = "renesas,pwm-r8a7790", "renesas,pwm-rcar";
> + compatible = "renesas,pwm-r8a77970", "renesas,pwm-rcar";
> reg = <0 0xe6e33000 0 8>;
> #pwm-cells = <2>;
> clocks = <&cpg CPG_MOD 523>;
>

2019-09-12 20:27:33

by Geert Uytterhoeven

Subject: Re: [PATCH] arm64: dts: renesas: r8a77970: Fix PWM3

On Thu, Sep 12, 2019 at 12:47 PM Kieran Bingham
<[email protected]> wrote:
> On 12/09/2019 11:31, Kieran Bingham wrote:
> > The pwm3 was incorrectly added with a compatible reference to the
> > renesas,pwm-r8a7790 (H2) due to a single characther ommision.
>
> Ugh, my apologies :
>
> s/characther/character/
> s/ommision/omission/
>
> Please fix up when applying if there's no need to send a v2.
>
> --
> Kieran
>
>
> >
> > Fix the compatible string.
> >
> > Fixes: de625477c632 ("arm64: dts: renesas: r8a779{7|8}0: add PWM support")
> > Signed-off-by: Kieran Bingham <[email protected]>

Reviewed-by: Geert Uytterhoeven <[email protected]>
i.e. will queue in renesas-devel for v5.5, with the above fixed.

BTW, looks like PWM on R-Car Gen2 needs more love...

> > --- a/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> > @@ -652,7 +652,7 @@
> > };
> >
> > pwm3: pwm@e6e33000 {
> > - compatible = "renesas,pwm-r8a7790", "renesas,pwm-rcar";
> > + compatible = "renesas,pwm-r8a77970", "renesas,pwm-rcar";
> > reg = <0 0xe6e33000 0 8>;
> > #pwm-cells = <2>;
> > clocks = <&cpg CPG_MOD 523>;
> >

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2019-09-13 08:26:08

by Simon Horman

Subject: Re: [PATCH] arm64: dts: renesas: r8a77970: Fix PWM3

On Thu, Sep 12, 2019 at 11:31:43AM +0100, Kieran Bingham wrote:
> The pwm3 was incorrectly added with a compatible reference to the
> renesas,pwm-r8a7790 (H2) due to a single characther ommision.
>
> Fix the compatible string.
>
> Fixes: de625477c632 ("arm64: dts: renesas: r8a779{7|8}0: add PWM support")
> Signed-off-by: Kieran Bingham <[email protected]>

Reviewed-by: Simon Horman <[email protected]>

> ---
> arch/arm64/boot/dts/renesas/r8a77970.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a77970.dtsi b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> index 2c4ab70e2a39..74c2c0024e45 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> @@ -652,7 +652,7 @@
> };
>
> pwm3: pwm@e6e33000 {
> - compatible = "renesas,pwm-r8a7790", "renesas,pwm-rcar";
> + compatible = "renesas,pwm-r8a77970", "renesas,pwm-rcar";
> reg = <0 0xe6e33000 0 8>;
> #pwm-cells = <2>;
> clocks = <&cpg CPG_MOD 523>;
> --
> 2.20.1
>