2019-09-17 06:26:07

by Denis Efremov (Oracle)

Subject: [PATCH v3 23/26] memstick: use PCI_STD_NUM_BARS

Use define PCI_STD_NUM_BARS instead of PCI_ROM_RESOURCE for the number of
PCI BARs.

Cc: Maxim Levitsky <[email protected]>
Cc: Alex Dubov <[email protected]>
Cc: Ulf Hansson <[email protected]>
Signed-off-by: Denis Efremov <[email protected]>
---
drivers/memstick/host/jmb38x_ms.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/memstick/host/jmb38x_ms.c b/drivers/memstick/host/jmb38x_ms.c
index 32747425297d..fd281c1d39b1 100644
--- a/drivers/memstick/host/jmb38x_ms.c
+++ b/drivers/memstick/host/jmb38x_ms.c
@@ -848,7 +848,7 @@ static int jmb38x_ms_count_slots(struct pci_dev *pdev)
{
int cnt, rc = 0;

- for (cnt = 0; cnt < PCI_ROM_RESOURCE; ++cnt) {
+ for (cnt = 0; cnt < PCI_STD_NUM_BARS; ++cnt) {
if (!(IORESOURCE_MEM & pci_resource_flags(pdev, cnt)))
break;

--
2.21.0

2019-09-20 17:42:48

by Ulf Hansson

Subject: Re: [PATCH v3 23/26] memstick: use PCI_STD_NUM_BARS

On Mon, 16 Sep 2019 at 22:47, Denis Efremov <[email protected]> wrote:
>
> Use define PCI_STD_NUM_BARS instead of PCI_ROM_RESOURCE for the number of
> PCI BARs.
>
> Cc: Maxim Levitsky <[email protected]>
> Cc: Alex Dubov <[email protected]>
> Cc: Ulf Hansson <[email protected]>
> Signed-off-by: Denis Efremov <[email protected]>

Assuming this depends on other changes in the series? Thus this is
probably for PCI maintainers to pick up?

Acked-by: Ulf Hansson <[email protected]>

Kind regards
Uffe

> ---
> drivers/memstick/host/jmb38x_ms.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/memstick/host/jmb38x_ms.c b/drivers/memstick/host/jmb38x_ms.c
> index 32747425297d..fd281c1d39b1 100644
> --- a/drivers/memstick/host/jmb38x_ms.c
> +++ b/drivers/memstick/host/jmb38x_ms.c
> @@ -848,7 +848,7 @@ static int jmb38x_ms_count_slots(struct pci_dev *pdev)
> {
> int cnt, rc = 0;
>
> - for (cnt = 0; cnt < PCI_ROM_RESOURCE; ++cnt) {
> + for (cnt = 0; cnt < PCI_STD_NUM_BARS; ++cnt) {
> if (!(IORESOURCE_MEM & pci_resource_flags(pdev, cnt)))
> break;
>
> --
> 2.21.0
>

2019-09-21 00:22:13

by Denis Efremov (Oracle)

Subject: Re: [PATCH v3 23/26] memstick: use PCI_STD_NUM_BARS

On 20.09.2019 10:42, Ulf Hansson wrote:
> On Mon, 16 Sep 2019 at 22:47, Denis Efremov <[email protected]> wrote:
>>
>> Use define PCI_STD_NUM_BARS instead of PCI_ROM_RESOURCE for the number of
>> PCI BARs.
>>
>> Cc: Maxim Levitsky <[email protected]>
>> Cc: Alex Dubov <[email protected]>
>> Cc: Ulf Hansson <[email protected]>
>> Signed-off-by: Denis Efremov <[email protected]>
>
> Assuming this depends on other changes in the series?

Yes, the first patch introduce define PCI_STD_NUM_BARS.

> Thus this is
> probably for PCI maintainers to pick up?

Yes, this is for Bjorn's tree.

>
> Acked-by: Ulf Hansson <[email protected]>
>
> Kind regards
> Uffe
>
>> ---
>> drivers/memstick/host/jmb38x_ms.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/memstick/host/jmb38x_ms.c b/drivers/memstick/host/jmb38x_ms.c
>> index 32747425297d..fd281c1d39b1 100644
>> --- a/drivers/memstick/host/jmb38x_ms.c
>> +++ b/drivers/memstick/host/jmb38x_ms.c
>> @@ -848,7 +848,7 @@ static int jmb38x_ms_count_slots(struct pci_dev *pdev)
>> {
>> int cnt, rc = 0;
>>
>> - for (cnt = 0; cnt < PCI_ROM_RESOURCE; ++cnt) {
>> + for (cnt = 0; cnt < PCI_STD_NUM_BARS; ++cnt) {
>> if (!(IORESOURCE_MEM & pci_resource_flags(pdev, cnt)))
>> break;
>>
>> --
>> 2.21.0
>>