2019-09-17 09:48:03

by Biwen Li

Subject: [PATCH] devicetree: property-units: Add kohms unit

The patch adds kohms unit

Signed-off-by: Biwen Li <[email protected]>
---
Documentation/devicetree/bindings/property-units.txt | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/property-units.txt b/Documentation/devicetree/bindings/property-units.txt
index e9b8360b3288..97feb8995d1f 100644
--- a/Documentation/devicetree/bindings/property-units.txt
+++ b/Documentation/devicetree/bindings/property-units.txt
@@ -27,6 +27,7 @@ Electricity
-microamp : microampere
-microamp-hours : microampere hour
-ohms : ohm
+-kohms : kiloohm
-micro-ohms : microohm
-microwatt-hours: microwatt hour
-microvolt : microvolt
--
2.17.1

2019-09-17 09:49:55

by Geert Uytterhoeven

Subject: Re: [PATCH] devicetree: property-units: Add kohms unit

Hi Biwen,

On Tue, Sep 17, 2019 at 10:09 AM Biwen Li <[email protected]> wrote:
> The patch adds kohms unit
>
> Signed-off-by: Biwen Li <[email protected]>

Thanks for your patch!

> --- a/Documentation/devicetree/bindings/property-units.txt
> +++ b/Documentation/devicetree/bindings/property-units.txt
> @@ -27,6 +27,7 @@ Electricity
> -microamp : microampere
> -microamp-hours : microampere hour
> -ohms : ohm
> +-kohms : kiloohm
> -micro-ohms : microohm
> -microwatt-hours: microwatt hour
> -microvolt : microvolt

What's your rationale for adding "kohms"?
Do you need to specify resistance values that do not fit in 32-bit, and
thus cannot be specified using "ohms"?

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds