2019-09-17 18:00:25

by Aliasgar Surti

Subject: [PATCH] drivers:staging:rtl8723bs: Removed unneeded variables

From: Aliasgar Surti <[email protected]>

coccicheck reported warning for unneeded variable used.

This patch removes the unneeded variables.

Signed-off-by: Aliasgar Surti <[email protected]>
---
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 15 +++++----------
1 file changed, 5 insertions(+), 10 deletions(-)

diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
index d1b199e..fa3ffc3 100644
--- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
+++ b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
@@ -2428,8 +2428,7 @@ static int rtw_drvext_hdl(struct net_device *dev, struct iw_request_info *info,
static int rtw_mp_ioctl_hdl(struct net_device *dev, struct iw_request_info *info,
union iwreq_data *wrqu, char *extra)
{
- int ret = 0;
- return ret;
+ return 0;
}

static int rtw_get_ap_info(struct net_device *dev,
@@ -4462,24 +4461,21 @@ static int rtw_mp_efuse_get(struct net_device *dev,
struct iw_request_info *info,
union iwreq_data *wdata, char *extra)
{
- int err = 0;
- return err;
+ return 0;
}

static int rtw_mp_efuse_set(struct net_device *dev,
struct iw_request_info *info,
union iwreq_data *wdata, char *extra)
{
- int err = 0;
- return err;
+ return 0;
}

static int rtw_tdls(struct net_device *dev,
struct iw_request_info *info,
union iwreq_data *wrqu, char *extra)
{
- int ret = 0;
- return ret;
+ return 0;
}


@@ -4487,8 +4483,7 @@ static int rtw_tdls_get(struct net_device *dev,
struct iw_request_info *info,
union iwreq_data *wrqu, char *extra)
{
- int ret = 0;
- return ret;
+ return 0;
}


--
2.7.4

2019-09-17 18:02:09

by Dan Carpenter

Subject: Re: [PATCH] drivers:staging:rtl8723bs: Removed unneeded variables

On Tue, Sep 17, 2019 at 08:01:31PM +0530, Aliasgar Surti wrote:
> From: Aliasgar Surti <[email protected]>
>
> coccicheck reported warning for unneeded variable used.
>
> This patch removes the unneeded variables.
>
> Signed-off-by: Aliasgar Surti <[email protected]>
> ---
> drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 15 +++++----------
> 1 file changed, 5 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
> index d1b199e..fa3ffc3 100644
> --- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
> +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
> @@ -2428,8 +2428,7 @@ static int rtw_drvext_hdl(struct net_device *dev, struct iw_request_info *info,
> static int rtw_mp_ioctl_hdl(struct net_device *dev, struct iw_request_info *info,
> union iwreq_data *wrqu, char *extra)
> {
> - int ret = 0;
> - return ret;
> + return 0;
> }

Just get rid of the whole function. Replace the pointer in the function
array with a NULL.

regards,
dan carpenter

2019-09-18 06:23:42

by Aliasgar Surti

Subject: Re: [PATCH] drivers:staging:rtl8723bs: Removed unneeded variables

On Tue, Sep 17, 2019 at 05:44:32PM +0300, Dan Carpenter wrote:
> On Tue, Sep 17, 2019 at 08:01:31PM +0530, Aliasgar Surti wrote:
> > From: Aliasgar Surti <[email protected]>
> >
> > coccicheck reported warning for unneeded variable used.
> >
> > This patch removes the unneeded variables.
> >
> > Signed-off-by: Aliasgar Surti <[email protected]>
> > ---
> > drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 15 +++++----------
> > 1 file changed, 5 insertions(+), 10 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
> > index d1b199e..fa3ffc3 100644
> > --- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
> > +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
> > @@ -2428,8 +2428,7 @@ static int rtw_drvext_hdl(struct net_device *dev, struct iw_request_info *info,
> > static int rtw_mp_ioctl_hdl(struct net_device *dev, struct iw_request_info *info,
> > union iwreq_data *wrqu, char *extra)
> > {
> > - int ret = 0;
> > - return ret;
> > + return 0;
> > }
>
> Just get rid of the whole function. Replace the pointer in the function
> array with a NULL.
Okay, I will get rid of unneeded functions and replace them with NULL in
function array.

Thanks,
Aliasgar
>
> regards,
> dan carpenter
>