2019-09-19 07:52:59

by Srikanth Krishnakar

Subject: [PATCH] platform/x86: pmc_atom: Add Siemens SIMATIC IPC2x7E to critclk_systems DMI table

The SIMATIC IPC227E and IPC277E uses the PMC clock for on-board components
and gets stuck during boot if the clock is disabled. Therefore, add this
device to the critical systems list.

The Board revision does vary in some instances and hence use PRODUCT_NAME
to allow the boards to boot with identical names.

Tested on SIMATIC IPC227E and IPC277E.

Fixes: 648e921888ad ("clk: x86: Stop marking clocks as CLK_IS_CRITICAL")
CC: Jan Kiszka <[email protected]>
CC: Cedric Hombourger <[email protected]>
Signed-off-by: Srikanth Krishnakar <[email protected]>
---
drivers/platform/x86/pmc_atom.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/platform/x86/pmc_atom.c b/drivers/platform/x86/pmc_atom.c
index 9aca5e7ce6d0..1e48c2ec684e 100644
--- a/drivers/platform/x86/pmc_atom.c
+++ b/drivers/platform/x86/pmc_atom.c
@@ -419,7 +419,14 @@ static const struct dmi_system_id critclk_systems[] = {
.ident = "SIMATIC IPC227E",
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "SIEMENS AG"),
- DMI_MATCH(DMI_PRODUCT_VERSION, "6ES7647-8B"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "SIMATIC IPC227E"),
+ },
+ },
+ {
+ .ident = "SIMATIC IPC277E",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "SIEMENS AG"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "SIMATIC IPC277E"),
},
},
{ /*sentinel*/ }
--
2.17.1

2019-09-19 07:59:41

by Jan Kiszka

Subject: Re: [PATCH] platform/x86: pmc_atom: Add Siemens SIMATIC IPC2x7E to critclk_systems DMI table

On 19.09.19 09:45, Srikanth Krishnakar wrote:
> The SIMATIC IPC227E and IPC277E uses the PMC clock for on-board components
> and gets stuck during boot if the clock is disabled. Therefore, add this
> device to the critical systems list.
>
> The Board revision does vary in some instances and hence use PRODUCT_NAME
> to allow the boards to boot with identical names.
>
> Tested on SIMATIC IPC227E and IPC277E.
>
> Fixes: 648e921888ad ("clk: x86: Stop marking clocks as CLK_IS_CRITICAL")
> CC: Jan Kiszka <[email protected]>
> CC: Cedric Hombourger <[email protected]>
> Signed-off-by: Srikanth Krishnakar <[email protected]>
> ---
> drivers/platform/x86/pmc_atom.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/pmc_atom.c b/drivers/platform/x86/pmc_atom.c
> index 9aca5e7ce6d0..1e48c2ec684e 100644
> --- a/drivers/platform/x86/pmc_atom.c
> +++ b/drivers/platform/x86/pmc_atom.c
> @@ -419,7 +419,14 @@ static const struct dmi_system_id critclk_systems[] = {
> .ident = "SIMATIC IPC227E",
> .matches = {
> DMI_MATCH(DMI_SYS_VENDOR, "SIEMENS AG"),
> - DMI_MATCH(DMI_PRODUCT_VERSION, "6ES7647-8B"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "SIMATIC IPC227E"),

NACK, this is breaking platform variant detection.

> + },
> + },
> + {
> + .ident = "SIMATIC IPC277E",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "SIEMENS AG"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "SIMATIC IPC277E"),

Let us clarify internally if we need to match on the same substring length as
for the 227E.

Jan

> },
> },
> { /*sentinel*/ }
>

--
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux