2019-09-19 22:19:23

by Kim Phillips

Subject: [PATCH 3/5] perf vendor events: minor fixes to the README

Some grammatical fixes, and updates to some path references that have
since changed.

Signed-off-by: Kim Phillips <[email protected]>
Cc: Janakarajan Natarajan <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: Arnaldo Carvalho de Melo <[email protected]>
Cc: Alexander Shishkin <[email protected]>
Cc: Andi Kleen <[email protected]>
Cc: Jiri Olsa <[email protected]>
Cc: Namhyung Kim <[email protected]>
Cc: Borislav Petkov <[email protected]>
Cc: Martin Liska <[email protected]>
Cc: Luke Mujica <[email protected]>
Cc: Jin Yao <[email protected]>
Cc: Kan Liang <[email protected]>
Cc: [email protected]
Cc: [email protected]
---
tools/perf/pmu-events/README | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/tools/perf/pmu-events/README b/tools/perf/pmu-events/README
index e62b09b6a844..de7efa2cebd1 100644
--- a/tools/perf/pmu-events/README
+++ b/tools/perf/pmu-events/README
@@ -30,9 +30,9 @@ the topic. Eg: "Floating-point.json".
All the topic JSON files for a CPU model/family should be in a separate
sub directory. Thus for the Silvermont X86 CPU:

- $ ls tools/perf/pmu-events/arch/x86/Silvermont_core
- Cache.json Memory.json Virtual-Memory.json
- Frontend.json Pipeline.json
+ $ ls tools/perf/pmu-events/arch/x86/silvermont
+ cache.json memory.json virtual-memory.json
+ frontend.json pipeline.json

The JSONs folder for a CPU model/family may be placed in the root arch
folder, or may be placed in a vendor sub-folder under the arch folder
@@ -94,7 +94,7 @@ users to specify events by their name:

where 'pm_1plus_ppc_cmpl' is a Power8 PMU event.

-However some errors in processing may cause the perf build to fail.
+However some errors in processing may cause the alias build to fail.

Mapfile format
===============
@@ -119,7 +119,7 @@ where:

Header line
The header line is the first line in the file, which is
- always _IGNORED_. It can empty.
+ always _IGNORED_. It can be empty.

CPUID:
CPUID is an arch-specific char string, that can be used
@@ -138,15 +138,15 @@ where:
files, relative to the directory containing the mapfile.csv

Type:
- indicates whether the events or "core" or "uncore" events.
+ indicates whether the events are "core" or "uncore" events.


Eg:

- $ grep Silvermont tools/perf/pmu-events/arch/x86/mapfile.csv
- GenuineIntel-6-37,V13,Silvermont_core,core
- GenuineIntel-6-4D,V13,Silvermont_core,core
- GenuineIntel-6-4C,V13,Silvermont_core,core
+ $ grep silvermont tools/perf/pmu-events/arch/x86/mapfile.csv
+ GenuineIntel-6-37,v13,silvermont,core
+ GenuineIntel-6-4D,v13,silvermont,core
+ GenuineIntel-6-4C,v13,silvermont,core

i.e the three CPU models use the JSON files (i.e PMU events) listed
- in the directory 'tools/perf/pmu-events/arch/x86/Silvermont_core'.
+ in the directory 'tools/perf/pmu-events/arch/x86/silvermont'.
--
2.23.0

2019-09-19 22:25:36

by Andi Kleen

Subject: Re: [PATCH 3/5] perf vendor events: minor fixes to the README

For all the patches except the last

Reviewed-by: Andi Kleen <[email protected]>

2019-09-25 14:33:14

by Arnaldo Carvalho de Melo

Subject: Re: [PATCH 3/5] perf vendor events: minor fixes to the README

Em Thu, Sep 19, 2019 at 03:09:28PM -0700, Andi Kleen escreveu:
> For all the patches except the last
>
> Reviewed-by: Andi Kleen <[email protected]>

Thanks, applying all but the last till we get that further discussed.

--

- Arnaldo