2019-09-24 17:44:38

by Neil Armstrong

Subject: Re: [PATCH] drm/rockchip: Add AFBC support

On 23/09/2019 14:20, Andrzej Pietrasiewicz wrote:
> From: Ezequiel Garcia <[email protected]>
>
> AFBC is a proprietary lossless image compression protocol and format.
> It helps reduce memory bandwidth of the graphics pipeline operations.
> This, in turn, improves power efficiency.
>
> Signed-off-by: Ezequiel Garcia <[email protected]>
> [locking improvements]
> Signed-off-by: Tomeu Vizoso <[email protected]>
> [squashing the above, commit message and Rockchip AFBC modifier]
> Signed-off-by: Andrzej Pietrasiewicz <[email protected]>
> ---
> drivers/gpu/drm/rockchip/rockchip_drm_fb.c | 27 ++++++
> drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 94 ++++++++++++++++++++-
> drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 12 +++
> drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 18 ++++
> include/uapi/drm/drm_fourcc.h | 3 +
> 5 files changed, 151 insertions(+), 3 deletions(-)
>

[...]

> diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h
> index 3feeaa3f987a..ba6caf06c824 100644
> --- a/include/uapi/drm/drm_fourcc.h
> +++ b/include/uapi/drm/drm_fourcc.h
> @@ -742,6 +742,9 @@ extern "C" {
> */
> #define AFBC_FORMAT_MOD_BCH (1ULL << 11)
>
> +#define AFBC_FORMAT_MOD_ROCKCHIP \
> + (AFBC_FORMAT_MOD_BLOCK_SIZE_16x16 | AFBC_FORMAT_MOD_SPARSE)

This define looks useless, what's Rockchip specific here ?

Neil

> +
> /*
> * Allwinner tiled modifier
> *
>

2019-09-25 17:48:31

by Andrzej Pietrasiewicz

Subject: Re: [PATCH] drm/rockchip: Add AFBC support

Dear All,

As a result of my mistake I've sent this patch with an incorrect SOB chain.
Please kindly disregard this patch.

@Neil: thank you for your time you spent reviewing it and answering and I'm
sorry it's to no effect.
@Ezequiel, @Tomeu: I apologize to you. My mistake.

Regards,

Andrzej Pietrasiewicz


W dniu 23.09.2019 o 15:53, Neil Armstrong pisze:
> On 23/09/2019 14:20, Andrzej Pietrasiewicz wrote:
>> From: Ezequiel Garcia <[email protected]>
>>
>> AFBC is a proprietary lossless image compression protocol and format.
>> It helps reduce memory bandwidth of the graphics pipeline operations.
>> This, in turn, improves power efficiency.
>>
>> Signed-off-by: Ezequiel Garcia <[email protected]>
>> [locking improvements]
>> Signed-off-by: Tomeu Vizoso <[email protected]>
>> [squashing the above, commit message and Rockchip AFBC modifier]
>> Signed-off-by: Andrzej Pietrasiewicz <[email protected]>
>> ---
>> drivers/gpu/drm/rockchip/rockchip_drm_fb.c | 27 ++++++
>> drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 94 ++++++++++++++++++++-
>> drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 12 +++
>> drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 18 ++++
>> include/uapi/drm/drm_fourcc.h | 3 +
>> 5 files changed, 151 insertions(+), 3 deletions(-)
>>
>
> [...]
>
>> diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h
>> index 3feeaa3f987a..ba6caf06c824 100644
>> --- a/include/uapi/drm/drm_fourcc.h
>> +++ b/include/uapi/drm/drm_fourcc.h
>> @@ -742,6 +742,9 @@ extern "C" {
>> */
>> #define AFBC_FORMAT_MOD_BCH (1ULL << 11)
>>
>> +#define AFBC_FORMAT_MOD_ROCKCHIP \
>> + (AFBC_FORMAT_MOD_BLOCK_SIZE_16x16 | AFBC_FORMAT_MOD_SPARSE)
>
> This define looks useless, what's Rockchip specific here ?
>
> Neil
>
>> +
>> /*
>> * Allwinner tiled modifier
>> *
>>
>

2019-09-26 09:26:14

by Ayan Halder

Subject: Re: [PATCH] drm/rockchip: Add AFBC support

On Mon, Sep 23, 2019 at 05:34:14PM +0200, Andrzej Pietrasiewicz wrote:
> Dear All,
>
> As a result of my mistake I've sent this patch with an incorrect SOB chain.
> Please kindly disregard this patch.
>
> @Neil: thank you for your time you spent reviewing it and answering and I'm
> sorry it's to no effect.
> @Ezequiel, @Tomeu: I apologize to you. My mistake.
>
> Regards,
>
> Andrzej Pietrasiewicz
>
>
> W dniu 23.09.2019 o?15:53, Neil Armstrong pisze:
> >On 23/09/2019 14:20, Andrzej Pietrasiewicz wrote:
> >>From: Ezequiel Garcia <[email protected]>
> >>
> >>AFBC is a proprietary lossless image compression protocol and format.
> >>It helps reduce memory bandwidth of the graphics pipeline operations.
> >>This, in turn, improves power efficiency.
> >>
> >>Signed-off-by: Ezequiel Garcia <[email protected]>
> >>[locking improvements]
> >>Signed-off-by: Tomeu Vizoso <[email protected]>
> >>[squashing the above, commit message and Rockchip AFBC modifier]
> >>Signed-off-by: Andrzej Pietrasiewicz <[email protected]>
> >>---
> >> drivers/gpu/drm/rockchip/rockchip_drm_fb.c | 27 ++++++
> >> drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 94 ++++++++++++++++++++-
> >> drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 12 +++
> >> drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 18 ++++
> >> include/uapi/drm/drm_fourcc.h | 3 +
> >> 5 files changed, 151 insertions(+), 3 deletions(-)
> >>
> >
> >[...]
> >
> >>diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h
> >>index 3feeaa3f987a..ba6caf06c824 100644
> >>--- a/include/uapi/drm/drm_fourcc.h
> >>+++ b/include/uapi/drm/drm_fourcc.h
> >>@@ -742,6 +742,9 @@ extern "C" {
> >> */
> >> #define AFBC_FORMAT_MOD_BCH (1ULL << 11)
> >>+#define AFBC_FORMAT_MOD_ROCKCHIP \
> >>+ (AFBC_FORMAT_MOD_BLOCK_SIZE_16x16 | AFBC_FORMAT_MOD_SPARSE)
> >
> >This define looks useless, what's Rockchip specific here ?
> >
Please reuse the existing AFBC modifiers.

Have a look at malidp_format_modifiers[] in which we have defined
the modifiers(for our driver) we are using.

In your case, it will be
DRM_FORMAT_MOD_ARM_AFBC(AFBC_FORMAT_MOD_BLOCK_SIZE_16x16|AFBC_FORMAT_MOD_SPARSE)

> >Neil
> >
> >>+
> >> /*
> >> * Allwinner tiled modifier
> >> *
> >>
> >
>
> _______________________________________________
> dri-devel mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/dri-devel