From: Filip Kokosinski <[email protected]>
Add documentation for LiteUART devicetree bindings.
Signed-off-by: Filip Kokosinski <[email protected]>
Signed-off-by: Mateusz Holenko <[email protected]>
---
.../devicetree/bindings/serial/litex,liteuart.txt | 12 ++++++++++++
MAINTAINERS | 6 ++++++
2 files changed, 18 insertions(+)
create mode 100644 Documentation/devicetree/bindings/serial/litex,liteuart.txt
diff --git a/Documentation/devicetree/bindings/serial/litex,liteuart.txt b/Documentation/devicetree/bindings/serial/litex,liteuart.txt
new file mode 100644
index 000000000..13c71a0c9
--- /dev/null
+++ b/Documentation/devicetree/bindings/serial/litex,liteuart.txt
@@ -0,0 +1,12 @@
+LiteUART serial controller
+
+Required properties:
+- compatible: should be "litex,liteuart"
+- reg: base address and length of the register set for this device
+
+Example:
+
+uart0: serial@f0001000 {
+ compatible = "litex,liteuart";
+ reg = <0xe0001800 0x100>;
+};
diff --git a/MAINTAINERS b/MAINTAINERS
index b2326dece..65a6cf296 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -9462,6 +9462,12 @@ F: Documentation/misc-devices/lis3lv02d.rst
F: drivers/misc/lis3lv02d/
F: drivers/platform/x86/hp_accel.c
+LITEX PLATFORM
+M: Karol Gugala <[email protected]>
+M: Mateusz Holenko <[email protected]>
+S: Maintained
+F: Documentation/devicetree/bindings/serial/litex,liteuart.txt
+
LIVE PATCHING
M: Josh Poimboeuf <[email protected]>
M: Jiri Kosina <[email protected]>
--
2.23.0
On Mon, Sep 30, 2019 at 8:04 AM Mateusz Holenko <[email protected]> wrote:
>
> From: Filip Kokosinski <[email protected]>
>
> Add documentation for LiteUART devicetree bindings.
>
> Signed-off-by: Filip Kokosinski <[email protected]>
> Signed-off-by: Mateusz Holenko <[email protected]>
> ---
> .../devicetree/bindings/serial/litex,liteuart.txt | 12 ++++++++++++
> MAINTAINERS | 6 ++++++
> 2 files changed, 18 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/serial/litex,liteuart.txt
Please make this a schema. See
Documentation/devicetree/writing-schema.rst (or .md before 5.4).
>
> diff --git a/Documentation/devicetree/bindings/serial/litex,liteuart.txt b/Documentation/devicetree/bindings/serial/litex,liteuart.txt
> new file mode 100644
> index 000000000..13c71a0c9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/serial/litex,liteuart.txt
> @@ -0,0 +1,12 @@
> +LiteUART serial controller
> +
> +Required properties:
> +- compatible: should be "litex,liteuart"
Only 1 version?
> +- reg: base address and length of the register set for this device
Is there really no interrupt line? That should be added if there's h/w
support even if the driver doesn't yet support it.
> +
> +Example:
> +
> +uart0: serial@f0001000 {
Wrong unit address. Should be "@e0001800".
> + compatible = "litex,liteuart";
> + reg = <0xe0001800 0x100>;
> +};
> diff --git a/MAINTAINERS b/MAINTAINERS
> index b2326dece..65a6cf296 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -9462,6 +9462,12 @@ F: Documentation/misc-devices/lis3lv02d.rst
> F: drivers/misc/lis3lv02d/
> F: drivers/platform/x86/hp_accel.c
>
> +LITEX PLATFORM
> +M: Karol Gugala <[email protected]>
> +M: Mateusz Holenko <[email protected]>
> +S: Maintained
> +F: Documentation/devicetree/bindings/serial/litex,liteuart.txt
> +
> LIVE PATCHING
> M: Josh Poimboeuf <[email protected]>
> M: Jiri Kosina <[email protected]>
> --
> 2.23.0
>
pon., 30 wrz 2019 o 23:32 Rob Herring <[email protected]> napisał(a):
>
> On Mon, Sep 30, 2019 at 8:04 AM Mateusz Holenko <[email protected]> wrote:
> >
> > From: Filip Kokosinski <[email protected]>
> >
> > Add documentation for LiteUART devicetree bindings.
> >
> > Signed-off-by: Filip Kokosinski <[email protected]>
> > Signed-off-by: Mateusz Holenko <[email protected]>
> > ---
> > .../devicetree/bindings/serial/litex,liteuart.txt | 12 ++++++++++++
> > MAINTAINERS | 6 ++++++
> > 2 files changed, 18 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/serial/litex,liteuart.txt
>
> Please make this a schema. See
> Documentation/devicetree/writing-schema.rst (or .md before 5.4).
Ok. We will rewrite it.
> >
> > diff --git a/Documentation/devicetree/bindings/serial/litex,liteuart.txt b/Documentation/devicetree/bindings/serial/litex,liteuart.txt
> > new file mode 100644
> > index 000000000..13c71a0c9
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/serial/litex,liteuart.txt
> > @@ -0,0 +1,12 @@
> > +LiteUART serial controller
> > +
> > +Required properties:
> > +- compatible: should be "litex,liteuart"
>
> Only 1 version?
For the time being there is only one flavor.
> > +- reg: base address and length of the register set for this device
>
> Is there really no interrupt line? That should be added if there's h/w
> support even if the driver doesn't yet support it.
>
> > +
> > +Example:
> > +
> > +uart0: serial@f0001000 {
>
> Wrong unit address. Should be "@e0001800".
Right, address should be consistent with the one in 'reg'.
>
> > + compatible = "litex,liteuart";
> > + reg = <0xe0001800 0x100>;
> > +};
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index b2326dece..65a6cf296 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -9462,6 +9462,12 @@ F: Documentation/misc-devices/lis3lv02d.rst
> > F: drivers/misc/lis3lv02d/
> > F: drivers/platform/x86/hp_accel.c
> >
> > +LITEX PLATFORM
> > +M: Karol Gugala <[email protected]>
> > +M: Mateusz Holenko <[email protected]>
> > +S: Maintained
> > +F: Documentation/devicetree/bindings/serial/litex,liteuart.txt
> > +
> > LIVE PATCHING
> > M: Josh Poimboeuf <[email protected]>
> > M: Jiri Kosina <[email protected]>
> > --
> > 2.23.0
> >
Thanks for your comments.
I'll address the remarks in V2 of the patchset after receiving a
response on the rest of the patches.
--
Mateusz Holenko
mobile: +48 606 791 789
Antmicro Ltd | http://www.antmicro.com
Zwierzyniecka 3, 60-813 Poznan, Poland