2019-10-01 07:35:11

by Austin Kim

[permalink] [raw]
Subject: [PATCH] fs: cifs: mute -Wunused-const-variable message

After 'Initial git repository build' commit,
'mapping_table_ERRHRD' variable has not been used.

So 'mapping_table_ERRHRD' const variable could be removed
to mute below warning message:

fs/cifs/netmisc.c:120:40: warning: unused variable 'mapping_table_ERRHRD' [-Wunused-const-variable]
static const struct smb_to_posix_error mapping_table_ERRHRD[] = {
^
Signed-off-by: Austin Kim <[email protected]>
---
fs/cifs/netmisc.c | 4 ----
1 file changed, 4 deletions(-)

diff --git a/fs/cifs/netmisc.c b/fs/cifs/netmisc.c
index 49c17ee1..9b41436 100644
--- a/fs/cifs/netmisc.c
+++ b/fs/cifs/netmisc.c
@@ -117,10 +117,6 @@ static const struct smb_to_posix_error mapping_table_ERRSRV[] = {
{0, 0}
};

-static const struct smb_to_posix_error mapping_table_ERRHRD[] = {
- {0, 0}
-};
-
/*
* Convert a string containing text IPv4 or IPv6 address to binary form.
*
--
2.6.2


2019-10-03 19:14:13

by Steve French

[permalink] [raw]
Subject: Re: [PATCH] fs: cifs: mute -Wunused-const-variable message

merged into cifs-2.6.git for-next

On Tue, Oct 1, 2019 at 2:34 AM Austin Kim <[email protected]> wrote:
>
> After 'Initial git repository build' commit,
> 'mapping_table_ERRHRD' variable has not been used.
>
> So 'mapping_table_ERRHRD' const variable could be removed
> to mute below warning message:
>
> fs/cifs/netmisc.c:120:40: warning: unused variable 'mapping_table_ERRHRD' [-Wunused-const-variable]
> static const struct smb_to_posix_error mapping_table_ERRHRD[] = {
> ^
> Signed-off-by: Austin Kim <[email protected]>
> ---
> fs/cifs/netmisc.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/fs/cifs/netmisc.c b/fs/cifs/netmisc.c
> index 49c17ee1..9b41436 100644
> --- a/fs/cifs/netmisc.c
> +++ b/fs/cifs/netmisc.c
> @@ -117,10 +117,6 @@ static const struct smb_to_posix_error mapping_table_ERRSRV[] = {
> {0, 0}
> };
>
> -static const struct smb_to_posix_error mapping_table_ERRHRD[] = {
> - {0, 0}
> -};
> -
> /*
> * Convert a string containing text IPv4 or IPv6 address to binary form.
> *
> --
> 2.6.2
>


--
Thanks,

Steve