2019-10-02 16:14:37

by J. Neuschäfer

[permalink] [raw]
Subject: [PATCH 1/2] drm/mcde: Fix reference to DOC comment

The :doc: reference did not match the DOC comment's name.

Fixes: 5fc537bfd000 ("drm/mcde: Add new driver for ST-Ericsson MCDE")
Signed-off-by: Jonathan Neuschäfer <[email protected]>
---
Documentation/gpu/mcde.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/gpu/mcde.rst b/Documentation/gpu/mcde.rst
index c69e977defda..dd43dde379e0 100644
--- a/Documentation/gpu/mcde.rst
+++ b/Documentation/gpu/mcde.rst
@@ -5,4 +5,4 @@
=======================================================

.. kernel-doc:: drivers/gpu/drm/mcde/mcde_drv.c
- :doc: ST-Ericsson MCDE DRM Driver
+ :doc: ST-Ericsson MCDE Driver
--
2.20.1


2019-10-03 14:58:09

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH 1/2] drm/mcde: Fix reference to DOC comment

On Wed, Oct 2, 2019 at 5:39 PM Jonathan Neuschäfer
<[email protected]> wrote:

> The :doc: reference did not match the DOC comment's name.
>
> Fixes: 5fc537bfd000 ("drm/mcde: Add new driver for ST-Ericsson MCDE")
> Signed-off-by: Jonathan Neuschäfer <[email protected]>

Both patches applied!

Yours,
Linus Walleij

2019-10-03 14:59:02

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH 1/2] drm/mcde: Fix reference to DOC comment

On Thu, Oct 3, 2019 at 4:34 PM Linus Walleij <[email protected]> wrote:
> On Wed, Oct 2, 2019 at 5:39 PM Jonathan Neuschäfer
> <[email protected]> wrote:
>
> > The :doc: reference did not match the DOC comment's name.
> >
> > Fixes: 5fc537bfd000 ("drm/mcde: Add new driver for ST-Ericsson MCDE")
> > Signed-off-by: Jonathan Neuschäfer <[email protected]>
>
> Both patches applied!

...but I can't push the changes:

$ dim push-branch drm-misc-next
dim: 9fa1f9734e40 ("Revert "drm/sun4i: dsi: Change the start delay
calculation""): committer Signed-off-by missing.
dim: ERROR: issues in commits detected, aborting

Not even my commit, apart from that it looks like it does have
the committer Signed-off-by. I'm confused and don't know what
to do... anyone has some hints?

Linus Walleij

2019-10-03 15:17:16

by Maxime Ripard

[permalink] [raw]
Subject: Re: [PATCH 1/2] drm/mcde: Fix reference to DOC comment

Hi,

On Thu, Oct 03, 2019 at 04:39:39PM +0200, Linus Walleij wrote:
> On Thu, Oct 3, 2019 at 4:34 PM Linus Walleij <[email protected]> wrote:
> > On Wed, Oct 2, 2019 at 5:39 PM Jonathan Neusch?fer
> > <[email protected]> wrote:
> >
> > > The :doc: reference did not match the DOC comment's name.
> > >
> > > Fixes: 5fc537bfd000 ("drm/mcde: Add new driver for ST-Ericsson MCDE")
> > > Signed-off-by: Jonathan Neusch?fer <[email protected]>
> >
> > Both patches applied!
>
> ...but I can't push the changes:
>
> $ dim push-branch drm-misc-next
> dim: 9fa1f9734e40 ("Revert "drm/sun4i: dsi: Change the start delay
> calculation""): committer Signed-off-by missing.
> dim: ERROR: issues in commits detected, aborting
>
> Not even my commit, apart from that it looks like it does have
> the committer Signed-off-by. I'm confused and don't know what
> to do... anyone has some hints?

Yeah, it's pretty weird, I just pushed without any trouble.

Did you rebase or something?

Maxime


Attachments:
(No filename) (1.00 kB)
signature.asc (235.00 B)
Download all attachments

2019-10-04 22:27:57

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH 1/2] drm/mcde: Fix reference to DOC comment

On Thu, Oct 3, 2019 at 5:15 PM Maxime Ripard <[email protected]> wrote:

> > > > Fixes: 5fc537bfd000 ("drm/mcde: Add new driver for ST-Ericsson MCDE")
> > > > Signed-off-by: Jonathan Neuschäfer <[email protected]>
> > >
> > > Both patches applied!
> >
> > ...but I can't push the changes:
> >
> > $ dim push-branch drm-misc-next
> > dim: 9fa1f9734e40 ("Revert "drm/sun4i: dsi: Change the start delay
> > calculation""): committer Signed-off-by missing.
> > dim: ERROR: issues in commits detected, aborting
> >
> > Not even my commit, apart from that it looks like it does have
> > the committer Signed-off-by. I'm confused and don't know what
> > to do... anyone has some hints?
>
> Yeah, it's pretty weird, I just pushed without any trouble.
>
> Did you rebase or something?

Nope... even tried to reset hard to origin :/

I guess just try again...

Yours,
Linus Walleij