2019-10-02 16:18:51

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 1/4] dt-bindings: samsung: Indent examples with four spaces

Change the indentation of examples used in json-schema bindings from two
to four spaces as this makes the code easier to read and seems to be
preferred in other files.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../bindings/arm/samsung/exynos-chipid.yaml | 4 +-
.../bindings/iio/adc/samsung,exynos-adc.yaml | 64 +++++++++----------
.../bindings/power/reset/syscon-poweroff.yaml | 8 +--
.../bindings/power/reset/syscon-reboot.yaml | 8 +--
.../devicetree/bindings/rtc/s3c-rtc.yaml | 12 ++--
5 files changed, 48 insertions(+), 48 deletions(-)

diff --git a/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml b/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml
index 9c573ad7dc7d..ce40adabb4e8 100644
--- a/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml
+++ b/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml
@@ -20,6 +20,6 @@ properties:
examples:
- |
chipid@10000000 {
- compatible = "samsung,exynos4210-chipid";
- reg = <0x10000000 0x100>;
+ compatible = "samsung,exynos4210-chipid";
+ reg = <0x10000000 0x100>;
};
diff --git a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
index b4c6c26681d9..a0a9b909ac40 100644
--- a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
@@ -112,40 +112,40 @@ allOf:
examples:
- |
adc: adc@12d10000 {
- compatible = "samsung,exynos-adc-v1";
- reg = <0x12d10000 0x100>;
- interrupts = <0 106 0>;
- #io-channel-cells = <1>;
- io-channel-ranges;
-
- clocks = <&clock 303>;
- clock-names = "adc";
-
- vdd-supply = <&buck5_reg>;
- samsung,syscon-phandle = <&pmu_system_controller>;
-
- /* NTC thermistor is a hwmon device */
- ncp15wb473@0 {
- compatible = "murata,ncp15wb473";
- pullup-uv = <1800000>;
- pullup-ohm = <47000>;
- pulldown-ohm = <0>;
- io-channels = <&adc 4>;
- };
+ compatible = "samsung,exynos-adc-v1";
+ reg = <0x12d10000 0x100>;
+ interrupts = <0 106 0>;
+ #io-channel-cells = <1>;
+ io-channel-ranges;
+
+ clocks = <&clock 303>;
+ clock-names = "adc";
+
+ vdd-supply = <&buck5_reg>;
+ samsung,syscon-phandle = <&pmu_system_controller>;
+
+ /* NTC thermistor is a hwmon device */
+ ncp15wb473@0 {
+ compatible = "murata,ncp15wb473";
+ pullup-uv = <1800000>;
+ pullup-ohm = <47000>;
+ pulldown-ohm = <0>;
+ io-channels = <&adc 4>;
+ };
};

- |
adc@126c0000 {
- compatible = "samsung,exynos3250-adc";
- reg = <0x126C0000 0x100>;
- interrupts = <0 137 0>;
- #io-channel-cells = <1>;
- io-channel-ranges;
-
- clocks = <&cmu 0>, // CLK_TSADC
- <&cmu 1>; // CLK_SCLK_TSADC
- clock-names = "adc", "sclk";
-
- vdd-supply = <&buck5_reg>;
- samsung,syscon-phandle = <&pmu_system_controller>;
+ compatible = "samsung,exynos3250-adc";
+ reg = <0x126C0000 0x100>;
+ interrupts = <0 137 0>;
+ #io-channel-cells = <1>;
+ io-channel-ranges;
+
+ clocks = <&cmu 0>, // CLK_TSADC
+ <&cmu 1>; // CLK_SCLK_TSADC
+ clock-names = "adc", "sclk";
+
+ vdd-supply = <&buck5_reg>;
+ samsung,syscon-phandle = <&pmu_system_controller>;
};
diff --git a/Documentation/devicetree/bindings/power/reset/syscon-poweroff.yaml b/Documentation/devicetree/bindings/power/reset/syscon-poweroff.yaml
index fb812937b534..520e07e6f21b 100644
--- a/Documentation/devicetree/bindings/power/reset/syscon-poweroff.yaml
+++ b/Documentation/devicetree/bindings/power/reset/syscon-poweroff.yaml
@@ -53,8 +53,8 @@ allOf:
examples:
- |
poweroff {
- compatible = "syscon-poweroff";
- regmap = <&regmapnode>;
- offset = <0x0>;
- mask = <0x7a>;
+ compatible = "syscon-poweroff";
+ regmap = <&regmapnode>;
+ offset = <0x0>;
+ mask = <0x7a>;
};
diff --git a/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml b/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml
index a7920f5eef79..d38006b1f1f4 100644
--- a/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml
+++ b/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml
@@ -53,8 +53,8 @@ allOf:
examples:
- |
reboot {
- compatible = "syscon-reboot";
- regmap = <&regmapnode>;
- offset = <0x0>;
- mask = <0x1>;
+ compatible = "syscon-reboot";
+ regmap = <&regmapnode>;
+ offset = <0x0>;
+ mask = <0x1>;
};
diff --git a/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml b/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
index 951a6a485709..95570d7e19eb 100644
--- a/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
+++ b/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
@@ -76,10 +76,10 @@ allOf:
examples:
- |
rtc@10070000 {
- compatible = "samsung,s3c6410-rtc";
- reg = <0x10070000 0x100>;
- interrupts = <0 44 4>, <0 45 4>;
- clocks = <&clock 0>, // CLK_RTC
- <&s2mps11_osc 0>; // S2MPS11_CLK_AP
- clock-names = "rtc", "rtc_src";
+ compatible = "samsung,s3c6410-rtc";
+ reg = <0x10070000 0x100>;
+ interrupts = <0 44 4>, <0 45 4>;
+ clocks = <&clock 0>, // CLK_RTC
+ <&s2mps11_osc 0>; // S2MPS11_CLK_AP
+ clock-names = "rtc", "rtc_src";
};
--
2.17.1


2019-10-02 16:19:02

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 3/4] dt-bindings: rtc: s3c: Include generic dt-schema bindings

Include the generic rtc.yaml bindings in Samsung S3C RTC bindings. This
brings the requirement of proper node names and adds parsing of
additional properties.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
Documentation/devicetree/bindings/rtc/s3c-rtc.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml b/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
index 4d91cdc9b998..76bbf8b7555b 100644
--- a/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
+++ b/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
@@ -48,6 +48,7 @@ properties:
maxItems: 2

allOf:
+ - $ref: rtc.yaml#
- if:
properties:
compatible:
--
2.17.1

2019-10-02 16:20:59

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 2/4] dt-bindings: rtc: s3c: Use defines instead of clock numbers

Make the examples in S3C RTC bindings more readable and bring them
closer to real DTS by using defines for clocks.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
Documentation/devicetree/bindings/rtc/s3c-rtc.yaml | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml b/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
index 95570d7e19eb..4d91cdc9b998 100644
--- a/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
+++ b/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
@@ -75,11 +75,14 @@ allOf:

examples:
- |
+ #include <dt-bindings/clock/exynos5420.h>
+ #include <dt-bindings/clock/samsung,s2mps11.h>
+
rtc@10070000 {
compatible = "samsung,s3c6410-rtc";
reg = <0x10070000 0x100>;
interrupts = <0 44 4>, <0 45 4>;
- clocks = <&clock 0>, // CLK_RTC
- <&s2mps11_osc 0>; // S2MPS11_CLK_AP
+ clocks = <&clock CLK_RTC>,
+ <&s2mps11_osc S2MPS11_CLK_AP>;
clock-names = "rtc", "rtc_src";
};
--
2.17.1

2019-10-02 16:21:22

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 4/4] dt-bindings: iio: adc: exynos: Use defines instead of clock numbers

Make the examples in Exynos ADC bindings more readable and bring them
closer to real DTS by using defines for clocks.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../devicetree/bindings/iio/adc/samsung,exynos-adc.yaml | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
index a0a9b909ac40..a3010e7ea051 100644
--- a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
@@ -135,6 +135,8 @@ examples:
};

- |
+ #include <dt-bindings/clock/exynos3250.h>
+
adc@126c0000 {
compatible = "samsung,exynos3250-adc";
reg = <0x126C0000 0x100>;
@@ -142,8 +144,8 @@ examples:
#io-channel-cells = <1>;
io-channel-ranges;

- clocks = <&cmu 0>, // CLK_TSADC
- <&cmu 1>; // CLK_SCLK_TSADC
+ clocks = <&cmu CLK_TSADC>,
+ <&cmu CLK_SCLK_TSADC>;
clock-names = "adc", "sclk";

vdd-supply = <&buck5_reg>;
--
2.17.1

2019-10-06 10:02:40

by Jonathan Cameron

[permalink] [raw]
Subject: Re: [PATCH 1/4] dt-bindings: samsung: Indent examples with four spaces

On Wed, 2 Oct 2019 18:07:41 +0200
Krzysztof Kozlowski <[email protected]> wrote:

> Change the indentation of examples used in json-schema bindings from two
> to four spaces as this makes the code easier to read and seems to be
> preferred in other files.
>

I'm assuming Rob will pick these up given they span multiple subsystems.

> Signed-off-by: Krzysztof Kozlowski <[email protected]>

Acked-by: Jonathan Cameron <[email protected]> # for iio

> ---
> .../bindings/arm/samsung/exynos-chipid.yaml | 4 +-
> .../bindings/iio/adc/samsung,exynos-adc.yaml | 64 +++++++++----------
> .../bindings/power/reset/syscon-poweroff.yaml | 8 +--
> .../bindings/power/reset/syscon-reboot.yaml | 8 +--
> .../devicetree/bindings/rtc/s3c-rtc.yaml | 12 ++--
> 5 files changed, 48 insertions(+), 48 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml b/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml
> index 9c573ad7dc7d..ce40adabb4e8 100644
> --- a/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml
> +++ b/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml
> @@ -20,6 +20,6 @@ properties:
> examples:
> - |
> chipid@10000000 {
> - compatible = "samsung,exynos4210-chipid";
> - reg = <0x10000000 0x100>;
> + compatible = "samsung,exynos4210-chipid";
> + reg = <0x10000000 0x100>;
> };
> diff --git a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> index b4c6c26681d9..a0a9b909ac40 100644
> --- a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> @@ -112,40 +112,40 @@ allOf:
> examples:
> - |
> adc: adc@12d10000 {
> - compatible = "samsung,exynos-adc-v1";
> - reg = <0x12d10000 0x100>;
> - interrupts = <0 106 0>;
> - #io-channel-cells = <1>;
> - io-channel-ranges;
> -
> - clocks = <&clock 303>;
> - clock-names = "adc";
> -
> - vdd-supply = <&buck5_reg>;
> - samsung,syscon-phandle = <&pmu_system_controller>;
> -
> - /* NTC thermistor is a hwmon device */
> - ncp15wb473@0 {
> - compatible = "murata,ncp15wb473";
> - pullup-uv = <1800000>;
> - pullup-ohm = <47000>;
> - pulldown-ohm = <0>;
> - io-channels = <&adc 4>;
> - };
> + compatible = "samsung,exynos-adc-v1";
> + reg = <0x12d10000 0x100>;
> + interrupts = <0 106 0>;
> + #io-channel-cells = <1>;
> + io-channel-ranges;
> +
> + clocks = <&clock 303>;
> + clock-names = "adc";
> +
> + vdd-supply = <&buck5_reg>;
> + samsung,syscon-phandle = <&pmu_system_controller>;
> +
> + /* NTC thermistor is a hwmon device */
> + ncp15wb473@0 {
> + compatible = "murata,ncp15wb473";
> + pullup-uv = <1800000>;
> + pullup-ohm = <47000>;
> + pulldown-ohm = <0>;
> + io-channels = <&adc 4>;
> + };
> };
>
> - |
> adc@126c0000 {
> - compatible = "samsung,exynos3250-adc";
> - reg = <0x126C0000 0x100>;
> - interrupts = <0 137 0>;
> - #io-channel-cells = <1>;
> - io-channel-ranges;
> -
> - clocks = <&cmu 0>, // CLK_TSADC
> - <&cmu 1>; // CLK_SCLK_TSADC
> - clock-names = "adc", "sclk";
> -
> - vdd-supply = <&buck5_reg>;
> - samsung,syscon-phandle = <&pmu_system_controller>;
> + compatible = "samsung,exynos3250-adc";
> + reg = <0x126C0000 0x100>;
> + interrupts = <0 137 0>;
> + #io-channel-cells = <1>;
> + io-channel-ranges;
> +
> + clocks = <&cmu 0>, // CLK_TSADC
> + <&cmu 1>; // CLK_SCLK_TSADC
> + clock-names = "adc", "sclk";
> +
> + vdd-supply = <&buck5_reg>;
> + samsung,syscon-phandle = <&pmu_system_controller>;
> };
> diff --git a/Documentation/devicetree/bindings/power/reset/syscon-poweroff.yaml b/Documentation/devicetree/bindings/power/reset/syscon-poweroff.yaml
> index fb812937b534..520e07e6f21b 100644
> --- a/Documentation/devicetree/bindings/power/reset/syscon-poweroff.yaml
> +++ b/Documentation/devicetree/bindings/power/reset/syscon-poweroff.yaml
> @@ -53,8 +53,8 @@ allOf:
> examples:
> - |
> poweroff {
> - compatible = "syscon-poweroff";
> - regmap = <&regmapnode>;
> - offset = <0x0>;
> - mask = <0x7a>;
> + compatible = "syscon-poweroff";
> + regmap = <&regmapnode>;
> + offset = <0x0>;
> + mask = <0x7a>;
> };
> diff --git a/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml b/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml
> index a7920f5eef79..d38006b1f1f4 100644
> --- a/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml
> +++ b/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml
> @@ -53,8 +53,8 @@ allOf:
> examples:
> - |
> reboot {
> - compatible = "syscon-reboot";
> - regmap = <&regmapnode>;
> - offset = <0x0>;
> - mask = <0x1>;
> + compatible = "syscon-reboot";
> + regmap = <&regmapnode>;
> + offset = <0x0>;
> + mask = <0x1>;
> };
> diff --git a/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml b/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
> index 951a6a485709..95570d7e19eb 100644
> --- a/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
> +++ b/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
> @@ -76,10 +76,10 @@ allOf:
> examples:
> - |
> rtc@10070000 {
> - compatible = "samsung,s3c6410-rtc";
> - reg = <0x10070000 0x100>;
> - interrupts = <0 44 4>, <0 45 4>;
> - clocks = <&clock 0>, // CLK_RTC
> - <&s2mps11_osc 0>; // S2MPS11_CLK_AP
> - clock-names = "rtc", "rtc_src";
> + compatible = "samsung,s3c6410-rtc";
> + reg = <0x10070000 0x100>;
> + interrupts = <0 44 4>, <0 45 4>;
> + clocks = <&clock 0>, // CLK_RTC
> + <&s2mps11_osc 0>; // S2MPS11_CLK_AP
> + clock-names = "rtc", "rtc_src";
> };

2019-10-06 10:05:58

by Jonathan Cameron

[permalink] [raw]
Subject: Re: [PATCH 4/4] dt-bindings: iio: adc: exynos: Use defines instead of clock numbers

On Wed, 2 Oct 2019 18:07:44 +0200
Krzysztof Kozlowski <[email protected]> wrote:

> Make the examples in Exynos ADC bindings more readable and bring them
> closer to real DTS by using defines for clocks.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>

Acked-by: Jonathan Cameron <[email protected]>

> ---
> .../devicetree/bindings/iio/adc/samsung,exynos-adc.yaml | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> index a0a9b909ac40..a3010e7ea051 100644
> --- a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> @@ -135,6 +135,8 @@ examples:
> };
>
> - |
> + #include <dt-bindings/clock/exynos3250.h>
> +
> adc@126c0000 {
> compatible = "samsung,exynos3250-adc";
> reg = <0x126C0000 0x100>;
> @@ -142,8 +144,8 @@ examples:
> #io-channel-cells = <1>;
> io-channel-ranges;
>
> - clocks = <&cmu 0>, // CLK_TSADC
> - <&cmu 1>; // CLK_SCLK_TSADC
> + clocks = <&cmu CLK_TSADC>,
> + <&cmu CLK_SCLK_TSADC>;
> clock-names = "adc", "sclk";
>
> vdd-supply = <&buck5_reg>;

2019-10-07 13:19:22

by Alexandre Belloni

[permalink] [raw]
Subject: Re: [PATCH 2/4] dt-bindings: rtc: s3c: Use defines instead of clock numbers

On 02/10/2019 18:07:42+0200, Krzysztof Kozlowski wrote:
> Make the examples in S3C RTC bindings more readable and bring them
> closer to real DTS by using defines for clocks.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
Acked-by: Alexandre Belloni <[email protected]>

> ---
> Documentation/devicetree/bindings/rtc/s3c-rtc.yaml | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml b/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
> index 95570d7e19eb..4d91cdc9b998 100644
> --- a/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
> +++ b/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
> @@ -75,11 +75,14 @@ allOf:
>
> examples:
> - |
> + #include <dt-bindings/clock/exynos5420.h>
> + #include <dt-bindings/clock/samsung,s2mps11.h>
> +
> rtc@10070000 {
> compatible = "samsung,s3c6410-rtc";
> reg = <0x10070000 0x100>;
> interrupts = <0 44 4>, <0 45 4>;
> - clocks = <&clock 0>, // CLK_RTC
> - <&s2mps11_osc 0>; // S2MPS11_CLK_AP
> + clocks = <&clock CLK_RTC>,
> + <&s2mps11_osc S2MPS11_CLK_AP>;
> clock-names = "rtc", "rtc_src";
> };
> --
> 2.17.1
>

--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

2019-10-07 13:19:45

by Alexandre Belloni

[permalink] [raw]
Subject: Re: [PATCH 3/4] dt-bindings: rtc: s3c: Include generic dt-schema bindings

On 02/10/2019 18:07:43+0200, Krzysztof Kozlowski wrote:
> Include the generic rtc.yaml bindings in Samsung S3C RTC bindings. This
> brings the requirement of proper node names and adds parsing of
> additional properties.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
Acked-by: Alexandre Belloni <[email protected]>

> ---
> Documentation/devicetree/bindings/rtc/s3c-rtc.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml b/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
> index 4d91cdc9b998..76bbf8b7555b 100644
> --- a/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
> +++ b/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
> @@ -48,6 +48,7 @@ properties:
> maxItems: 2
>
> allOf:
> + - $ref: rtc.yaml#
> - if:
> properties:
> compatible:
> --
> 2.17.1
>

--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

2019-10-07 13:20:54

by Alexandre Belloni

[permalink] [raw]
Subject: Re: [PATCH 1/4] dt-bindings: samsung: Indent examples with four spaces

On 02/10/2019 18:07:41+0200, Krzysztof Kozlowski wrote:
> Change the indentation of examples used in json-schema bindings from two
> to four spaces as this makes the code easier to read and seems to be
> preferred in other files.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
Acked-by: Alexandre Belloni <[email protected]>

> ---
> .../bindings/arm/samsung/exynos-chipid.yaml | 4 +-
> .../bindings/iio/adc/samsung,exynos-adc.yaml | 64 +++++++++----------
> .../bindings/power/reset/syscon-poweroff.yaml | 8 +--
> .../bindings/power/reset/syscon-reboot.yaml | 8 +--
> .../devicetree/bindings/rtc/s3c-rtc.yaml | 12 ++--
> 5 files changed, 48 insertions(+), 48 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml b/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml
> index 9c573ad7dc7d..ce40adabb4e8 100644
> --- a/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml
> +++ b/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml
> @@ -20,6 +20,6 @@ properties:
> examples:
> - |
> chipid@10000000 {
> - compatible = "samsung,exynos4210-chipid";
> - reg = <0x10000000 0x100>;
> + compatible = "samsung,exynos4210-chipid";
> + reg = <0x10000000 0x100>;
> };
> diff --git a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> index b4c6c26681d9..a0a9b909ac40 100644
> --- a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> @@ -112,40 +112,40 @@ allOf:
> examples:
> - |
> adc: adc@12d10000 {
> - compatible = "samsung,exynos-adc-v1";
> - reg = <0x12d10000 0x100>;
> - interrupts = <0 106 0>;
> - #io-channel-cells = <1>;
> - io-channel-ranges;
> -
> - clocks = <&clock 303>;
> - clock-names = "adc";
> -
> - vdd-supply = <&buck5_reg>;
> - samsung,syscon-phandle = <&pmu_system_controller>;
> -
> - /* NTC thermistor is a hwmon device */
> - ncp15wb473@0 {
> - compatible = "murata,ncp15wb473";
> - pullup-uv = <1800000>;
> - pullup-ohm = <47000>;
> - pulldown-ohm = <0>;
> - io-channels = <&adc 4>;
> - };
> + compatible = "samsung,exynos-adc-v1";
> + reg = <0x12d10000 0x100>;
> + interrupts = <0 106 0>;
> + #io-channel-cells = <1>;
> + io-channel-ranges;
> +
> + clocks = <&clock 303>;
> + clock-names = "adc";
> +
> + vdd-supply = <&buck5_reg>;
> + samsung,syscon-phandle = <&pmu_system_controller>;
> +
> + /* NTC thermistor is a hwmon device */
> + ncp15wb473@0 {
> + compatible = "murata,ncp15wb473";
> + pullup-uv = <1800000>;
> + pullup-ohm = <47000>;
> + pulldown-ohm = <0>;
> + io-channels = <&adc 4>;
> + };
> };
>
> - |
> adc@126c0000 {
> - compatible = "samsung,exynos3250-adc";
> - reg = <0x126C0000 0x100>;
> - interrupts = <0 137 0>;
> - #io-channel-cells = <1>;
> - io-channel-ranges;
> -
> - clocks = <&cmu 0>, // CLK_TSADC
> - <&cmu 1>; // CLK_SCLK_TSADC
> - clock-names = "adc", "sclk";
> -
> - vdd-supply = <&buck5_reg>;
> - samsung,syscon-phandle = <&pmu_system_controller>;
> + compatible = "samsung,exynos3250-adc";
> + reg = <0x126C0000 0x100>;
> + interrupts = <0 137 0>;
> + #io-channel-cells = <1>;
> + io-channel-ranges;
> +
> + clocks = <&cmu 0>, // CLK_TSADC
> + <&cmu 1>; // CLK_SCLK_TSADC
> + clock-names = "adc", "sclk";
> +
> + vdd-supply = <&buck5_reg>;
> + samsung,syscon-phandle = <&pmu_system_controller>;
> };
> diff --git a/Documentation/devicetree/bindings/power/reset/syscon-poweroff.yaml b/Documentation/devicetree/bindings/power/reset/syscon-poweroff.yaml
> index fb812937b534..520e07e6f21b 100644
> --- a/Documentation/devicetree/bindings/power/reset/syscon-poweroff.yaml
> +++ b/Documentation/devicetree/bindings/power/reset/syscon-poweroff.yaml
> @@ -53,8 +53,8 @@ allOf:
> examples:
> - |
> poweroff {
> - compatible = "syscon-poweroff";
> - regmap = <&regmapnode>;
> - offset = <0x0>;
> - mask = <0x7a>;
> + compatible = "syscon-poweroff";
> + regmap = <&regmapnode>;
> + offset = <0x0>;
> + mask = <0x7a>;
> };
> diff --git a/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml b/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml
> index a7920f5eef79..d38006b1f1f4 100644
> --- a/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml
> +++ b/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml
> @@ -53,8 +53,8 @@ allOf:
> examples:
> - |
> reboot {
> - compatible = "syscon-reboot";
> - regmap = <&regmapnode>;
> - offset = <0x0>;
> - mask = <0x1>;
> + compatible = "syscon-reboot";
> + regmap = <&regmapnode>;
> + offset = <0x0>;
> + mask = <0x1>;
> };
> diff --git a/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml b/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
> index 951a6a485709..95570d7e19eb 100644
> --- a/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
> +++ b/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
> @@ -76,10 +76,10 @@ allOf:
> examples:
> - |
> rtc@10070000 {
> - compatible = "samsung,s3c6410-rtc";
> - reg = <0x10070000 0x100>;
> - interrupts = <0 44 4>, <0 45 4>;
> - clocks = <&clock 0>, // CLK_RTC
> - <&s2mps11_osc 0>; // S2MPS11_CLK_AP
> - clock-names = "rtc", "rtc_src";
> + compatible = "samsung,s3c6410-rtc";
> + reg = <0x10070000 0x100>;
> + interrupts = <0 44 4>, <0 45 4>;
> + clocks = <&clock 0>, // CLK_RTC
> + <&s2mps11_osc 0>; // S2MPS11_CLK_AP
> + clock-names = "rtc", "rtc_src";
> };
> --
> 2.17.1
>

--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

2019-10-10 16:49:43

by Sebastian Reichel

[permalink] [raw]
Subject: Re: [PATCH 1/4] dt-bindings: samsung: Indent examples with four spaces

Hi,

On Wed, Oct 02, 2019 at 06:07:41PM +0200, Krzysztof Kozlowski wrote:
> Change the indentation of examples used in json-schema bindings from two
> to four spaces as this makes the code easier to read and seems to be
> preferred in other files.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>

Acked-by: Sebastian Reichel <[email protected]> # for power/reset

-- Sebastian

> ---
> .../bindings/arm/samsung/exynos-chipid.yaml | 4 +-
> .../bindings/iio/adc/samsung,exynos-adc.yaml | 64 +++++++++----------
> .../bindings/power/reset/syscon-poweroff.yaml | 8 +--
> .../bindings/power/reset/syscon-reboot.yaml | 8 +--
> .../devicetree/bindings/rtc/s3c-rtc.yaml | 12 ++--
> 5 files changed, 48 insertions(+), 48 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml b/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml
> index 9c573ad7dc7d..ce40adabb4e8 100644
> --- a/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml
> +++ b/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml
> @@ -20,6 +20,6 @@ properties:
> examples:
> - |
> chipid@10000000 {
> - compatible = "samsung,exynos4210-chipid";
> - reg = <0x10000000 0x100>;
> + compatible = "samsung,exynos4210-chipid";
> + reg = <0x10000000 0x100>;
> };
> diff --git a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> index b4c6c26681d9..a0a9b909ac40 100644
> --- a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> @@ -112,40 +112,40 @@ allOf:
> examples:
> - |
> adc: adc@12d10000 {
> - compatible = "samsung,exynos-adc-v1";
> - reg = <0x12d10000 0x100>;
> - interrupts = <0 106 0>;
> - #io-channel-cells = <1>;
> - io-channel-ranges;
> -
> - clocks = <&clock 303>;
> - clock-names = "adc";
> -
> - vdd-supply = <&buck5_reg>;
> - samsung,syscon-phandle = <&pmu_system_controller>;
> -
> - /* NTC thermistor is a hwmon device */
> - ncp15wb473@0 {
> - compatible = "murata,ncp15wb473";
> - pullup-uv = <1800000>;
> - pullup-ohm = <47000>;
> - pulldown-ohm = <0>;
> - io-channels = <&adc 4>;
> - };
> + compatible = "samsung,exynos-adc-v1";
> + reg = <0x12d10000 0x100>;
> + interrupts = <0 106 0>;
> + #io-channel-cells = <1>;
> + io-channel-ranges;
> +
> + clocks = <&clock 303>;
> + clock-names = "adc";
> +
> + vdd-supply = <&buck5_reg>;
> + samsung,syscon-phandle = <&pmu_system_controller>;
> +
> + /* NTC thermistor is a hwmon device */
> + ncp15wb473@0 {
> + compatible = "murata,ncp15wb473";
> + pullup-uv = <1800000>;
> + pullup-ohm = <47000>;
> + pulldown-ohm = <0>;
> + io-channels = <&adc 4>;
> + };
> };
>
> - |
> adc@126c0000 {
> - compatible = "samsung,exynos3250-adc";
> - reg = <0x126C0000 0x100>;
> - interrupts = <0 137 0>;
> - #io-channel-cells = <1>;
> - io-channel-ranges;
> -
> - clocks = <&cmu 0>, // CLK_TSADC
> - <&cmu 1>; // CLK_SCLK_TSADC
> - clock-names = "adc", "sclk";
> -
> - vdd-supply = <&buck5_reg>;
> - samsung,syscon-phandle = <&pmu_system_controller>;
> + compatible = "samsung,exynos3250-adc";
> + reg = <0x126C0000 0x100>;
> + interrupts = <0 137 0>;
> + #io-channel-cells = <1>;
> + io-channel-ranges;
> +
> + clocks = <&cmu 0>, // CLK_TSADC
> + <&cmu 1>; // CLK_SCLK_TSADC
> + clock-names = "adc", "sclk";
> +
> + vdd-supply = <&buck5_reg>;
> + samsung,syscon-phandle = <&pmu_system_controller>;
> };
> diff --git a/Documentation/devicetree/bindings/power/reset/syscon-poweroff.yaml b/Documentation/devicetree/bindings/power/reset/syscon-poweroff.yaml
> index fb812937b534..520e07e6f21b 100644
> --- a/Documentation/devicetree/bindings/power/reset/syscon-poweroff.yaml
> +++ b/Documentation/devicetree/bindings/power/reset/syscon-poweroff.yaml
> @@ -53,8 +53,8 @@ allOf:
> examples:
> - |
> poweroff {
> - compatible = "syscon-poweroff";
> - regmap = <&regmapnode>;
> - offset = <0x0>;
> - mask = <0x7a>;
> + compatible = "syscon-poweroff";
> + regmap = <&regmapnode>;
> + offset = <0x0>;
> + mask = <0x7a>;
> };
> diff --git a/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml b/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml
> index a7920f5eef79..d38006b1f1f4 100644
> --- a/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml
> +++ b/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml
> @@ -53,8 +53,8 @@ allOf:
> examples:
> - |
> reboot {
> - compatible = "syscon-reboot";
> - regmap = <&regmapnode>;
> - offset = <0x0>;
> - mask = <0x1>;
> + compatible = "syscon-reboot";
> + regmap = <&regmapnode>;
> + offset = <0x0>;
> + mask = <0x1>;
> };
> diff --git a/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml b/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
> index 951a6a485709..95570d7e19eb 100644
> --- a/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
> +++ b/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
> @@ -76,10 +76,10 @@ allOf:
> examples:
> - |
> rtc@10070000 {
> - compatible = "samsung,s3c6410-rtc";
> - reg = <0x10070000 0x100>;
> - interrupts = <0 44 4>, <0 45 4>;
> - clocks = <&clock 0>, // CLK_RTC
> - <&s2mps11_osc 0>; // S2MPS11_CLK_AP
> - clock-names = "rtc", "rtc_src";
> + compatible = "samsung,s3c6410-rtc";
> + reg = <0x10070000 0x100>;
> + interrupts = <0 44 4>, <0 45 4>;
> + clocks = <&clock 0>, // CLK_RTC
> + <&s2mps11_osc 0>; // S2MPS11_CLK_AP
> + clock-names = "rtc", "rtc_src";
> };
> --
> 2.17.1
>

Attachments:
(No filename) (6.19 kB)
 signature.asc (849.00 B)
 Download all attachments

2019-10-15 21:17:47

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH 1/4] dt-bindings: samsung: Indent examples with four spaces

On Wed, 2 Oct 2019 18:07:41 +0200, Krzysztof Kozlowski wrote:
> Change the indentation of examples used in json-schema bindings from two
> to four spaces as this makes the code easier to read and seems to be
> preferred in other files.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../bindings/arm/samsung/exynos-chipid.yaml | 4 +-
> .../bindings/iio/adc/samsung,exynos-adc.yaml | 64 +++++++++----------
> .../bindings/power/reset/syscon-poweroff.yaml | 8 +--
> .../bindings/power/reset/syscon-reboot.yaml | 8 +--
> .../devicetree/bindings/rtc/s3c-rtc.yaml | 12 ++--
> 5 files changed, 48 insertions(+), 48 deletions(-)
>

Applied, thanks.

Rob

2019-10-15 21:17:54

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH 2/4] dt-bindings: rtc: s3c: Use defines instead of clock numbers

On Wed, 2 Oct 2019 18:07:42 +0200, Krzysztof Kozlowski wrote:
> Make the examples in S3C RTC bindings more readable and bring them
> closer to real DTS by using defines for clocks.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> Documentation/devicetree/bindings/rtc/s3c-rtc.yaml | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>

Applied, thanks.

Rob

2019-10-15 21:17:57

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH 3/4] dt-bindings: rtc: s3c: Include generic dt-schema bindings

On Wed, 2 Oct 2019 18:07:43 +0200, Krzysztof Kozlowski wrote:
> Include the generic rtc.yaml bindings in Samsung S3C RTC bindings. This
> brings the requirement of proper node names and adds parsing of
> additional properties.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> Documentation/devicetree/bindings/rtc/s3c-rtc.yaml | 1 +
> 1 file changed, 1 insertion(+)
>

Applied, thanks.

Rob

2019-10-15 21:18:01

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH 4/4] dt-bindings: iio: adc: exynos: Use defines instead of clock numbers

On Wed, 2 Oct 2019 18:07:44 +0200, Krzysztof Kozlowski wrote:
> Make the examples in Exynos ADC bindings more readable and bring them
> closer to real DTS by using defines for clocks.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../devicetree/bindings/iio/adc/samsung,exynos-adc.yaml | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>

Applied, thanks.

Rob