2019-09-29 03:26:33

by Vivek Unune

Subject: [PATCH] arm64: dts: rockchip: Fix usb-c on Hugsun X99 TV Box

Fix usb-c on X99 TV Box. Tested with armbian w/ kernel 5.3

Signed-off-by: Vivek Unune <[email protected]>
---
arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts b/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
index 0d1f5f9a0de9..c133e8d64b2a 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
@@ -644,7 +644,7 @@
status = "okay";

u2phy0_host: host-port {
- phy-supply = <&vcc5v0_host>;
+ phy-supply = <&vcc5v0_typec>;
status = "okay";
};

@@ -712,7 +712,7 @@

&usbdrd_dwc3_0 {
status = "okay";
- dr_mode = "otg";
+ dr_mode = "host";
};

&usbdrd3_1 {
--
2.17.1

2019-09-29 23:47:02

by Vivek Unune

Subject: Re: [PATCH] arm64: dts: rockchip: Fix usb-c on Hugsun X99 TV Box

On Sun, Sep 29, 2019 at 01:22:17PM +0200, Vicente Bergas wrote:
> On Sunday, September 29, 2019 5:22:30 AM CEST, Vivek Unune wrote:
> > Fix usb-c on X99 TV Box. Tested with armbian w/ kernel 5.3
> >
> > Signed-off-by: Vivek Unune <[email protected]>
> > ---
> > arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
> > b/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
> > index 0d1f5f9a0de9..c133e8d64b2a 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
> > +++ b/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
> > @@ -644,7 +644,7 @@
> > status = "okay";
> > u2phy0_host: host-port {
> > - phy-supply = <&vcc5v0_host>;
> > + phy-supply = <&vcc5v0_typec>;
> > status = "okay";
> > };
> > @@ -712,7 +712,7 @@
> > &usbdrd_dwc3_0 {
> > status = "okay";
> > - dr_mode = "otg";
> > + dr_mode = "host";
> > };
> > &usbdrd3_1 {
>
> Hi Vivek,
>
> which is the relationship of your patch and this commit:
>
> e1d9149e8389f1690cdd4e4056766dd26488a0fe
> arm64: dts: rockchip: Fix USB3 Type-C on rk3399-sapphire
>
> with respect to this other commit:
>
> c09b73cfac2a9317f1104169045c519c6021aa1d
> usb: dwc3: don't set gadget->is_otg flag
>
> ?
>
> I did not test reverting e1d9149e since c09b73cf was applied.
>
> Regards,
> Vicen?.
>

Hi Vicen?,

Indeed, I was motivated by e1d9149e ("arm64: dts: rockchip: Fix USB3
Type-C on rk3399-sapphire"). X99 TV box showed exact same symptoms
with usb-c port. After applying the fix, it worked.

I was not aware of c09b73cf ("usb: dwc3: don't set gadget->is_otg
flag") and it will be interesting to test it. This might render
my fix unecessary.

Thanks,

Vivek

2019-10-04 21:48:39

by Heiko Stuebner

Subject: Re: [PATCH] arm64: dts: rockchip: Fix usb-c on Hugsun X99 TV Box

Hi Vivek,

Am Montag, 30. September 2019, 01:46:15 CEST schrieb Vivek Unune:
> On Sun, Sep 29, 2019 at 01:22:17PM +0200, Vicente Bergas wrote:
> > On Sunday, September 29, 2019 5:22:30 AM CEST, Vivek Unune wrote:
> > > Fix usb-c on X99 TV Box. Tested with armbian w/ kernel 5.3
> > >
> > > Signed-off-by: Vivek Unune <[email protected]>
> > > ---
> > > arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
> > > b/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
> > > index 0d1f5f9a0de9..c133e8d64b2a 100644
> > > --- a/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
> > > +++ b/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
> > > @@ -644,7 +644,7 @@
> > > status = "okay";
> > > u2phy0_host: host-port {
> > > - phy-supply = <&vcc5v0_host>;
> > > + phy-supply = <&vcc5v0_typec>;
> > > status = "okay";
> > > };
> > > @@ -712,7 +712,7 @@
> > > &usbdrd_dwc3_0 {
> > > status = "okay";
> > > - dr_mode = "otg";
> > > + dr_mode = "host";
> > > };
> > > &usbdrd3_1 {
> >
> > Hi Vivek,
> >
> > which is the relationship of your patch and this commit:
> >
> > e1d9149e8389f1690cdd4e4056766dd26488a0fe
> > arm64: dts: rockchip: Fix USB3 Type-C on rk3399-sapphire
> >
> > with respect to this other commit:
> >
> > c09b73cfac2a9317f1104169045c519c6021aa1d
> > usb: dwc3: don't set gadget->is_otg flag
> >
> > ?
> >
> > I did not test reverting e1d9149e since c09b73cf was applied.
> >
> > Regards,
> > Vicen?.
> >
>
> Hi Vicen?,
>
> Indeed, I was motivated by e1d9149e ("arm64: dts: rockchip: Fix USB3
> Type-C on rk3399-sapphire"). X99 TV box showed exact same symptoms
> with usb-c port. After applying the fix, it worked.
>
> I was not aware of c09b73cf ("usb: dwc3: don't set gadget->is_otg
> flag") and it will be interesting to test it. This might render
> my fix unecessary.

So I'll let this patch sit here for now.
Once you've done the testing, can you please respond with the
result (both positive and negative results please).

Thanks
Heiko

2019-10-05 00:53:58

by Vivek Unune

Subject: Re: [PATCH] arm64: dts: rockchip: Fix usb-c on Hugsun X99 TV Box

On Fri, Oct 04, 2019 at 11:45:08PM +0200, Heiko Stuebner wrote:
> Hi Vivek,
>
> Am Montag, 30. September 2019, 01:46:15 CEST schrieb Vivek Unune:
> > On Sun, Sep 29, 2019 at 01:22:17PM +0200, Vicente Bergas wrote:
> > > On Sunday, September 29, 2019 5:22:30 AM CEST, Vivek Unune wrote:
> > > > Fix usb-c on X99 TV Box. Tested with armbian w/ kernel 5.3
> > > >
> > > > Signed-off-by: Vivek Unune <[email protected]>
> > > > ---
> > > > arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts | 4 ++--
> > > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
> > > > b/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
> > > > index 0d1f5f9a0de9..c133e8d64b2a 100644
> > > > --- a/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
> > > > +++ b/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
> > > > @@ -644,7 +644,7 @@
> > > > status = "okay";
> > > > u2phy0_host: host-port {
> > > > - phy-supply = <&vcc5v0_host>;
> > > > + phy-supply = <&vcc5v0_typec>;
> > > > status = "okay";
> > > > };
> > > > @@ -712,7 +712,7 @@
> > > > &usbdrd_dwc3_0 {
> > > > status = "okay";
> > > > - dr_mode = "otg";
> > > > + dr_mode = "host";
> > > > };
> > > > &usbdrd3_1 {
> > >
> > > Hi Vivek,
> > >
> > > which is the relationship of your patch and this commit:
> > >
> > > e1d9149e8389f1690cdd4e4056766dd26488a0fe
> > > arm64: dts: rockchip: Fix USB3 Type-C on rk3399-sapphire
> > >
> > > with respect to this other commit:
> > >
> > > c09b73cfac2a9317f1104169045c519c6021aa1d
> > > usb: dwc3: don't set gadget->is_otg flag
> > >
> > > ?
> > >
> > > I did not test reverting e1d9149e since c09b73cf was applied.
> > >
> > > Regards,
> > > Vicen?.
> > >
> >
> > Hi Vicen?,
> >
> > Indeed, I was motivated by e1d9149e ("arm64: dts: rockchip: Fix USB3
> > Type-C on rk3399-sapphire"). X99 TV box showed exact same symptoms
> > with usb-c port. After applying the fix, it worked.
> >
> > I was not aware of c09b73cf ("usb: dwc3: don't set gadget->is_otg
> > flag") and it will be interesting to test it. This might render
> > my fix unecessary.
>
> So I'll let this patch sit here for now.
> Once you've done the testing, can you please respond with the
> result (both positive and negative results please).
>
> Thanks
> Heiko
>
>

Hi Heiko,

I tested the c09b73cf patch without modifying exsisting dts. I can confirm
that that patch doesn't work for me. No usb-c devices were recognized.

Vicen? - were you able to test it?

As soon as I apply dts patch, usb-c devices are recognized.

Thanks,

Vivek

2019-10-10 21:32:03

by Heiko Stuebner

Subject: Re: [PATCH] arm64: dts: rockchip: Fix usb-c on Hugsun X99 TV Box

Am Sonntag, 29. September 2019, 05:22:30 CEST schrieb Vivek Unune:
> Fix usb-c on X99 TV Box. Tested with armbian w/ kernel 5.3
>
> Signed-off-by: Vivek Unune <[email protected]>

applied as fix for 5.4

Thanks
Heiko