2019-09-12 02:56:51

by Guido Günther

Subject: [PATCH v2 1/2] dts: arm64: imx8mq: Enable gpu passive throttling

Temperature and hysteresis were picked after the CPU.

Signed-off-by: Guido Günther <[email protected]>
---
arch/arm64/boot/dts/freescale/imx8mq.dtsi | 15 +++++++++++++++
1 file changed, 15 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
index 4fdd60f2c51e..5023a0e5068d 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
@@ -235,12 +235,26 @@
thermal-sensors = <&tmu 1>;

trips {
+ gpu_alert: gpu-alert {
+ temperature = <80000>;
+ hysteresis = <2000>;
+ type = "passive";
+ };
+
gpu-crit {
temperature = <90000>;
hysteresis = <2000>;
type = "critical";
};
};
+
+ cooling-maps {
+ map0 {
+ trip = <&gpu_alert>;
+ cooling-device =
+ <&gpu THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
+ };
+ };
};

vpu-thermal {
@@ -912,6 +926,7 @@
<&clk IMX8MQ_CLK_GPU_AXI>,
<&clk IMX8MQ_CLK_GPU_AHB>;
clock-names = "core", "shader", "bus", "reg";
+ #cooling-cells = <2>;
assigned-clocks = <&clk IMX8MQ_CLK_GPU_CORE_SRC>,
<&clk IMX8MQ_CLK_GPU_SHADER_SRC>,
<&clk IMX8MQ_CLK_GPU_AXI>,
--
2.23.0.rc1

2019-09-16 20:48:26

by Lucas Stach

Subject: Re: [PATCH v2 1/2] dts: arm64: imx8mq: Enable gpu passive throttling

On Mi, 2019-09-11 at 19:40 -0700, Guido Günther wrote:
> Temperature and hysteresis were picked after the CPU.
>
> Signed-off-by: Guido Günther <[email protected]>

Reviewed-by: Lucas Stach <[email protected]>

> ---
> arch/arm64/boot/dts/freescale/imx8mq.dtsi | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index 4fdd60f2c51e..5023a0e5068d 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -235,12 +235,26 @@
> thermal-sensors = <&tmu 1>;
>
> trips {
> + gpu_alert: gpu-alert {
> + temperature = <80000>;
> + hysteresis = <2000>;
> + type = "passive";
> + };
> +
> gpu-crit {
> temperature = <90000>;
> hysteresis = <2000>;
> type = "critical";
> };
> };
> +
> + cooling-maps {
> + map0 {
> + trip = <&gpu_alert>;
> + cooling-device =
> + <&gpu THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> + };
> + };
> };
>
> vpu-thermal {
> @@ -912,6 +926,7 @@
> <&clk IMX8MQ_CLK_GPU_AXI>,
> <&clk IMX8MQ_CLK_GPU_AHB>;
> clock-names = "core", "shader", "bus", "reg";
> + #cooling-cells = <2>;
> assigned-clocks = <&clk IMX8MQ_CLK_GPU_CORE_SRC>,
> <&clk IMX8MQ_CLK_GPU_SHADER_SRC>,
> <&clk IMX8MQ_CLK_GPU_AXI>,

2019-10-06 08:12:06

by Shawn Guo

Subject: Re: [PATCH v2 1/2] dts: arm64: imx8mq: Enable gpu passive throttling

On Wed, Sep 11, 2019 at 07:40:35PM -0700, Guido G?nther wrote:
> Temperature and hysteresis were picked after the CPU.
>
> Signed-off-by: Guido G?nther <[email protected]>

The patch prefix should be 'arm64: dts: ...'

I fixed it up and applied the patch.

Shawn

> ---
> arch/arm64/boot/dts/freescale/imx8mq.dtsi | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index 4fdd60f2c51e..5023a0e5068d 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -235,12 +235,26 @@
> thermal-sensors = <&tmu 1>;
>
> trips {
> + gpu_alert: gpu-alert {
> + temperature = <80000>;
> + hysteresis = <2000>;
> + type = "passive";
> + };
> +
> gpu-crit {
> temperature = <90000>;
> hysteresis = <2000>;
> type = "critical";
> };
> };
> +
> + cooling-maps {
> + map0 {
> + trip = <&gpu_alert>;
> + cooling-device =
> + <&gpu THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> + };
> + };
> };
>
> vpu-thermal {
> @@ -912,6 +926,7 @@
> <&clk IMX8MQ_CLK_GPU_AXI>,
> <&clk IMX8MQ_CLK_GPU_AHB>;
> clock-names = "core", "shader", "bus", "reg";
> + #cooling-cells = <2>;
> assigned-clocks = <&clk IMX8MQ_CLK_GPU_CORE_SRC>,
> <&clk IMX8MQ_CLK_GPU_SHADER_SRC>,
> <&clk IMX8MQ_CLK_GPU_AXI>,
> --
> 2.23.0.rc1
>