2019-09-16 10:33:56

by Anson Huang

Subject: [PATCH] ARM: dts: imx7s: Correct GPT's ipg clock source

i.MX7S/D's GPT ipg clock should be from GPT clock root and
controlled by CCM's GPT CCGR, using correct clock source for
GPT ipg clock instead of IMX7D_CLK_DUMMY.

Signed-off-by: Anson Huang <[email protected]>
---
arch/arm/boot/dts/imx7s.dtsi | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi
index 710f850..e2e604d 100644
--- a/arch/arm/boot/dts/imx7s.dtsi
+++ b/arch/arm/boot/dts/imx7s.dtsi
@@ -448,7 +448,7 @@
compatible = "fsl,imx7d-gpt", "fsl,imx6sx-gpt";
reg = <0x302d0000 0x10000>;
interrupts = <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&clks IMX7D_CLK_DUMMY>,
+ clocks = <&clks IMX7D_GPT1_ROOT_CLK>,
<&clks IMX7D_GPT1_ROOT_CLK>;
clock-names = "ipg", "per";
};
@@ -457,7 +457,7 @@
compatible = "fsl,imx7d-gpt", "fsl,imx6sx-gpt";
reg = <0x302e0000 0x10000>;
interrupts = <GIC_SPI 54 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&clks IMX7D_CLK_DUMMY>,
+ clocks = <&clks IMX7D_GPT2_ROOT_CLK>,
<&clks IMX7D_GPT2_ROOT_CLK>;
clock-names = "ipg", "per";
status = "disabled";
@@ -467,7 +467,7 @@
compatible = "fsl,imx7d-gpt", "fsl,imx6sx-gpt";
reg = <0x302f0000 0x10000>;
interrupts = <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&clks IMX7D_CLK_DUMMY>,
+ clocks = <&clks IMX7D_GPT3_ROOT_CLK>,
<&clks IMX7D_GPT3_ROOT_CLK>;
clock-names = "ipg", "per";
status = "disabled";
@@ -477,7 +477,7 @@
compatible = "fsl,imx7d-gpt", "fsl,imx6sx-gpt";
reg = <0x30300000 0x10000>;
interrupts = <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&clks IMX7D_CLK_DUMMY>,
+ clocks = <&clks IMX7D_GPT4_ROOT_CLK>,
<&clks IMX7D_GPT4_ROOT_CLK>;
clock-names = "ipg", "per";
status = "disabled";
--
2.7.4

2019-10-06 08:35:42

by Shawn Guo

Subject: Re: [PATCH] ARM: dts: imx7s: Correct GPT's ipg clock source

On Mon, Sep 16, 2019 at 04:29:09PM +0800, Anson Huang wrote:
> i.MX7S/D's GPT ipg clock should be from GPT clock root and
> controlled by CCM's GPT CCGR, using correct clock source for
> GPT ipg clock instead of IMX7D_CLK_DUMMY.

So both 'ipg' and 'per' clock are coming from GPT root clock?

> Signed-off-by: Anson Huang <[email protected]>

It looks like a fix, so do we need a Fixes tag here?

Shawn

> ---
> arch/arm/boot/dts/imx7s.dtsi | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi
> index 710f850..e2e604d 100644
> --- a/arch/arm/boot/dts/imx7s.dtsi
> +++ b/arch/arm/boot/dts/imx7s.dtsi
> @@ -448,7 +448,7 @@
> compatible = "fsl,imx7d-gpt", "fsl,imx6sx-gpt";
> reg = <0x302d0000 0x10000>;
> interrupts = <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&clks IMX7D_CLK_DUMMY>,
> + clocks = <&clks IMX7D_GPT1_ROOT_CLK>,
> <&clks IMX7D_GPT1_ROOT_CLK>;
> clock-names = "ipg", "per";
> };
> @@ -457,7 +457,7 @@
> compatible = "fsl,imx7d-gpt", "fsl,imx6sx-gpt";
> reg = <0x302e0000 0x10000>;
> interrupts = <GIC_SPI 54 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&clks IMX7D_CLK_DUMMY>,
> + clocks = <&clks IMX7D_GPT2_ROOT_CLK>,
> <&clks IMX7D_GPT2_ROOT_CLK>;
> clock-names = "ipg", "per";
> status = "disabled";
> @@ -467,7 +467,7 @@
> compatible = "fsl,imx7d-gpt", "fsl,imx6sx-gpt";
> reg = <0x302f0000 0x10000>;
> interrupts = <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&clks IMX7D_CLK_DUMMY>,
> + clocks = <&clks IMX7D_GPT3_ROOT_CLK>,
> <&clks IMX7D_GPT3_ROOT_CLK>;
> clock-names = "ipg", "per";
> status = "disabled";
> @@ -477,7 +477,7 @@
> compatible = "fsl,imx7d-gpt", "fsl,imx6sx-gpt";
> reg = <0x30300000 0x10000>;
> interrupts = <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&clks IMX7D_CLK_DUMMY>,
> + clocks = <&clks IMX7D_GPT4_ROOT_CLK>,
> <&clks IMX7D_GPT4_ROOT_CLK>;
> clock-names = "ipg", "per";
> status = "disabled";
> --
> 2.7.4
>

2019-10-07 00:46:28

by Anson Huang

Subject: RE: [PATCH] ARM: dts: imx7s: Correct GPT's ipg clock source

Hi, Shawn

> On Mon, Sep 16, 2019 at 04:29:09PM +0800, Anson Huang wrote:
> > i.MX7S/D's GPT ipg clock should be from GPT clock root and controlled
> > by CCM's GPT CCGR, using correct clock source for GPT ipg clock
> > instead of IMX7D_CLK_DUMMY.
>
> So both 'ipg' and 'per' clock are coming from GPT root clock?

Yes.

>
> > Signed-off-by: Anson Huang <[email protected]>
>
> It looks like a fix, so do we need a Fixes tag here?

Sure, will add a fixes tag in V2.

Thanks,
Anson.