2019-10-08 07:21:20

by Yue Haibing

Subject: [PATCH -next] clk: imx: clk-pll14xx: Make two variables static

Fix sparse warnings:

drivers/clk/imx/clk-pll14xx.c:44:37:
warning: symbol 'imx_pll1416x_tbl' was not declared. Should it be static?
drivers/clk/imx/clk-pll14xx.c:57:37:
warning: symbol 'imx_pll1443x_tbl' was not declared. Should it be static?

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: YueHaibing <[email protected]>
---
drivers/clk/imx/clk-pll14xx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/imx/clk-pll14xx.c b/drivers/clk/imx/clk-pll14xx.c
index 7faad60..5c45819 100644
--- a/drivers/clk/imx/clk-pll14xx.c
+++ b/drivers/clk/imx/clk-pll14xx.c
@@ -41,7 +41,7 @@ struct clk_pll14xx {

#define to_clk_pll14xx(_hw) container_of(_hw, struct clk_pll14xx, hw)

-const struct imx_pll14xx_rate_table imx_pll1416x_tbl[] = {
+static const struct imx_pll14xx_rate_table imx_pll1416x_tbl[] = {
PLL_1416X_RATE(1800000000U, 225, 3, 0),
PLL_1416X_RATE(1600000000U, 200, 3, 0),
PLL_1416X_RATE(1500000000U, 375, 3, 1),
@@ -54,7 +54,7 @@ const struct imx_pll14xx_rate_table imx_pll1416x_tbl[] = {
PLL_1416X_RATE(600000000U, 300, 3, 2),
};

-const struct imx_pll14xx_rate_table imx_pll1443x_tbl[] = {
+static const struct imx_pll14xx_rate_table imx_pll1443x_tbl[] = {
PLL_1443X_RATE(650000000U, 325, 3, 2, 0),
PLL_1443X_RATE(594000000U, 198, 2, 2, 0),
PLL_1443X_RATE(393216000U, 262, 2, 3, 9437),
--
2.7.4

2019-10-08 08:03:24

by Anson Huang

Subject: RE: [PATCH -next] clk: imx: clk-pll14xx: Make two variables static

Hi,

> Fix sparse warnings:
>
> drivers/clk/imx/clk-pll14xx.c:44:37:
> warning: symbol 'imx_pll1416x_tbl' was not declared. Should it be static?
> drivers/clk/imx/clk-pll14xx.c:57:37:
> warning: symbol 'imx_pll1443x_tbl' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: YueHaibing <[email protected]>

Reviewed-by: Anson Huang <[email protected]>

I did NOT see this warning on my side, did you enable any special compile option?

Anson

> ---
> drivers/clk/imx/clk-pll14xx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/imx/clk-pll14xx.c b/drivers/clk/imx/clk-pll14xx.c index
> 7faad60..5c45819 100644
> --- a/drivers/clk/imx/clk-pll14xx.c
> +++ b/drivers/clk/imx/clk-pll14xx.c
> @@ -41,7 +41,7 @@ struct clk_pll14xx {
>
> #define to_clk_pll14xx(_hw) container_of(_hw, struct clk_pll14xx, hw)
>
> -const struct imx_pll14xx_rate_table imx_pll1416x_tbl[] = {
> +static const struct imx_pll14xx_rate_table imx_pll1416x_tbl[] = {
> PLL_1416X_RATE(1800000000U, 225, 3, 0),
> PLL_1416X_RATE(1600000000U, 200, 3, 0),
> PLL_1416X_RATE(1500000000U, 375, 3, 1), @@ -54,7 +54,7 @@
> const struct imx_pll14xx_rate_table imx_pll1416x_tbl[] = {
> PLL_1416X_RATE(600000000U, 300, 3, 2), };
>
> -const struct imx_pll14xx_rate_table imx_pll1443x_tbl[] = {
> +static const struct imx_pll14xx_rate_table imx_pll1443x_tbl[] = {
> PLL_1443X_RATE(650000000U, 325, 3, 2, 0),
> PLL_1443X_RATE(594000000U, 198, 2, 2, 0),
> PLL_1443X_RATE(393216000U, 262, 2, 3, 9437),
> --
> 2.7.4
>

2019-10-14 13:26:07

by Shawn Guo

Subject: Re: [PATCH -next] clk: imx: clk-pll14xx: Make two variables static

On Tue, Oct 08, 2019 at 03:19:08PM +0800, YueHaibing wrote:
> Fix sparse warnings:
>
> drivers/clk/imx/clk-pll14xx.c:44:37:
> warning: symbol 'imx_pll1416x_tbl' was not declared. Should it be static?
> drivers/clk/imx/clk-pll14xx.c:57:37:
> warning: symbol 'imx_pll1443x_tbl' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: YueHaibing <[email protected]>

Applied, thanks.