2019-10-10 09:01:57

by Andy Tang

Subject: [PATCH v2] arm64: dts: ls1028a: fix a compatible issue

The I2C multiplexer used on ls1028aqds is PCA9547, not PCA9847.
If the wrong compatible was used, this chip will not be able to
be probed correctly and hence fail to work.

Signed-off-by: Yuantian Tang <[email protected]>
---
v2:
- refine the description
arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
index 5e14e5a19744..f5da9e8b0d9d 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
@@ -107,7 +107,7 @@
status = "okay";

i2c-mux@77 {
- compatible = "nxp,pca9847";
+ compatible = "nxp,pca9547";
reg = <0x77>;
#address-cells = <1>;
#size-cells = <0>;
--
2.17.1

2019-10-10 22:34:12

by Leo Li

Subject: RE: [PATCH v2] arm64: dts: ls1028a: fix a compatible issue

> -----Original Message-----
> From: Yuantian Tang <[email protected]>
> Sent: Thursday, October 10, 2019 3:34 AM
> To: [email protected]
> Cc: Leo Li <[email protected]>; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected]; Andy Tang
> <[email protected]>
> Subject: [PATCH v2] arm64: dts: ls1028a: fix a compatible issue
>
> The I2C multiplexer used on ls1028aqds is PCA9547, not PCA9847.
> If the wrong compatible was used, this chip will not be able to be probed
> correctly and hence fail to work.
>
> Signed-off-by: Yuantian Tang <[email protected]>

Acked-by: Li Yang <[email protected]>

> ---
> v2:
> - refine the description
> arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> index 5e14e5a19744..f5da9e8b0d9d 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> @@ -107,7 +107,7 @@
> status = "okay";
>
> i2c-mux@77 {
> - compatible = "nxp,pca9847";
> + compatible = "nxp,pca9547";
> reg = <0x77>;
> #address-cells = <1>;
> #size-cells = <0>;
> --
> 2.17.1

2019-10-25 19:30:06

by Shawn Guo

Subject: Re: [PATCH v2] arm64: dts: ls1028a: fix a compatible issue

On Thu, Oct 10, 2019 at 04:33:34PM +0800, Yuantian Tang wrote:
> The I2C multiplexer used on ls1028aqds is PCA9547, not PCA9847.
> If the wrong compatible was used, this chip will not be able to
> be probed correctly and hence fail to work.
>
> Signed-off-by: Yuantian Tang <[email protected]>

Fixes: 8897f3255c9c ("arm64: dts: Add support for NXP LS1028A SoC")

I added the tag and applied the patch. Please take care of adding Fixes
tag for fixes in the future.

Shawn

> ---
> v2:
> - refine the description
> arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> index 5e14e5a19744..f5da9e8b0d9d 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> @@ -107,7 +107,7 @@
> status = "okay";
>
> i2c-mux@77 {
> - compatible = "nxp,pca9847";
> + compatible = "nxp,pca9547";
> reg = <0x77>;
> #address-cells = <1>;
> #size-cells = <0>;
> --
> 2.17.1
>