2019-10-10 02:12:34

by Andrew Jeffery

[permalink] [raw]
Subject: [PATCH v2 0/3] net: ftgmac100: Ungate RCLK for RMII on ASPEED MACs

Hello,

This series slightly extends the devicetree binding and driver for the
FTGMAC100 to describe an optional RMII RCLK gate in the clocks property.
Currently it's necessary for the kernel to ungate RCLK on the AST2600 in NCSI
configurations as u-boot does not yet support NCSI (which uses the
R(educed)MII).

v2:
* Clear up Reduced vs Reversed MII in the cover letter
* Mitigate anxiety in the commit message for 1/3
* Clarify that AST2500 is also affected in the clocks property description in
2/3
* Rework the error paths and update some comments in 3/3

v1 can be found here: https://lore.kernel.org/netdev/[email protected]/

Please review!

Andrew

Andrew Jeffery (3):
dt-bindings: net: ftgmac100: Document AST2600 compatible
dt-bindings: net: ftgmac100: Describe clock properties
net: ftgmac100: Ungate RCLK for RMII on ASPEED MACs

.../devicetree/bindings/net/ftgmac100.txt | 8 +++
drivers/net/ethernet/faraday/ftgmac100.c | 50 +++++++++++++++----
2 files changed, 48 insertions(+), 10 deletions(-)

--
2.20.1


2019-10-10 02:13:49

by Andrew Jeffery

[permalink] [raw]
Subject: [PATCH v2 1/3] dt-bindings: net: ftgmac100: Document AST2600 compatible

The AST2600 contains an FTGMAC100-compatible MAC, although the MDIO
controller previously embedded in the MAC has been moved out to a
dedicated MDIO block.

Signed-off-by: Andrew Jeffery <[email protected]>
Acked-by: Joel Stanley <[email protected]>
---
Documentation/devicetree/bindings/net/ftgmac100.txt | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/net/ftgmac100.txt b/Documentation/devicetree/bindings/net/ftgmac100.txt
index 72e7aaf7242e..04cc0191b7dd 100644
--- a/Documentation/devicetree/bindings/net/ftgmac100.txt
+++ b/Documentation/devicetree/bindings/net/ftgmac100.txt
@@ -9,6 +9,7 @@ Required properties:

- "aspeed,ast2400-mac"
- "aspeed,ast2500-mac"
+ - "aspeed,ast2600-mac"

- reg: Address and length of the register set for the device
- interrupts: Should contain ethernet controller interrupt
--
2.20.1

2019-10-11 17:02:57

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH v2 1/3] dt-bindings: net: ftgmac100: Document AST2600 compatible

On Thu, 10 Oct 2019 12:37:54 +1030, Andrew Jeffery wrote:
> The AST2600 contains an FTGMAC100-compatible MAC, although the MDIO
> controller previously embedded in the MAC has been moved out to a
> dedicated MDIO block.
>
> Signed-off-by: Andrew Jeffery <[email protected]>
> Acked-by: Joel Stanley <[email protected]>
> ---
> Documentation/devicetree/bindings/net/ftgmac100.txt | 1 +
> 1 file changed, 1 insertion(+)
>

Acked-by: Rob Herring <[email protected]>

2019-10-12 03:43:36

by David Miller

[permalink] [raw]
Subject: Re: [PATCH v2 0/3] net: ftgmac100: Ungate RCLK for RMII on ASPEED MACs

From: Andrew Jeffery <[email protected]>
Date: Thu, 10 Oct 2019 12:37:53 +1030

> This series slightly extends the devicetree binding and driver for the
> FTGMAC100 to describe an optional RMII RCLK gate in the clocks property.
> Currently it's necessary for the kernel to ungate RCLK on the AST2600 in NCSI
> configurations as u-boot does not yet support NCSI (which uses the
> R(educed)MII).
>
> v2:
> * Clear up Reduced vs Reversed MII in the cover letter
> * Mitigate anxiety in the commit message for 1/3
> * Clarify that AST2500 is also affected in the clocks property description in
> 2/3
> * Rework the error paths and update some comments in 3/3
>
> v1 can be found here: https://lore.kernel.org/netdev/[email protected]/

Series applied to net-next, thank you.