Hi Shannon,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 1c0cc5f1ae5ee5a6913704c0d75a6e99604ee30a
commit: 77ceb68e29ccd25d923b6af59e74ecaf736cc4b7 ionic: Add notifyq support
date: 5 weeks ago
config: x86_64-randconfig-a002-201941 (attached as .config)
compiler: gcc-7 (Debian 7.4.0-13) 7.4.0
reproduce:
git checkout 77ceb68e29ccd25d923b6af59e74ecaf736cc4b7
# save the attached .config to linux build tree
make ARCH=x86_64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <[email protected]>
All errors (new ones prefixed by >>):
drivers/net/ethernet/pensando/ionic/ionic_lif.c: In function 'ionic_notifyq_service':
>> drivers/net/ethernet/pensando/ionic/ionic_lif.c:333:2: error: implicit declaration of function 'dynamic_hex_dump'; did you mean 'seq_hex_dump'? [-Werror=implicit-function-declaration]
dynamic_hex_dump("event ", DUMP_PREFIX_OFFSET, 16, 1,
^~~~~~~~~~~~~~~~
seq_hex_dump
cc1: some warnings being treated as errors
vim +333 drivers/net/ethernet/pensando/ionic/ionic_lif.c
311
312 static bool ionic_notifyq_service(struct ionic_cq *cq,
313 struct ionic_cq_info *cq_info)
314 {
315 union ionic_notifyq_comp *comp = cq_info->cq_desc;
316 struct net_device *netdev;
317 struct ionic_queue *q;
318 struct ionic_lif *lif;
319 u64 eid;
320
321 q = cq->bound_q;
322 lif = q->info[0].cb_arg;
323 netdev = lif->netdev;
324 eid = le64_to_cpu(comp->event.eid);
325
326 /* Have we run out of new completions to process? */
327 if (eid <= lif->last_eid)
328 return false;
329
330 lif->last_eid = eid;
331
332 dev_dbg(lif->ionic->dev, "notifyq event:\n");
> 333 dynamic_hex_dump("event ", DUMP_PREFIX_OFFSET, 16, 1,
334 comp, sizeof(*comp), true);
335
336 switch (le16_to_cpu(comp->event.ecode)) {
337 case IONIC_EVENT_LINK_CHANGE:
338 netdev_info(netdev, "Notifyq IONIC_EVENT_LINK_CHANGE eid=%lld\n",
339 eid);
340 netdev_info(netdev,
341 " link_status=%d link_speed=%d\n",
342 le16_to_cpu(comp->link_change.link_status),
343 le32_to_cpu(comp->link_change.link_speed));
344 break;
345 case IONIC_EVENT_RESET:
346 netdev_info(netdev, "Notifyq IONIC_EVENT_RESET eid=%lld\n",
347 eid);
348 netdev_info(netdev, " reset_code=%d state=%d\n",
349 comp->reset.reset_code,
350 comp->reset.state);
351 break;
352 default:
353 netdev_warn(netdev, "Notifyq unknown event ecode=%d eid=%lld\n",
354 comp->event.ecode, eid);
355 break;
356 }
357
358 return true;
359 }
360
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
On 10/12/19 10:45 AM, kbuild test robot wrote:
> Hi Shannon,
>
> FYI, the error/warning still remains.
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: 1c0cc5f1ae5ee5a6913704c0d75a6e99604ee30a
> commit: 77ceb68e29ccd25d923b6af59e74ecaf736cc4b7 ionic: Add notifyq support
> date: 5 weeks ago
> config: x86_64-randconfig-a002-201941 (attached as .config)
> compiler: gcc-7 (Debian 7.4.0-13) 7.4.0
> reproduce:
> git checkout 77ceb68e29ccd25d923b6af59e74ecaf736cc4b7
> # save the attached .config to linux build tree
> make ARCH=x86_64
>
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <[email protected]>
Hmmm, I thought Arnd Bergmann had already addressed these, and I Acked:
https://lore.kernel.org/netdev/[email protected]/
Dave, is there something more I need to do here?
sln
>
> All errors (new ones prefixed by >>):
>
> drivers/net/ethernet/pensando/ionic/ionic_lif.c: In function 'ionic_notifyq_service':
>>> drivers/net/ethernet/pensando/ionic/ionic_lif.c:333:2: error: implicit declaration of function 'dynamic_hex_dump'; did you mean 'seq_hex_dump'? [-Werror=implicit-function-declaration]
> dynamic_hex_dump("event ", DUMP_PREFIX_OFFSET, 16, 1,
> ^~~~~~~~~~~~~~~~
> seq_hex_dump
> cc1: some warnings being treated as errors
>
> vim +333 drivers/net/ethernet/pensando/ionic/ionic_lif.c
>
> 311
> 312 static bool ionic_notifyq_service(struct ionic_cq *cq,
> 313 struct ionic_cq_info *cq_info)
> 314 {
> 315 union ionic_notifyq_comp *comp = cq_info->cq_desc;
> 316 struct net_device *netdev;
> 317 struct ionic_queue *q;
> 318 struct ionic_lif *lif;
> 319 u64 eid;
> 320
> 321 q = cq->bound_q;
> 322 lif = q->info[0].cb_arg;
> 323 netdev = lif->netdev;
> 324 eid = le64_to_cpu(comp->event.eid);
> 325
> 326 /* Have we run out of new completions to process? */
> 327 if (eid <= lif->last_eid)
> 328 return false;
> 329
> 330 lif->last_eid = eid;
> 331
> 332 dev_dbg(lif->ionic->dev, "notifyq event:\n");
> > 333 dynamic_hex_dump("event ", DUMP_PREFIX_OFFSET, 16, 1,
> 334 comp, sizeof(*comp), true);
> 335
> 336 switch (le16_to_cpu(comp->event.ecode)) {
> 337 case IONIC_EVENT_LINK_CHANGE:
> 338 netdev_info(netdev, "Notifyq IONIC_EVENT_LINK_CHANGE eid=%lld\n",
> 339 eid);
> 340 netdev_info(netdev,
> 341 " link_status=%d link_speed=%d\n",
> 342 le16_to_cpu(comp->link_change.link_status),
> 343 le32_to_cpu(comp->link_change.link_speed));
> 344 break;
> 345 case IONIC_EVENT_RESET:
> 346 netdev_info(netdev, "Notifyq IONIC_EVENT_RESET eid=%lld\n",
> 347 eid);
> 348 netdev_info(netdev, " reset_code=%d state=%d\n",
> 349 comp->reset.reset_code,
> 350 comp->reset.state);
> 351 break;
> 352 default:
> 353 netdev_warn(netdev, "Notifyq unknown event ecode=%d eid=%lld\n",
> 354 comp->event.ecode, eid);
> 355 break;
> 356 }
> 357
> 358 return true;
> 359 }
> 360
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation