2019-10-13 04:09:15

by Masanari Iida

Subject: [PATCH] writeback: Fix a warning while "make xmldocs"

This patch fix following warning.
./fs/fs-writeback.c:918: warning: Excess function parameter
'nr_pages' description in 'cgroup_writeback_by_id'

Signed-off-by: Masanari Iida <[email protected]>
---
fs/fs-writeback.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
index e88421d9a48d..8461a6322039 100644
--- a/fs/fs-writeback.c
+++ b/fs/fs-writeback.c
@@ -905,7 +905,7 @@ static void bdi_split_work_to_wbs(struct backing_dev_info *bdi,
* cgroup_writeback_by_id - initiate cgroup writeback from bdi and memcg IDs
* @bdi_id: target bdi id
* @memcg_id: target memcg css id
- * @nr_pages: number of pages to write, 0 for best-effort dirty flushing
+ * @nr: number of pages to write, 0 for best-effort dirty flushing
* @reason: reason why some writeback work initiated
* @done: target wb_completion
*
--
2.23.0.526.g70bf0b755af4

2019-10-13 06:21:15

by Randy Dunlap

Subject: Re: [PATCH] writeback: Fix a warning while "make xmldocs"

On 10/12/19 9:08 PM, Masanari Iida wrote:
> This patch fix following warning.
> ./fs/fs-writeback.c:918: warning: Excess function parameter
> 'nr_pages' description in 'cgroup_writeback_by_id'
>
> Signed-off-by: Masanari Iida <[email protected]>
> ---
> fs/fs-writeback.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
> index e88421d9a48d..8461a6322039 100644
> --- a/fs/fs-writeback.c
> +++ b/fs/fs-writeback.c
> @@ -905,7 +905,7 @@ static void bdi_split_work_to_wbs(struct backing_dev_info *bdi,
> * cgroup_writeback_by_id - initiate cgroup writeback from bdi and memcg IDs
> * @bdi_id: target bdi id
> * @memcg_id: target memcg css id
> - * @nr_pages: number of pages to write, 0 for best-effort dirty flushing
> + * @nr: number of pages to write, 0 for best-effort dirty flushing
> * @reason: reason why some writeback work initiated
> * @done: target wb_completion
> *
>

https://lore.kernel.org/linux-fsdevel/[email protected]/

Andrew has already added this to his patches.

--
~Randy