2019-09-23 19:50:31

by Markus Elfring

Subject: [PATCH] dmaengine: zx: Use devm_platform_ioremap_resource() in zx_dma_probe()

From: Markus Elfring <[email protected]>
Date: Sun, 22 Sep 2019 14:32:12 +0200

Simplify this function implementation by using a known wrapper function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[email protected]>
---
drivers/dma/zx_dma.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/dma/zx_dma.c b/drivers/dma/zx_dma.c
index 9f4436f7c914..6b457e683e70 100644
--- a/drivers/dma/zx_dma.c
+++ b/drivers/dma/zx_dma.c
@@ -754,18 +754,13 @@ static struct dma_chan *zx_of_dma_simple_xlate(struct of_phandle_args *dma_spec,
static int zx_dma_probe(struct platform_device *op)
{
struct zx_dma_dev *d;
- struct resource *iores;
int i, ret = 0;

- iores = platform_get_resource(op, IORESOURCE_MEM, 0);
- if (!iores)
- return -EINVAL;
-
d = devm_kzalloc(&op->dev, sizeof(*d), GFP_KERNEL);
if (!d)
return -ENOMEM;

- d->base = devm_ioremap_resource(&op->dev, iores);
+ d->base = devm_platform_ioremap_resource(op, 0);
if (IS_ERR(d->base))
return PTR_ERR(d->base);

--
2.23.0

2019-10-07 12:27:05

by Shawn Guo

Subject: Re: [PATCH] dmaengine: zx: Use devm_platform_ioremap_resource() in zx_dma_probe()

On Sun, Sep 22, 2019 at 02:37:13PM +0200, Markus Elfring wrote:
> From: Markus Elfring <[email protected]>
> Date: Sun, 22 Sep 2019 14:32:12 +0200
>
> Simplify this function implementation by using a known wrapper function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <[email protected]>

Acked-by: Shawn Guo <[email protected]>

2019-10-14 07:55:04

by Vinod Koul

Subject: Re: [PATCH] dmaengine: zx: Use devm_platform_ioremap_resource() in zx_dma_probe()

On 22-09-19, 14:37, Markus Elfring wrote:
> From: Markus Elfring <[email protected]>
> Date: Sun, 22 Sep 2019 14:32:12 +0200
>
> Simplify this function implementation by using a known wrapper function.
>
> This issue was detected by using the Coccinelle software.

Applied, thanks

--
~Vinod