2019-10-14 16:16:32

by Daniel Baluta

Subject: [PATCH] firmware: imx: Remove call to devm_of_platform_populate

IMX DSP device is created by SOF layer. The current call to
devm_of_platform_populate is not needed and it doesn't produce
any effects.

Fixes: ffbf23d50353915d ("firmware: imx: Add DSP IPC protocol interface)
Signed-off-by: Daniel Baluta <[email protected]>
---
drivers/firmware/imx/imx-dsp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/imx/imx-dsp.c b/drivers/firmware/imx/imx-dsp.c
index a43d2db5cbdb..4265e9dbed84 100644
--- a/drivers/firmware/imx/imx-dsp.c
+++ b/drivers/firmware/imx/imx-dsp.c
@@ -114,7 +114,7 @@ static int imx_dsp_probe(struct platform_device *pdev)

dev_info(dev, "NXP i.MX DSP IPC initialized\n");

- return devm_of_platform_populate(dev);
+ return 0;
out:
kfree(chan_name);
for (j = 0; j < i; j++) {
--
2.17.1

2019-10-26 11:25:25

by Shawn Guo

Subject: Re: [PATCH] firmware: imx: Remove call to devm_of_platform_populate

On Mon, Oct 14, 2019 at 06:32:28PM +0300, Daniel Baluta wrote:
> IMX DSP device is created by SOF layer. The current call to
> devm_of_platform_populate is not needed and it doesn't produce
> any effects.
>
> Fixes: ffbf23d50353915d ("firmware: imx: Add DSP IPC protocol interface)
> Signed-off-by: Daniel Baluta <[email protected]>

Applied, thanks.