2019-10-15 13:43:10

by Rodrigo Siqueira Jordao

[permalink] [raw]
Subject: [PATCH] drm: Add LT-tunable PHY repeater mode operations

LT-tunable PHY Repeaters can operate in two different modes: transparent
(default) and non-transparent. The value 0x55 specifies the transparent
mode, and 0xaa represents the non-transparent; this commit adds these
two values as definitions.

Cc: Abdoulaye Berthe <[email protected]>
Cc: Harry Wentland <[email protected]>
Cc: Leo Li <[email protected]>
Cc: Jani Nikula <[email protected]>
Cc: Manasi Navare <[email protected]>
Cc: Ville Syrj?l? <[email protected]>
Signed-off-by: Abdoulaye Berthe <[email protected]>
Signed-off-by: Rodrigo Siqueira <[email protected]>
---
include/drm/drm_dp_helper.h | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
index bf62b43aaf2b..cfadeeef8492 100644
--- a/include/drm/drm_dp_helper.h
+++ b/include/drm/drm_dp_helper.h
@@ -1034,6 +1034,10 @@
#define DP_SYMBOL_ERROR_COUNT_LANE3_PHY_REPEATER1 0xf003b /* 1.3 */
#define DP_FEC_STATUS_PHY_REPEATER1 0xf0290 /* 1.4 */

+/* Repeater modes */
+#define DP_PHY_REPEATER_MODE_TRANSPARENT 0x55 /* 1.3 */
+#define DP_PHY_REPEATER_MODE_NON_TRANSPARENT 0xaa /* 1.3 */
+
/* DP HDCP message start offsets in DPCD address space */
#define DP_HDCP_2_2_AKE_INIT_OFFSET DP_HDCP_2_2_REG_RTX_OFFSET
#define DP_HDCP_2_2_AKE_SEND_CERT_OFFSET DP_HDCP_2_2_REG_CERT_RX_OFFSET
--
2.23.0


Attachments:
(No filename) (1.41 kB)
signature.asc (849.00 B)
Download all attachments

2019-10-15 13:53:56

by Ville Syrjälä

[permalink] [raw]
Subject: Re: [PATCH] drm: Add LT-tunable PHY repeater mode operations

On Tue, Oct 15, 2019 at 01:40:12PM +0000, Siqueira, Rodrigo wrote:
> LT-tunable PHY Repeaters can operate in two different modes: transparent
> (default) and non-transparent. The value 0x55 specifies the transparent
> mode, and 0xaa represents the non-transparent; this commit adds these
> two values as definitions.
>
> Cc: Abdoulaye Berthe <[email protected]>
> Cc: Harry Wentland <[email protected]>
> Cc: Leo Li <[email protected]>
> Cc: Jani Nikula <[email protected]>
> Cc: Manasi Navare <[email protected]>
> Cc: Ville Syrj?l? <[email protected]>
> Signed-off-by: Abdoulaye Berthe <[email protected]>
> Signed-off-by: Rodrigo Siqueira <[email protected]>

Reviewed-by: Ville Syrj?l? <[email protected]>

> ---
> include/drm/drm_dp_helper.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> index bf62b43aaf2b..cfadeeef8492 100644
> --- a/include/drm/drm_dp_helper.h
> +++ b/include/drm/drm_dp_helper.h
> @@ -1034,6 +1034,10 @@
> #define DP_SYMBOL_ERROR_COUNT_LANE3_PHY_REPEATER1 0xf003b /* 1.3 */
> #define DP_FEC_STATUS_PHY_REPEATER1 0xf0290 /* 1.4 */
>
> +/* Repeater modes */
> +#define DP_PHY_REPEATER_MODE_TRANSPARENT 0x55 /* 1.3 */
> +#define DP_PHY_REPEATER_MODE_NON_TRANSPARENT 0xaa /* 1.3 */
> +
> /* DP HDCP message start offsets in DPCD address space */
> #define DP_HDCP_2_2_AKE_INIT_OFFSET DP_HDCP_2_2_REG_RTX_OFFSET
> #define DP_HDCP_2_2_AKE_SEND_CERT_OFFSET DP_HDCP_2_2_REG_CERT_RX_OFFSET
> --
> 2.23.0



--
Ville Syrj?l?
Intel

2019-10-15 14:33:58

by Harry Wentland

[permalink] [raw]
Subject: Re: [PATCH] drm: Add LT-tunable PHY repeater mode operations

On 2019-10-15 9:40 a.m., Siqueira, Rodrigo wrote:
> LT-tunable PHY Repeaters can operate in two different modes: transparent
> (default) and non-transparent. The value 0x55 specifies the transparent
> mode, and 0xaa represents the non-transparent; this commit adds these
> two values as definitions.
>
> Cc: Abdoulaye Berthe <[email protected]>
> Cc: Harry Wentland <[email protected]>
> Cc: Leo Li <[email protected]>
> Cc: Jani Nikula <[email protected]>
> Cc: Manasi Navare <[email protected]>
> Cc: Ville Syrj?l? <[email protected]>
> Signed-off-by: Abdoulaye Berthe <[email protected]>
> Signed-off-by: Rodrigo Siqueira <[email protected]>

Reviewed-by: Harry Wentland <[email protected]>

Harry

> ---
> include/drm/drm_dp_helper.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> index bf62b43aaf2b..cfadeeef8492 100644
> --- a/include/drm/drm_dp_helper.h
> +++ b/include/drm/drm_dp_helper.h
> @@ -1034,6 +1034,10 @@
> #define DP_SYMBOL_ERROR_COUNT_LANE3_PHY_REPEATER1 0xf003b /* 1.3 */
> #define DP_FEC_STATUS_PHY_REPEATER1 0xf0290 /* 1.4 */
>
> +/* Repeater modes */
> +#define DP_PHY_REPEATER_MODE_TRANSPARENT 0x55 /* 1.3 */
> +#define DP_PHY_REPEATER_MODE_NON_TRANSPARENT 0xaa /* 1.3 */
> +
> /* DP HDCP message start offsets in DPCD address space */
> #define DP_HDCP_2_2_AKE_INIT_OFFSET DP_HDCP_2_2_REG_RTX_OFFSET
> #define DP_HDCP_2_2_AKE_SEND_CERT_OFFSET DP_HDCP_2_2_REG_CERT_RX_OFFSET
>


Attachments:
signature.asc (499.00 B)
OpenPGP digital signature

2019-10-15 21:40:14

by Rodrigo Siqueira Jordao

[permalink] [raw]
Subject: Re: [PATCH] drm: Add LT-tunable PHY repeater mode operations

Applied to drm-misc-next.

Thanks

On 10/15, Ville Syrj?l? wrote:
> On Tue, Oct 15, 2019 at 01:40:12PM +0000, Siqueira, Rodrigo wrote:
> > LT-tunable PHY Repeaters can operate in two different modes: transparent
> > (default) and non-transparent. The value 0x55 specifies the transparent
> > mode, and 0xaa represents the non-transparent; this commit adds these
> > two values as definitions.
> >
> > Cc: Abdoulaye Berthe <[email protected]>
> > Cc: Harry Wentland <[email protected]>
> > Cc: Leo Li <[email protected]>
> > Cc: Jani Nikula <[email protected]>
> > Cc: Manasi Navare <[email protected]>
> > Cc: Ville Syrj?l? <[email protected]>
> > Signed-off-by: Abdoulaye Berthe <[email protected]>
> > Signed-off-by: Rodrigo Siqueira <[email protected]>
>
> Reviewed-by: Ville Syrj?l? <[email protected]>
>
> > ---
> > include/drm/drm_dp_helper.h | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> > index bf62b43aaf2b..cfadeeef8492 100644
> > --- a/include/drm/drm_dp_helper.h
> > +++ b/include/drm/drm_dp_helper.h
> > @@ -1034,6 +1034,10 @@
> > #define DP_SYMBOL_ERROR_COUNT_LANE3_PHY_REPEATER1 0xf003b /* 1.3 */
> > #define DP_FEC_STATUS_PHY_REPEATER1 0xf0290 /* 1.4 */
> >
> > +/* Repeater modes */
> > +#define DP_PHY_REPEATER_MODE_TRANSPARENT 0x55 /* 1.3 */
> > +#define DP_PHY_REPEATER_MODE_NON_TRANSPARENT 0xaa /* 1.3 */
> > +
> > /* DP HDCP message start offsets in DPCD address space */
> > #define DP_HDCP_2_2_AKE_INIT_OFFSET DP_HDCP_2_2_REG_RTX_OFFSET
> > #define DP_HDCP_2_2_AKE_SEND_CERT_OFFSET DP_HDCP_2_2_REG_CERT_RX_OFFSET
> > --
> > 2.23.0
>
>
>
> --
> Ville Syrj?l?
> Intel

--
Rodrigo Siqueira
Software Engineer, Advanced Micro Devices (AMD)
https://siqueira.tech


Attachments:
(No filename) (1.88 kB)
signature.asc (849.00 B)
Download all attachments