2019-10-16 11:38:29

by Masahiro Yamada

Subject: [PATCH] kbuild: remove unneeded variable, single-all

When single-build is set, everything in $(MAKECMDGOALS) is a single
target. You can use $(MAKECMDGOALS) to list out the single targets.

Signed-off-by: Masahiro Yamada <[email protected]>
---

Makefile | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/Makefile b/Makefile
index ffd7a912fc46..710199f60c30 100644
--- a/Makefile
+++ b/Makefile
@@ -1764,11 +1764,9 @@ tools/%: FORCE

ifdef single-build

-single-all := $(filter $(single-targets), $(MAKECMDGOALS))
-
# .ko is special because modpost is needed
-single-ko := $(sort $(filter %.ko, $(single-all)))
-single-no-ko := $(sort $(patsubst %.ko,%.mod, $(single-all)))
+single-ko := $(sort $(filter %.ko, $(MAKECMDGOALS)))
+single-no-ko := $(sort $(patsubst %.ko,%.mod, $(MAKECMDGOALS)))

$(single-ko): single_modpost
@:
--
2.17.1

2019-10-25 18:44:39

by Masahiro Yamada

Subject: Re: [PATCH] kbuild: remove unneeded variable, single-all

On Wed, Oct 16, 2019 at 2:12 PM Masahiro Yamada
<[email protected]> wrote:
>
> When single-build is set, everything in $(MAKECMDGOALS) is a single
> target. You can use $(MAKECMDGOALS) to list out the single targets.
>
> Signed-off-by: Masahiro Yamada <[email protected]>
> ---
>

Applied to linux-kbuild.

> Makefile | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index ffd7a912fc46..710199f60c30 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1764,11 +1764,9 @@ tools/%: FORCE
>
> ifdef single-build
>
> -single-all := $(filter $(single-targets), $(MAKECMDGOALS))
> -
> # .ko is special because modpost is needed
> -single-ko := $(sort $(filter %.ko, $(single-all)))
> -single-no-ko := $(sort $(patsubst %.ko,%.mod, $(single-all)))
> +single-ko := $(sort $(filter %.ko, $(MAKECMDGOALS)))
> +single-no-ko := $(sort $(patsubst %.ko,%.mod, $(MAKECMDGOALS)))
>
> $(single-ko): single_modpost
> @:
> --
> 2.17.1
>


--
Best Regards
Masahiro Yamada