2019-09-30 12:26:48

by Mihail Atanassov

Subject: [PATCH v2] drm/komeda: Fix typos in komeda_splitter_validate

Fix both the string and the struct member being printed.

Changes since v1:
- Now with a bonus grammar fix, too.

Fixes: 264b9436d23b ("drm/komeda: Enable writeback split support")
Signed-off-by: Mihail Atanassov <[email protected]>
---
drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c b/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c
index 950235af1e79..2b624bfe1751 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c
@@ -564,8 +564,8 @@ komeda_splitter_validate(struct komeda_splitter *splitter,
}

if (!in_range(&splitter->vsize, dflow->in_h)) {
- DRM_DEBUG_ATOMIC("split in_in: %d exceed the acceptable range.\n",
- dflow->in_w);
+ DRM_DEBUG_ATOMIC("split in_h: %d exceeds the acceptable range.\n",
+ dflow->in_h);
return -EINVAL;
}

--
2.23.0

2019-10-16 12:51:24

by James Qian Wang

Subject: Re: [v2] drm/komeda: Fix typos in komeda_splitter_validate

On Mon, Sep 30, 2019 at 12:23:07PM +0000, Mihail Atanassov wrote:
> Fix both the string and the struct member being printed.
>
> Changes since v1:
> - Now with a bonus grammar fix, too.
>
> Fixes: 264b9436d23b ("drm/komeda: Enable writeback split support")
> Signed-off-by: Mihail Atanassov <[email protected]>
> ---
> drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c b/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c
> index 950235af1e79..2b624bfe1751 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c
> @@ -564,8 +564,8 @@ komeda_splitter_validate(struct komeda_splitter *splitter,
> }
>
> if (!in_range(&splitter->vsize, dflow->in_h)) {
> - DRM_DEBUG_ATOMIC("split in_in: %d exceed the acceptable range.\n",
> - dflow->in_w);
> + DRM_DEBUG_ATOMIC("split in_h: %d exceeds the acceptable range.\n",
> + dflow->in_h);

Reviewed-by: James Qian Wang (Arm Technology China) <[email protected]>
> return -EINVAL;
> }
>

2019-10-21 14:03:49

by Mihail Atanassov

Subject: Re: [v2] drm/komeda: Fix typos in komeda_splitter_validate

On Wednesday, 16 October 2019 09:23:03 BST james qian wang (Arm Technology China) wrote:
> On Mon, Sep 30, 2019 at 12:23:07PM +0000, Mihail Atanassov wrote:
> > Fix both the string and the struct member being printed.
> >
> > Changes since v1:
> > - Now with a bonus grammar fix, too.
> >
> > Fixes: 264b9436d23b ("drm/komeda: Enable writeback split support")
> > Signed-off-by: Mihail Atanassov <[email protected]>
> > ---
> > drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c b/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c
> > index 950235af1e79..2b624bfe1751 100644
> > --- a/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c
> > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c
> > @@ -564,8 +564,8 @@ komeda_splitter_validate(struct komeda_splitter *splitter,
> > }
> >
> > if (!in_range(&splitter->vsize, dflow->in_h)) {
> > - DRM_DEBUG_ATOMIC("split in_in: %d exceed the acceptable range.\n",
> > - dflow->in_w);
> > + DRM_DEBUG_ATOMIC("split in_h: %d exceeds the acceptable range.\n",
> > + dflow->in_h);
>
> Reviewed-by: James Qian Wang (Arm Technology China) <[email protected]>

Thanks for the review, applied to drm-misc-fixes -
8ae501e295cce9bc6e0dd82d5204a1d5faef44f8.

> > return -EINVAL;
> > }
> >
>


--
Mihail