Hi all,
After merging the block tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:
fs/io_uring.c: In function 'io_accept':
fs/io_uring.c:1729:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
1729 | addr = (struct sockaddr __user *) READ_ONCE(sqe->addr);
| ^
fs/io_uring.c:1730:13: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
1730 | addr_len = (int __user *) READ_ONCE(sqe->addr2);
| ^
Introduced by commit
d674c2b9335f ("io_uring: add support for IORING_OP_ACCEPT")
addr and addr2 are __u64 ...
--
Cheers,
Stephen Rothwell
On 10/17/19 6:56 PM, Jens Axboe wrote:
> On 10/17/19 6:51 PM, Stephen Rothwell wrote:
>> Hi all,
>>
>> After merging the block tree, today's linux-next build (arm
>> multi_v7_defconfig) produced this warning:
>>
>> fs/io_uring.c: In function 'io_accept':
>> fs/io_uring.c:1729:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>> 1729 | addr = (struct sockaddr __user *) READ_ONCE(sqe->addr);
>> | ^
>> fs/io_uring.c:1730:13: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>> 1730 | addr_len = (int __user *) READ_ONCE(sqe->addr2);
>> | ^
>>
>> Introduced by commit
>>
>> d674c2b9335f ("io_uring: add support for IORING_OP_ACCEPT")
>>
>> addr and addr2 are __u64 ...
>
> I'll fix these warnings up, guessing it's 32-bit?
Should be fixed up and pushed out now.
--
Jens Axboe
On 10/17/19 6:51 PM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the block tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> fs/io_uring.c: In function 'io_accept':
> fs/io_uring.c:1729:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> 1729 | addr = (struct sockaddr __user *) READ_ONCE(sqe->addr);
> | ^
> fs/io_uring.c:1730:13: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> 1730 | addr_len = (int __user *) READ_ONCE(sqe->addr2);
> | ^
>
> Introduced by commit
>
> d674c2b9335f ("io_uring: add support for IORING_OP_ACCEPT")
>
> addr and addr2 are __u64 ...
I'll fix these warnings up, guessing it's 32-bit?
--
Jens Axboe
Hi Jens,
On Thu, 17 Oct 2019 18:56:39 -0600 Jens Axboe <[email protected]> wrote:
>
> I'll fix these warnings up, guessing it's 32-bit?
Thanks. Yeah 32 bit.
--
Cheers,
Stephen Rothwell