2019-10-19 08:27:18

by Neil Armstrong

[permalink] [raw]
Subject: [PATCH] arm64: dts: meson-g12b-khadas-vim3: add missing frddr_a status property

In the process of moving the VIM3 audio nodes to a G12B specific dtsi
for enabling the SM1 based VIM3L, the frddr_a status = "okay" property
got dropped.
This re-enables the frddr_a node to fix audio support.

Fixes: 4f26cc1c96c9 ("arm64: dts: khadas-vim3: move common nodes into meson-khadas-vim3.dtsi")
Reported-by: Christian Hewitt <[email protected]>
Signed-off-by: Neil Armstrong <[email protected]>
---
arch/arm64/boot/dts/amlogic/meson-g12b-khadas-vim3.dtsi | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-khadas-vim3.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-khadas-vim3.dtsi
index 554863429aa6..e2094575f528 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12b-khadas-vim3.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-g12b-khadas-vim3.dtsi
@@ -152,6 +152,10 @@
clock-latency = <50000>;
};

+&frddr_a {
+ status = "okay";
+};
+
&frddr_b {
status = "okay";
};
--
2.17.1


2019-10-19 08:42:23

by Jerome Brunet

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: meson-g12b-khadas-vim3: add missing frddr_a status property


On Fri 18 Oct 2019 at 16:02, Neil Armstrong <[email protected]> wrote:

> In the process of moving the VIM3 audio nodes to a G12B specific dtsi
> for enabling the SM1 based VIM3L, the frddr_a status = "okay" property
> got dropped.
> This re-enables the frddr_a node to fix audio support.
>
> Fixes: 4f26cc1c96c9 ("arm64: dts: khadas-vim3: move common nodes into meson-khadas-vim3.dtsi")
> Reported-by: Christian Hewitt <[email protected]>
> Signed-off-by: Neil Armstrong <[email protected]>
> ---
> arch/arm64/boot/dts/amlogic/meson-g12b-khadas-vim3.dtsi | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-khadas-vim3.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-khadas-vim3.dtsi
> index 554863429aa6..e2094575f528 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12b-khadas-vim3.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-khadas-vim3.dtsi
> @@ -152,6 +152,10 @@
> clock-latency = <50000>;
> };
>
> +&frddr_a {
> + status = "okay";
> +};
> +
> &frddr_b {
> status = "okay";
> };

Acked-by: Jerome Brunet <[email protected]>

2019-10-19 09:03:15

by Kevin Hilman

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: meson-g12b-khadas-vim3: add missing frddr_a status property

Jerome Brunet <[email protected]> writes:

> On Fri 18 Oct 2019 at 16:02, Neil Armstrong <[email protected]> wrote:
>
>> In the process of moving the VIM3 audio nodes to a G12B specific dtsi
>> for enabling the SM1 based VIM3L, the frddr_a status = "okay" property
>> got dropped.
>> This re-enables the frddr_a node to fix audio support.
>>
>> Fixes: 4f26cc1c96c9 ("arm64: dts: khadas-vim3: move common nodes into meson-khadas-vim3.dtsi")
>> Reported-by: Christian Hewitt <[email protected]>
>> Signed-off-by: Neil Armstrong <[email protected]>
>> ---
>> arch/arm64/boot/dts/amlogic/meson-g12b-khadas-vim3.dtsi | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-khadas-vim3.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-khadas-vim3.dtsi
>> index 554863429aa6..e2094575f528 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-g12b-khadas-vim3.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-khadas-vim3.dtsi
>> @@ -152,6 +152,10 @@
>> clock-latency = <50000>;
>> };
>>
>> +&frddr_a {
>> + status = "okay";
>> +};
>> +
>> &frddr_b {
>> status = "okay";
>> };
>
> Acked-by: Jerome Brunet <[email protected]>

Queued as a fix for v5.4-rc,

Thanks,

Kevin