2019-10-20 15:09:09

by Fabien Parent

Subject: [PATCH RESEND] mfd: mt6397: Use PLATFORM_DEVID_NONE macro instead of -1

Use the correct macro when adding the MFD devices instead of using
directly '-1' value.

Signed-off-by: Fabien Parent <[email protected]>
Reviewed-by: Matthias Brugger <[email protected]>
---
drivers/mfd/mt6397-core.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c
index 310dae26ddff..9b19dfeeb797 100644
--- a/drivers/mfd/mt6397-core.c
+++ b/drivers/mfd/mt6397-core.c
@@ -171,9 +171,9 @@ static int mt6397_probe(struct platform_device *pdev)
if (ret)
return ret;

- ret = devm_mfd_add_devices(&pdev->dev, -1, mt6323_devs,
- ARRAY_SIZE(mt6323_devs), NULL,
- 0, pmic->irq_domain);
+ ret = devm_mfd_add_devices(&pdev->dev, PLATFORM_DEVID_NONE,
+ mt6323_devs, ARRAY_SIZE(mt6323_devs),
+ NULL, 0, pmic->irq_domain);
break;

case MT6391_CHIP_ID:
@@ -186,9 +186,9 @@ static int mt6397_probe(struct platform_device *pdev)
if (ret)
return ret;

- ret = devm_mfd_add_devices(&pdev->dev, -1, mt6397_devs,
- ARRAY_SIZE(mt6397_devs), NULL,
- 0, pmic->irq_domain);
+ ret = devm_mfd_add_devices(&pdev->dev, PLATFORM_DEVID_NONE,
+ mt6397_devs, ARRAY_SIZE(mt6397_devs),
+ NULL, 0, pmic->irq_domain);
break;

default:
--
2.23.0

2019-10-24 22:19:21

by Lee Jones

Subject: Re: [PATCH RESEND] mfd: mt6397: Use PLATFORM_DEVID_NONE macro instead of -1

On Sun, 20 Oct 2019, Fabien Parent wrote:

> Use the correct macro when adding the MFD devices instead of using
> directly '-1' value.
>
> Signed-off-by: Fabien Parent <[email protected]>
> Reviewed-by: Matthias Brugger <[email protected]>
> ---
> drivers/mfd/mt6397-core.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)

Patch didn't apply, but I fixed it up and applied it.

Let me know if anything look wrong to you.

diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c
index b2c325ead1c8..0437c858d115 100644
--- a/drivers/mfd/mt6397-core.c
+++ b/drivers/mfd/mt6397-core.c
@@ -189,16 +189,16 @@ static int mt6397_probe(struct platform_device *pdev)

switch (pmic->chip_id) {
case MT6323_CHIP_ID:
- ret = devm_mfd_add_devices(&pdev->dev, -1, mt6323_devs,
- ARRAY_SIZE(mt6323_devs), NULL,
- 0, pmic->irq_domain);
+ ret = devm_mfd_add_devices(&pdev->dev, PLATFORM_DEVID_NONE,
+ mt6323_devs, ARRAY_SIZE(mt6323_devs),
+ NULL, 0, pmic->irq_domain);
break;

case MT6391_CHIP_ID:
case MT6397_CHIP_ID:
- ret = devm_mfd_add_devices(&pdev->dev, -1, mt6397_devs,
- ARRAY_SIZE(mt6397_devs), NULL,
- 0, pmic->irq_domain);
+ ret = devm_mfd_add_devices(&pdev->dev, PLATFORM_DEVID_NONE,
+ mt6397_devs, ARRAY_SIZE(mt6397_devs),
+ NULL, 0, pmic->irq_domain);
break;

default:

> diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c
> index 310dae26ddff..9b19dfeeb797 100644
> --- a/drivers/mfd/mt6397-core.c
> +++ b/drivers/mfd/mt6397-core.c
> @@ -171,9 +171,9 @@ static int mt6397_probe(struct platform_device *pdev)
> if (ret)
> return ret;
>
> - ret = devm_mfd_add_devices(&pdev->dev, -1, mt6323_devs,
> - ARRAY_SIZE(mt6323_devs), NULL,
> - 0, pmic->irq_domain);
> + ret = devm_mfd_add_devices(&pdev->dev, PLATFORM_DEVID_NONE,
> + mt6323_devs, ARRAY_SIZE(mt6323_devs),
> + NULL, 0, pmic->irq_domain);
> break;
>
> case MT6391_CHIP_ID:
> @@ -186,9 +186,9 @@ static int mt6397_probe(struct platform_device *pdev)
> if (ret)
> return ret;
>
> - ret = devm_mfd_add_devices(&pdev->dev, -1, mt6397_devs,
> - ARRAY_SIZE(mt6397_devs), NULL,
> - 0, pmic->irq_domain);
> + ret = devm_mfd_add_devices(&pdev->dev, PLATFORM_DEVID_NONE,
> + mt6397_devs, ARRAY_SIZE(mt6397_devs),
> + NULL, 0, pmic->irq_domain);
> break;
>
> default:

--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog