2019-10-21 15:05:38

by Rodrigo Siqueira Jordao

[permalink] [raw]
Subject: [PATCH] drm: Fix DSC throughput mode 0 mask definition

Commit d7cd0e05 introduced a change at DP_DSC_THROUGHPUT_MODE_0_170
which is not aligned with the spec. This commit replace 15 << 4 by
15 << 0 for DP_DSC_THROUGHPUT_MODE_0_170 in order to make it follow the
specification.

Cc: Harry Wentland <[email protected]>
Cc: Leo Li <[email protected]>
Cc: Alex Deucher <[email protected]>
Cc: Nikola Cornij <[email protected]>
Cc: Jani Nikula <[email protected]>
Cc: Manasi Navare <[email protected]>
Cc: Ville Syrj?l? <[email protected]>
Fixes: d7cd0e053b1 (drm/amd/display: Add 170Mpix/sec DSC throughput support)
Signed-off-by: Rodrigo Siqueira <[email protected]>
---
include/drm/drm_dp_helper.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
index cfadeeef8492..52024049c59e 100644
--- a/include/drm/drm_dp_helper.h
+++ b/include/drm/drm_dp_helper.h
@@ -306,7 +306,7 @@
# define DP_DSC_THROUGHPUT_MODE_0_900 (12 << 0)
# define DP_DSC_THROUGHPUT_MODE_0_950 (13 << 0)
# define DP_DSC_THROUGHPUT_MODE_0_1000 (14 << 0)
-# define DP_DSC_THROUGHPUT_MODE_0_170 (15 << 4)
+# define DP_DSC_THROUGHPUT_MODE_0_170 (15 << 0) /* 1.4a */
# define DP_DSC_THROUGHPUT_MODE_1_MASK (0xf << 4)
# define DP_DSC_THROUGHPUT_MODE_1_SHIFT 4
# define DP_DSC_THROUGHPUT_MODE_1_UPSUPPORTED 0
--
2.23.0

Attachments:
(No filename) (1.40 kB)
 signature.asc (849.00 B)
 Download all attachments

2019-10-21 15:37:31

by Harry Wentland

[permalink] [raw]
Subject: Re: [PATCH] drm: Fix DSC throughput mode 0 mask definition

On 2019-10-21 11:03 a.m., Siqueira, Rodrigo wrote:
> Commit d7cd0e05 introduced a change at DP_DSC_THROUGHPUT_MODE_0_170
> which is not aligned with the spec. This commit replace 15 << 4 by
> 15 << 0 for DP_DSC_THROUGHPUT_MODE_0_170 in order to make it follow the
> specification.
>
> Cc: Harry Wentland <[email protected]>
> Cc: Leo Li <[email protected]>
> Cc: Alex Deucher <[email protected]>
> Cc: Nikola Cornij <[email protected]>
> Cc: Jani Nikula <[email protected]>
> Cc: Manasi Navare <[email protected]>
> Cc: Ville Syrj?l? <[email protected]>
> Fixes: d7cd0e053b1 (drm/amd/display: Add 170Mpix/sec DSC throughput support)
> Signed-off-by: Rodrigo Siqueira <[email protected]>

Reviewed-by: Harry Wentland <[email protected]>

Harry

> ---
> include/drm/drm_dp_helper.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> index cfadeeef8492..52024049c59e 100644
> --- a/include/drm/drm_dp_helper.h
> +++ b/include/drm/drm_dp_helper.h
> @@ -306,7 +306,7 @@
> # define DP_DSC_THROUGHPUT_MODE_0_900 (12 << 0)
> # define DP_DSC_THROUGHPUT_MODE_0_950 (13 << 0)
> # define DP_DSC_THROUGHPUT_MODE_0_1000 (14 << 0)
> -# define DP_DSC_THROUGHPUT_MODE_0_170 (15 << 4)
> +# define DP_DSC_THROUGHPUT_MODE_0_170 (15 << 0) /* 1.4a */
> # define DP_DSC_THROUGHPUT_MODE_1_MASK (0xf << 4)
> # define DP_DSC_THROUGHPUT_MODE_1_SHIFT 4
> # define DP_DSC_THROUGHPUT_MODE_1_UPSUPPORTED 0
>

Attachments:
signature.asc (499.00 B)
OpenPGP digital signature