Hi all,
After merging the drm-misc-fixes tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:
In file included from include/uapi/linux/posix_types.h:5,
from include/uapi/linux/types.h:14,
from include/linux/types.h:6,
from include/linux/limits.h:6,
from include/linux/kernel.h:7,
from fs/aio.c:14:
fs/aio.c: In function '__do_compat_sys_io_pgetevents':
include/linux/stddef.h:8:14: warning: initialization of 'unsigned int' from 'void *' makes integer from pointer without a cast [-Wint-conversion]
8 | #define NULL ((void *)0)
| ^
fs/aio.c:2196:38: note: in expansion of macro 'NULL'
2196 | struct __compat_aio_sigset ksig = { NULL, };
| ^~~~
include/linux/stddef.h:8:14: note: (near initialization for 'ksig.sigmask')
8 | #define NULL ((void *)0)
| ^
fs/aio.c:2196:38: note: in expansion of macro 'NULL'
2196 | struct __compat_aio_sigset ksig = { NULL, };
| ^~~~
fs/aio.c: In function '__do_compat_sys_io_pgetevents_time64':
include/linux/stddef.h:8:14: warning: initialization of 'unsigned int' from 'void *' makes integer from pointer without a cast [-Wint-conversion]
8 | #define NULL ((void *)0)
| ^
fs/aio.c:2231:38: note: in expansion of macro 'NULL'
2231 | struct __compat_aio_sigset ksig = { NULL, };
| ^~~~
include/linux/stddef.h:8:14: note: (near initialization for 'ksig.sigmask')
8 | #define NULL ((void *)0)
| ^
fs/aio.c:2231:38: note: in expansion of macro 'NULL'
2231 | struct __compat_aio_sigset ksig = { NULL, };
| ^~~~
Introduced by commit
de80166a573d ("aio: Fix io_pgetevents() struct __compat_aio_sigset layout")
--
Cheers,
Stephen Rothwell
Hi all,
[Some people didn't get this due to a typo]
This should have been reported against the vfs-fixes tree, sorry.
On Tue, 22 Oct 2019 08:07:34 +1100 Stephen Rothwell <[email protected]> wrote:
>
> After merging the drm-misc-fixes tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
>
> In file included from include/uapi/linux/posix_types.h:5,
> from include/uapi/linux/types.h:14,
> from include/linux/types.h:6,
> from include/linux/limits.h:6,
> from include/linux/kernel.h:7,
> from fs/aio.c:14:
> fs/aio.c: In function '__do_compat_sys_io_pgetevents':
> include/linux/stddef.h:8:14: warning: initialization of 'unsigned int' from 'void *' makes integer from pointer without a cast [-Wint-conversion]
> 8 | #define NULL ((void *)0)
> | ^
> fs/aio.c:2196:38: note: in expansion of macro 'NULL'
> 2196 | struct __compat_aio_sigset ksig = { NULL, };
> | ^~~~
> include/linux/stddef.h:8:14: note: (near initialization for 'ksig.sigmask')
> 8 | #define NULL ((void *)0)
> | ^
> fs/aio.c:2196:38: note: in expansion of macro 'NULL'
> 2196 | struct __compat_aio_sigset ksig = { NULL, };
> | ^~~~
> fs/aio.c: In function '__do_compat_sys_io_pgetevents_time64':
> include/linux/stddef.h:8:14: warning: initialization of 'unsigned int' from 'void *' makes integer from pointer without a cast [-Wint-conversion]
> 8 | #define NULL ((void *)0)
> | ^
> fs/aio.c:2231:38: note: in expansion of macro 'NULL'
> 2231 | struct __compat_aio_sigset ksig = { NULL, };
> | ^~~~
> include/linux/stddef.h:8:14: note: (near initialization for 'ksig.sigmask')
> 8 | #define NULL ((void *)0)
> | ^
> fs/aio.c:2231:38: note: in expansion of macro 'NULL'
> 2231 | struct __compat_aio_sigset ksig = { NULL, };
> | ^~~~
>
> Introduced by commit
>
> de80166a573d ("aio: Fix io_pgetevents() struct __compat_aio_sigset layout")
--
Cheers,
Stephen Rothwell
Hi!
On Tue, 2019-10-22 at 07:44:26 +1100, Stephen Rothwell wrote:
> Fixes tag
>
> Fixes: 7a074e96 ("aio: implement io_pgetevents")
>
> has these problem(s):
>
> - SHA1 should be at least 12 digits long
> Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
> or later) just making sure it is not set (or set to "auto").
On Tue, 2019-10-22 at 09:35:12 +1100, Stephen Rothwell wrote:
> On Tue, 22 Oct 2019 08:07:34 +1100 Stephen Rothwell <[email protected]> wrote:
> > fs/aio.c:2196:38: note: in expansion of macro 'NULL'
> > 2196 | struct __compat_aio_sigset ksig = { NULL, };
> > | ^~~~
> > fs/aio.c:2196:38: note: in expansion of macro 'NULL'
> > 2196 | struct __compat_aio_sigset ksig = { NULL, };
> > | ^~~~
> > fs/aio.c:2231:38: note: in expansion of macro 'NULL'
> > 2231 | struct __compat_aio_sigset ksig = { NULL, };
> > | ^~~~
> > fs/aio.c:2231:38: note: in expansion of macro 'NULL'
> > 2231 | struct __compat_aio_sigset ksig = { NULL, };
> > | ^~~~
> >
> > Introduced by commit
> >
> > de80166a573d ("aio: Fix io_pgetevents() struct __compat_aio_sigset layout")
Ugh, sorry about that, I guess I didn't see the warnings in the scroll
back when I built this back then for testing. :/ Sending a new version
fixing both issues.
Thanks,
Guillem