2019-10-21 23:58:23

by Yi Wang

Subject: [RESEND][PATCH net-next] net: sched: taprio: fix -Wmissing-prototypes warnings

We get one warnings when build kernel W=1:
net/sched/sch_taprio.c:1155:6: warning: no previous prototype for ‘taprio_offload_config_changed’ [-Wmissing-prototypes]

Make the function static to fix this.

Signed-off-by: Yi Wang <[email protected]>
Acked-by: Vinicius Costa Gomes <[email protected]>
---
net/sched/sch_taprio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/sched/sch_taprio.c b/net/sched/sch_taprio.c
index 6719a65..2121187 100644
--- a/net/sched/sch_taprio.c
+++ b/net/sched/sch_taprio.c
@@ -1152,7 +1152,7 @@ void taprio_offload_free(struct tc_taprio_qopt_offload *offload)
* offload state (PENDING, ACTIVE, INACTIVE) so it can be visible in dump().
* This is left as TODO.
*/
-void taprio_offload_config_changed(struct taprio_sched *q)
+static void taprio_offload_config_changed(struct taprio_sched *q)
{
struct sched_gate_list *oper, *admin;

--
1.8.3.1

2019-10-22 23:56:57

by Jakub Kicinski

Subject: Re: [RESEND][PATCH net-next] net: sched: taprio: fix -Wmissing-prototypes warnings

On Tue, 22 Oct 2019 07:57:42 +0800, Yi Wang wrote:
> We get one warnings when build kernel W=1:
> net/sched/sch_taprio.c:1155:6: warning: no previous prototype for ‘taprio_offload_config_changed’ [-Wmissing-prototypes]
>
> Make the function static to fix this.
>
> Signed-off-by: Yi Wang <[email protected]>
> Acked-by: Vinicius Costa Gomes <[email protected]>

Thank you!

I've added Fixes tag and applied this to the net tree, since the warning
is already present there.