2019-10-23 11:12:46

by Wambui Karuga

Subject: [Outreachy][PATCH] drm/mediatek: remove cast to pointers passed to kfree

Remove unnecessary casts to pointer types passed to kfree.
Issue detected by coccinelle:
@@
type t1;
expression *e;
@@

-kfree((t1 *)e);
+kfree(e);

Signed-off-by: Wambui Karuga <[email protected]>
---
drivers/gpu/drm/mediatek/mtk_drm_gem.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/mediatek/mtk_drm_gem.c b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
index ca672f1d140d..b04a3c2b111e 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_gem.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
@@ -271,7 +271,7 @@ void *mtk_drm_gem_prime_vmap(struct drm_gem_object *obj)
pgprot_writecombine(PAGE_KERNEL));

out:
- kfree((void *)sgt);
+ kfree(sgt);

return mtk_gem->kvaddr;
}
@@ -285,5 +285,5 @@ void mtk_drm_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr)

vunmap(vaddr);
mtk_gem->kvaddr = 0;
- kfree((void *)mtk_gem->pages);
+ kfree(mtk_gem->pages);
}
--
2.23.0

2019-10-25 12:43:46

by Daniel Vetter

Subject: Re: [Outreachy][PATCH] drm/mediatek: remove cast to pointers passed to kfree

On Wed, Oct 23, 2019 at 02:11:07PM +0300, Wambui Karuga wrote:
> Remove unnecessary casts to pointer types passed to kfree.
> Issue detected by coccinelle:
> @@
> type t1;
> expression *e;
> @@
>
> -kfree((t1 *)e);
> +kfree(e);
>
> Signed-off-by: Wambui Karuga <[email protected]>

Applied to drm-misc-next, thanks for your patch.
-Daniel

> ---
> drivers/gpu/drm/mediatek/mtk_drm_gem.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_gem.c b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
> index ca672f1d140d..b04a3c2b111e 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_gem.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
> @@ -271,7 +271,7 @@ void *mtk_drm_gem_prime_vmap(struct drm_gem_object *obj)
> pgprot_writecombine(PAGE_KERNEL));
>
> out:
> - kfree((void *)sgt);
> + kfree(sgt);
>
> return mtk_gem->kvaddr;
> }
> @@ -285,5 +285,5 @@ void mtk_drm_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr)
>
> vunmap(vaddr);
> mtk_gem->kvaddr = 0;
> - kfree((void *)mtk_gem->pages);
> + kfree(mtk_gem->pages);
> }
> --
> 2.23.0
>

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch